Title: [164813] trunk/Source/_javascript_Core
Revision
164813
Author
commit-qu...@webkit.org
Date
2014-02-27 10:47:54 -0800 (Thu, 27 Feb 2014)

Log Message

Fix 32-bit V_JITOperation_EJ callOperation introduced in r162652.
https://bugs.webkit.org/show_bug.cgi?id=129420

Patch by Julien Brianceau <jbria...@cisco.com> on 2014-02-27
Reviewed by Geoffrey Garen.

* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation): Payload and tag are swapped.
Also, EABI_32BIT_DUMMY_ARG is missing for arm EABI and mips.

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (164812 => 164813)


--- trunk/Source/_javascript_Core/ChangeLog	2014-02-27 18:34:27 UTC (rev 164812)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-02-27 18:47:54 UTC (rev 164813)
@@ -1,3 +1,14 @@
+2014-02-27  Julien Brianceau   <jbria...@cisco.com>
+
+        Fix 32-bit V_JITOperation_EJ callOperation introduced in r162652.
+        https://bugs.webkit.org/show_bug.cgi?id=129420
+
+        Reviewed by Geoffrey Garen.
+
+        * dfg/DFGSpeculativeJIT.h:
+        (JSC::DFG::SpeculativeJIT::callOperation): Payload and tag are swapped.
+        Also, EABI_32BIT_DUMMY_ARG is missing for arm EABI and mips.
+
 2014-02-27  Filip Pizlo  <fpi...@apple.com>
 
         Octane/closure thrashes between flattening dictionaries during global object initialization in a global eval

Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h (164812 => 164813)


--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h	2014-02-27 18:34:27 UTC (rev 164812)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h	2014-02-27 18:47:54 UTC (rev 164813)
@@ -1640,7 +1640,7 @@
 
     JITCompiler::Call callOperation(V_JITOperation_EJ operation, GPRReg arg1Tag, GPRReg arg1Payload)
     {
-        m_jit.setupArgumentsWithExecState(arg1Tag, arg1Payload);
+        m_jit.setupArgumentsWithExecState(EABI_32BIT_DUMMY_ARG arg1Payload, arg1Tag);
         return appendCallWithExceptionCheck(operation);
     }
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to