Title: [164831] trunk/Source/WebKit2
- Revision
- 164831
- Author
- [email protected]
- Date
- 2014-02-27 14:55:44 -0800 (Thu, 27 Feb 2014)
Log Message
Crash tapping on play button on video on iOS
https://bugs.webkit.org/show_bug.cgi?id=129452
Reviewed by Benjamin Poulain.
node->computedStyle() can return null. Just use
renderer->style() to get the tap highlight color.
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::tapHighlightAtPosition):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (164830 => 164831)
--- trunk/Source/WebKit2/ChangeLog 2014-02-27 22:08:10 UTC (rev 164830)
+++ trunk/Source/WebKit2/ChangeLog 2014-02-27 22:55:44 UTC (rev 164831)
@@ -1,3 +1,16 @@
+2014-02-27 Simon Fraser <[email protected]>
+
+ Crash tapping on play button on video on iOS
+ https://bugs.webkit.org/show_bug.cgi?id=129452
+
+ Reviewed by Benjamin Poulain.
+
+ node->computedStyle() can return null. Just use
+ renderer->style() to get the tap highlight color.
+
+ * WebProcess/WebPage/ios/WebPageIOS.mm:
+ (WebKit::WebPage::tapHighlightAtPosition):
+
2014-02-27 Brian Burg <[email protected]>
Web Inspector: model tests should use a special Test.html inspector page
Modified: trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm (164830 => 164831)
--- trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm 2014-02-27 22:08:10 UTC (rev 164830)
+++ trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm 2014-02-27 22:55:44 UTC (rev 164831)
@@ -367,7 +367,7 @@
Vector<FloatQuad> quads;
if (renderer) {
renderer->absoluteQuads(quads);
- Color highlightColor = node->computedStyle()->tapHighlightColor();
+ Color highlightColor = renderer->style().tapHighlightColor();
if (!node->document().frame()->isMainFrame()) {
FrameView* view = node->document().frame()->view();
for (size_t i = 0; i < quads.size(); ++i) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
