Title: [164887] trunk/Source/WebKit2
Revision
164887
Author
[email protected]
Date
2014-02-28 15:04:05 -0800 (Fri, 28 Feb 2014)

Log Message

AX: Crash in WebKit::WebPageProxy::registerWebProcessAccessibilityToken
https://bugs.webkit.org/show_bug.cgi?id=127387

Reviewed by Alexey Proskuryakov.

Speculative fix for crasher. We should check if the connection is still valid before proceeding.

* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::registerWebProcessAccessibilityToken):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (164886 => 164887)


--- trunk/Source/WebKit2/ChangeLog	2014-02-28 22:54:47 UTC (rev 164886)
+++ trunk/Source/WebKit2/ChangeLog	2014-02-28 23:04:05 UTC (rev 164887)
@@ -1,3 +1,15 @@
+2014-02-28  Chris Fleizach  <[email protected]>
+
+        AX: Crash in WebKit::WebPageProxy::registerWebProcessAccessibilityToken
+        https://bugs.webkit.org/show_bug.cgi?id=127387
+
+        Reviewed by Alexey Proskuryakov.
+
+        Speculative fix for crasher. We should check if the connection is still valid before proceeding.
+
+        * UIProcess/mac/WebPageProxyMac.mm:
+        (WebKit::WebPageProxy::registerWebProcessAccessibilityToken):
+
 2014-02-28  Timothy Hatcher  <[email protected]>
 
         Properly handle when Test.html is not present in Production builds.

Modified: trunk/Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm (164886 => 164887)


--- trunk/Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm	2014-02-28 22:54:47 UTC (rev 164886)
+++ trunk/Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm	2014-02-28 23:04:05 UTC (rev 164887)
@@ -395,6 +395,9 @@
     
 void WebPageProxy::registerWebProcessAccessibilityToken(const IPC::DataReference& data)
 {
+    if (!isValid())
+        return;
+    
     m_pageClient.accessibilityWebProcessTokenReceived(data);
 }    
     
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to