Title: [164896] trunk/Source/WebCore
- Revision
- 164896
- Author
- [email protected]
- Date
- 2014-02-28 16:42:29 -0800 (Fri, 28 Feb 2014)
Log Message
Web Inspector: ASSERT in WebCore::JSDOMWindowBase::supportsRichSourceInfo inspecting iOS
https://bugs.webkit.org/show_bug.cgi?id=129512
Patch by Joseph Pecoraro <[email protected]> on 2014-02-28
Reviewed by Simon Fraser.
* page/PageDebuggable.cpp:
(WebCore::PageDebuggable::connect):
(WebCore::PageDebuggable::disconnect):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (164895 => 164896)
--- trunk/Source/WebCore/ChangeLog 2014-03-01 00:40:22 UTC (rev 164895)
+++ trunk/Source/WebCore/ChangeLog 2014-03-01 00:42:29 UTC (rev 164896)
@@ -1,3 +1,14 @@
+2014-02-28 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: ASSERT in WebCore::JSDOMWindowBase::supportsRichSourceInfo inspecting iOS
+ https://bugs.webkit.org/show_bug.cgi?id=129512
+
+ Reviewed by Simon Fraser.
+
+ * page/PageDebuggable.cpp:
+ (WebCore::PageDebuggable::connect):
+ (WebCore::PageDebuggable::disconnect):
+
2014-02-28 Anders Carlsson <[email protected]>
VisitedLinkStore should be able to invalidate link styles for associated pages
Modified: trunk/Source/WebCore/page/PageDebuggable.cpp (164895 => 164896)
--- trunk/Source/WebCore/page/PageDebuggable.cpp 2014-03-01 00:40:22 UTC (rev 164895)
+++ trunk/Source/WebCore/page/PageDebuggable.cpp 2014-03-01 00:42:29 UTC (rev 164896)
@@ -36,6 +36,10 @@
#include "Page.h"
#include <inspector/InspectorAgentBase.h>
+#if PLATFORM(IOS)
+#include "Settings.h"
+#endif
+
using namespace Inspector;
namespace WebCore {
@@ -77,6 +81,12 @@
void PageDebuggable::connect(Inspector::InspectorFrontendChannel* channel)
{
+#if PLATFORM(IOS)
+ // On iOS there is no way to enable / disable developer extras.
+ // So toggle it on when we have a remote inspector connection.
+ m_page.settings().setDeveloperExtrasEnabled(true);
+#endif
+
InspectorController& inspectorController = m_page.inspectorController();
inspectorController.setHasRemoteFrontend(true);
inspectorController.connectFrontend(reinterpret_cast<WebCore::InspectorFrontendChannel*>(channel));
@@ -87,6 +97,10 @@
InspectorController& inspectorController = m_page.inspectorController();
inspectorController.disconnectFrontend(InspectorDisconnectReason::InspectorDestroyed);
inspectorController.setHasRemoteFrontend(false);
+
+#if PLATFORM(IOS)
+ m_page.settings().setDeveloperExtrasEnabled(false);
+#endif
}
void PageDebuggable::dispatchMessageFromRemoteFrontend(const String& message)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
