Title: [165009] trunk/Source/_javascript_Core
- Revision
- 165009
- Author
- [email protected]
- Date
- 2014-03-03 14:28:16 -0800 (Mon, 03 Mar 2014)
Log Message
[x86] Improve code generation of byte test
https://bugs.webkit.org/show_bug.cgi?id=129597
Reviewed by Geoffrey Garen.
When possible, test the 8 bit register to itself instead of comparing it
to a literal.
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::test32):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (165008 => 165009)
--- trunk/Source/_javascript_Core/ChangeLog 2014-03-03 22:12:10 UTC (rev 165008)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-03-03 22:28:16 UTC (rev 165009)
@@ -1,3 +1,16 @@
+2014-03-03 Benjamin Poulain <[email protected]>
+
+ [x86] Improve code generation of byte test
+ https://bugs.webkit.org/show_bug.cgi?id=129597
+
+ Reviewed by Geoffrey Garen.
+
+ When possible, test the 8 bit register to itself instead of comparing it
+ to a literal.
+
+ * assembler/MacroAssemblerX86Common.h:
+ (JSC::MacroAssemblerX86Common::test32):
+
2014-03-03 Mark Lam <[email protected]>
Web Inspector: debugger statements do not break.
Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerX86Common.h (165008 => 165009)
--- trunk/Source/_javascript_Core/assembler/MacroAssemblerX86Common.h 2014-03-03 22:12:10 UTC (rev 165008)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerX86Common.h 2014-03-03 22:28:16 UTC (rev 165009)
@@ -1149,9 +1149,12 @@
{
if (mask.m_value == -1)
m_assembler.testl_rr(reg, reg);
- else if (!(mask.m_value & ~0xff) && reg < X86Registers::esp) // Using esp and greater as a byte register yields the upper half of the 16 bit registers ax, cx, dx and bx, e.g. esp, register 4, is actually ah.
- m_assembler.testb_i8r(mask.m_value, reg);
- else
+ else if (!(mask.m_value & ~0xff) && reg < X86Registers::esp) { // Using esp and greater as a byte register yields the upper half of the 16 bit registers ax, cx, dx and bx, e.g. esp, register 4, is actually ah.
+ if (mask.m_value == 0xff)
+ m_assembler.testb_rr(reg, reg);
+ else
+ m_assembler.testb_i8r(mask.m_value, reg);
+ } else
m_assembler.testl_i32r(mask.m_value, reg);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
