Title: [165030] trunk/Source/WebCore
Revision
165030
Author
[email protected]
Date
2014-03-03 17:53:38 -0800 (Mon, 03 Mar 2014)

Log Message

[iOS] Start playback button misplaced
https://bugs.webkit.org/show_bug.cgi?id=129628

Reviewed by Simon Fraser.

On YouTube embeds, while the video is loading it is placed into the DOM with a 0x0 size.
This causes the start playback button to be visible in the upper-left corner of the embed
area. The button wasn't visible previously (in plugin mode) because the plugin clipped its
drawing to its bounds, and so the <video> shadow should do the same.

* Modules/mediacontrols/mediaControlsiOS.css:
(::-webkit-media-controls):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (165029 => 165030)


--- trunk/Source/WebCore/ChangeLog	2014-03-04 01:45:32 UTC (rev 165029)
+++ trunk/Source/WebCore/ChangeLog	2014-03-04 01:53:38 UTC (rev 165030)
@@ -1,3 +1,18 @@
+2014-03-03  Jer Noble  <[email protected]>
+
+        [iOS] Start playback button misplaced
+        https://bugs.webkit.org/show_bug.cgi?id=129628
+
+        Reviewed by Simon Fraser.
+
+        On YouTube embeds, while the video is loading it is placed into the DOM with a 0x0 size.
+        This causes the start playback button to be visible in the upper-left corner of the embed
+        area. The button wasn't visible previously (in plugin mode) because the plugin clipped its
+        drawing to its bounds, and so the <video> shadow should do the same.
+
+        * Modules/mediacontrols/mediaControlsiOS.css:
+        (::-webkit-media-controls):
+
 2014-03-03  Enrica Casucci  <[email protected]>
 
         Build fix for iOS simulator.

Modified: trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css (165029 => 165030)


--- trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css	2014-03-04 01:45:32 UTC (rev 165029)
+++ trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css	2014-03-04 01:53:38 UTC (rev 165030)
@@ -53,6 +53,7 @@
     -webkit-justify-content: flex-end;
     -webkit-flex-direction: column;
     font-family: -apple-system-font;
+    overflow: hidden;
 }
 
 video::-webkit-media-controls-panel input[type="button"],
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to