Title: [165034] trunk/Source/WebKit2
Revision
165034
Author
[email protected]
Date
2014-03-03 19:24:32 -0800 (Mon, 03 Mar 2014)

Log Message

[iOS][WK2] WebPage::updateVisibleContentRects can set the position directly instead of using programmatic scrolling
https://bugs.webkit.org/show_bug.cgi?id=129649

Patch by Benjamin Poulain <[email protected]> on 2014-03-03
Reviewed by Sam Weinig.

* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::updateVisibleContentRects):
Update my workaround from r165003. We should not use programmatic scrolling when the scroll position is changed
from the UI.

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (165033 => 165034)


--- trunk/Source/WebKit2/ChangeLog	2014-03-04 03:23:58 UTC (rev 165033)
+++ trunk/Source/WebKit2/ChangeLog	2014-03-04 03:24:32 UTC (rev 165034)
@@ -1,5 +1,17 @@
 2014-03-03  Benjamin Poulain  <[email protected]>
 
+        [iOS][WK2] WebPage::updateVisibleContentRects can set the position directly instead of using programmatic scrolling
+        https://bugs.webkit.org/show_bug.cgi?id=129649
+
+        Reviewed by Sam Weinig.
+
+        * WebProcess/WebPage/ios/WebPageIOS.mm:
+        (WebKit::WebPage::updateVisibleContentRects):
+        Update my workaround from r165003. We should not use programmatic scrolling when the scroll position is changed
+        from the UI.
+
+2014-03-03  Benjamin Poulain  <[email protected]>
+
         [iOS][WK2] Update UIScrollView's contentSize when a new layer tree is committed
         https://bugs.webkit.org/show_bug.cgi?id=129641
 

Modified: trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm (165033 => 165034)


--- trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm	2014-03-04 03:23:58 UTC (rev 165033)
+++ trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm	2014-03-04 03:24:32 UTC (rev 165034)
@@ -1733,7 +1733,7 @@
         send(Messages::WebPageProxy::PageScaleFactorDidChange(floatBoundedScale));
     }
 
-    m_page->mainFrame().view()->setScrollPosition(scrollPosition);
+    m_page->mainFrame().view()->setScrollOffset(scrollPosition);
     // FIXME: we should also update the frame view from unobscured rect. Altenatively, we can have it pull the values from ScrollView.
 }
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to