Title: [165051] trunk/Source/WebKit2
- Revision
- 165051
- Author
- [email protected]
- Date
- 2014-03-04 08:22:30 -0800 (Tue, 04 Mar 2014)
Log Message
[WK2] Selection remains after reload.
https://bugs.webkit.org/show_bug.cgi?id=129648
<rdar://problem/16207547>
Reviewed by Sam Weinig.
We normally clear the selection when resigninig first responder but
that doesn't get called when reloading the page or when navigating with
back/forward buttons. The correct place to do this is when we get
_didCommitLoadForMainFrame where we already stop assisting the node.
The method we call into webselectionassistant is resignedFirstResponder
which takes care of clearing the selection and removing the selection view.
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _stopAssistingNode]):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (165050 => 165051)
--- trunk/Source/WebKit2/ChangeLog 2014-03-04 16:17:46 UTC (rev 165050)
+++ trunk/Source/WebKit2/ChangeLog 2014-03-04 16:22:30 UTC (rev 165051)
@@ -1,3 +1,21 @@
+2014-03-03 Enrica Casucci <[email protected]>
+
+ [WK2] Selection remains after reload.
+ https://bugs.webkit.org/show_bug.cgi?id=129648
+ <rdar://problem/16207547>
+
+ Reviewed by Sam Weinig.
+
+ We normally clear the selection when resigninig first responder but
+ that doesn't get called when reloading the page or when navigating with
+ back/forward buttons. The correct place to do this is when we get
+ _didCommitLoadForMainFrame where we already stop assisting the node.
+ The method we call into webselectionassistant is resignedFirstResponder
+ which takes care of clearing the selection and removing the selection view.
+
+ * UIProcess/ios/WKContentViewInteraction.mm:
+ (-[WKContentView _stopAssistingNode]):
+
2014-03-04 Hyowon Kim <[email protected]>
Move EvasGLContext and EvasGLSurface files into the efl common directory.
Modified: trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm (165050 => 165051)
--- trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm 2014-03-04 16:17:46 UTC (rev 165050)
+++ trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm 2014-03-04 16:22:30 UTC (rev 165051)
@@ -1874,6 +1874,8 @@
[self _stopAssistingKeyboard];
[self reloadInputViews];
[self _updateAccessory];
+ // The name is misleading, but this actually clears the selection views and removes any selection.
+ [_webSelectionAssistant resignedFirstResponder];
}
- (void)_selectionChanged
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
