Title: [165064] trunk/Source/WebCore
- Revision
- 165064
- Author
- [email protected]
- Date
- 2014-03-04 11:43:49 -0800 (Tue, 04 Mar 2014)
Log Message
Crashes and assertions running iOS compositing tests
https://bugs.webkit.org/show_bug.cgi?id=129688
Reviewed by Dean Jackson.
When a layer is no longer composited, we need to unregister it
from the scrolling coordinator, and remove it from m_scrollCoordinatedLayers.
Tested by compositing tests on iOS.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateBacking):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (165063 => 165064)
--- trunk/Source/WebCore/ChangeLog 2014-03-04 19:31:35 UTC (rev 165063)
+++ trunk/Source/WebCore/ChangeLog 2014-03-04 19:43:49 UTC (rev 165064)
@@ -1,3 +1,18 @@
+2014-03-04 Simon Fraser <[email protected]>
+
+ Crashes and assertions running iOS compositing tests
+ https://bugs.webkit.org/show_bug.cgi?id=129688
+
+ Reviewed by Dean Jackson.
+
+ When a layer is no longer composited, we need to unregister it
+ from the scrolling coordinator, and remove it from m_scrollCoordinatedLayers.
+
+ Tested by compositing tests on iOS.
+
+ * rendering/RenderLayerCompositor.cpp:
+ (WebCore::RenderLayerCompositor::updateBacking):
+
2014-03-04 Antti Koivisto <[email protected]>
Update bindings test results after r165046.
Modified: trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp (165063 => 165064)
--- trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2014-03-04 19:31:35 UTC (rev 165063)
+++ trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2014-03-04 19:43:49 UTC (rev 165064)
@@ -807,8 +807,8 @@
}
}
- detachScrollCoordinatedLayer(layer);
-
+ removeFromScrollCoordinatedLayers(layer);
+
layer.clearBacking();
layerChanged = true;
@@ -3373,6 +3373,8 @@
m_scrollCoordinatedLayers.remove(&layer);
m_scrollCoordinatedLayersNeedingUpdate.remove(&layer);
+
+ detachScrollCoordinatedLayer(layer);
}
FixedPositionViewportConstraints RenderLayerCompositor::computeFixedViewportConstraints(RenderLayer& layer) const
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
