Diff
Modified: trunk/LayoutTests/ChangeLog (165101 => 165102)
--- trunk/LayoutTests/ChangeLog 2014-03-05 10:20:23 UTC (rev 165101)
+++ trunk/LayoutTests/ChangeLog 2014-03-05 10:35:14 UTC (rev 165102)
@@ -1,5 +1,29 @@
2014-03-05 Grzegorz Czajkowski <[email protected]>
+ Remove unsupported spelling tests.
+ https://bugs.webkit.org/show_bug.cgi?id=129482
+
+ Reviewed by Ryosuke Niwa.
+
+ Remove two spelling tests that require spellchecking of multiple words.
+ Currently, neither WebKit port is supporting this feature.
+ Those tests were added by Chromium at r141354.
+
+ * editing/spelling/spelling-exactly-selected-multiple-words-expected.txt: Removed.
+ * editing/spelling/spelling-exactly-selected-multiple-words.html: Removed.
+ * editing/spelling/spelling-should-select-multiple-words-expected.txt: Removed.
+ * editing/spelling/spelling-should-select-multiple-words.html: Removed.
+
+ * platform/efl-wk2/TestExpectations:
+ * platform/gtk/TestExpectations:
+ * platform/mac-wk2/TestExpectations:
+ * platform/mac/TestExpectations:
+ * platform/win/TestExpectations:
+ * platform/wincairo/TestExpectations:
+ Clear TestExpectations.
+
+2014-03-05 Grzegorz Czajkowski <[email protected]>
+
Refactoring spelling-insert-html.html to use asynchronous spellchecking
https://bugs.webkit.org/show_bug.cgi?id=129422
Deleted: trunk/LayoutTests/editing/spelling/spelling-exactly-selected-multiple-words-expected.txt (165101 => 165102)
--- trunk/LayoutTests/editing/spelling/spelling-exactly-selected-multiple-words-expected.txt 2014-03-05 10:20:23 UTC (rev 165101)
+++ trunk/LayoutTests/editing/spelling/spelling-exactly-selected-multiple-words-expected.txt 2014-03-05 10:35:14 UTC (rev 165102)
@@ -1,16 +0,0 @@
-Spelling should work when the user selects a multi-word misspelling exactly. To test manually, enable 'Ask Google for Suggestions' in Chrome, type 'It should be upper case.', select 'upper case', and context-click on the selection.The test succeeds when the context menu shows spelling suggestions.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS internals.markerCountForNode(destination.childNodes[0], "spelling") became different from 0
-PASS spellingMarkerRange.toString() is "upper case"
-PASS window.getSelection().toString() is ""
-PASS window.getSelection().toString() is "upper case"
-PASS spellingMarkerRange.toString() is "upper case"
-PASS window.getSelection().toString() is "upper case"
-PASS contextMenuElements[contextMenuElements.length - 1] is "uppercase"
-PASS successfullyParsed is true
-
-TEST COMPLETE
-It should be upper case.
Deleted: trunk/LayoutTests/editing/spelling/spelling-exactly-selected-multiple-words.html (165101 => 165102)
--- trunk/LayoutTests/editing/spelling/spelling-exactly-selected-multiple-words.html 2014-03-05 10:20:23 UTC (rev 165101)
+++ trunk/LayoutTests/editing/spelling/spelling-exactly-selected-multiple-words.html 2014-03-05 10:35:14 UTC (rev 165102)
@@ -1,48 +0,0 @@
-<!DOCTYPE html>
-<html>
-<head>
-<script src=""
-<script src=""
-</head>
-<body>
-<div id="container">
- <div id="destination" contentEditable></div>
-</div>
-<script>
-
-description("Spelling should work when the user selects a multi-word misspelling exactly. " +
- "To test manually, enable 'Ask Google for Suggestions' in Chrome, type 'It should be upper case.', select 'upper case', and context-click on the selection." +
- "The test succeeds when the context menu shows spelling suggestions.");
-
-initSpellTest("destination", "It should be upper case.", function(textNode) {
- spellingMarkerRange = internals.markerRangeForNode(textNode, "spelling", 0);
- shouldBeEqualToString("spellingMarkerRange.toString()", "upper case");
- shouldBeEqualToString("window.getSelection().toString()", "");
-
- // Select the multi-word misspelling without surrounding whitespace or punctuation.
- var wordRange = document.createRange();
- wordRange.setStart(textNode, 13);
- wordRange.setEnd(textNode, 23);
- window.getSelection().removeAllRanges();
- window.getSelection().addRange(wordRange);
-
- shouldBeEqualToString("window.getSelection().toString()", "upper case");
-
- // Context click on "upper case" to show the context menu.
- var x = destination.offsetParent.offsetLeft + destination.offsetLeft + 100;
- var y = destination.offsetParent.offsetTop + destination.offsetTop + destination.offsetHeight / 2;
- eventSender.mouseMoveTo(x, y);
- contextMenuElements = eventSender.contextClick();
- // Esc key to hide the context menu.
- eventSender.keyDown(String.fromCharCode(0x001B), null);
-
- spellingMarkerRange = internals.markerRangeForNode(textNode, "spelling", 0);
- shouldBeEqualToString("spellingMarkerRange.toString()", "upper case");
- shouldBeEqualToString("window.getSelection().toString()", "upper case");
- shouldBeEqualToString("contextMenuElements[contextMenuElements.length - 1]", "uppercase");
-});
-
-</script>
-<script src=""
-</body>
-</html>
Deleted: trunk/LayoutTests/editing/spelling/spelling-should-select-multiple-words-expected.txt (165101 => 165102)
--- trunk/LayoutTests/editing/spelling/spelling-should-select-multiple-words-expected.txt 2014-03-05 10:20:23 UTC (rev 165101)
+++ trunk/LayoutTests/editing/spelling/spelling-should-select-multiple-words-expected.txt 2014-03-05 10:35:14 UTC (rev 165102)
@@ -1,15 +0,0 @@
-Spell check should select multi-word misspellings on context click. To test manually, enable 'Ask Google for Suggestions' in Chrome, type 'It should be upper case.', and context-click on the word 'upper'. The test succeeds when 'upper case' was selected after context click.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS internals.markerCountForNode(destination.childNodes[0], "spelling") became different from 0
-PASS spellingMarkerRange.toString() is "upper case"
-PASS window.getSelection().toString() is ""
-PASS spellingMarkerRange.toString() is "upper case"
-PASS window.getSelection().toString() is "upper case"
-PASS contextMenuElements[contextMenuElements.length - 1] is "uppercase"
-PASS successfullyParsed is true
-
-TEST COMPLETE
-It should be upper case.
Deleted: trunk/LayoutTests/editing/spelling/spelling-should-select-multiple-words.html (165101 => 165102)
--- trunk/LayoutTests/editing/spelling/spelling-should-select-multiple-words.html 2014-03-05 10:20:23 UTC (rev 165101)
+++ trunk/LayoutTests/editing/spelling/spelling-should-select-multiple-words.html 2014-03-05 10:35:14 UTC (rev 165102)
@@ -1,39 +0,0 @@
-<!DOCTYPE html>
-<html>
-<head>
-<script src=""
-<script src=""
-</head>
-<body>
-<div id="container">
- <div id="destination" contentEditable></div>
-</div>
-<script>
-
-description("Spell check should select multi-word misspellings on context click. "+
- "To test manually, enable 'Ask Google for Suggestions' in Chrome, type 'It should be upper case.', and context-click on the word 'upper'. " +
- "The test succeeds when 'upper case' was selected after context click.");
-
-initSpellTest("destination", "It should be upper case.", function(textNode) {
- spellingMarkerRange = internals.markerRangeForNode(textNode, "spelling", 0);
- shouldBeEqualToString("spellingMarkerRange.toString()", "upper case");
- shouldBeEqualToString("window.getSelection().toString()", "");
-
- // Context click on "upper case" to show the context menu.
- var x = destination.offsetParent.offsetLeft + destination.offsetLeft + 100;
- var y = destination.offsetParent.offsetTop + destination.offsetTop + destination.offsetHeight / 2;
- eventSender.mouseMoveTo(x, y);
- contextMenuElements = eventSender.contextClick();
- // Esc key to hide the context menu.
- eventSender.keyDown(String.fromCharCode(0x001B), null);
-
- spellingMarkerRange = internals.markerRangeForNode(textNode, "spelling", 0);
- shouldBeEqualToString("spellingMarkerRange.toString()", "upper case");
- shouldBeEqualToString("window.getSelection().toString()", "upper case");
- shouldBeEqualToString("contextMenuElements[contextMenuElements.length - 1]", "uppercase");
-});
-
-</script>
-<script src=""
-</body>
-</html>
Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (165101 => 165102)
--- trunk/LayoutTests/platform/efl-wk2/TestExpectations 2014-03-05 10:20:23 UTC (rev 165101)
+++ trunk/LayoutTests/platform/efl-wk2/TestExpectations 2014-03-05 10:35:14 UTC (rev 165102)
@@ -320,11 +320,6 @@
# EFL's text checker doesn't support the text replacement feature.
Bug(EFL) editing/spelling/spelling-marker-description.html [ Failure ]
-# EFL's text checker doesn't support multi-word misspelling.
-# Mac bug: https://bugs.webkit.org/show_bug.cgi?id=114470
-editing/spelling/spelling-exactly-selected-multiple-words.html [ Failure ]
-editing/spelling/spelling-should-select-multiple-words.html [ Failure ]
-
# Fails because MutationObservers are not notified at end-of-task.
webkit.org/b/78290 fast/dom/MutationObserver/end-of-task-delivery.html [ Failure ]
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (165101 => 165102)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2014-03-05 10:20:23 UTC (rev 165101)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2014-03-05 10:35:14 UTC (rev 165102)
@@ -1331,9 +1331,7 @@
webkit.org/b/108370 editing/spelling/context-menu-suggestions-multiword-selection.html [ Skip ]
webkit.org/b/108370 editing/spelling/context-menu-suggestions-subword-selection.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-double-clicked-word.html [ Skip ]
-webkit.org/b/108370 editing/spelling/spelling-exactly-selected-multiple-words.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-exactly-selected-word.html [ Skip ]
-webkit.org/b/108370 editing/spelling/spelling-should-select-multiple-words.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-with-punctuation-selection.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-with-whitespace-selection.html [ Skip ]
Modified: trunk/LayoutTests/platform/mac/TestExpectations (165101 => 165102)
--- trunk/LayoutTests/platform/mac/TestExpectations 2014-03-05 10:20:23 UTC (rev 165101)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2014-03-05 10:35:14 UTC (rev 165102)
@@ -998,9 +998,6 @@
webkit.org/b/119374 fast/workers/termination-early.html [ Pass Crash ]
webkit.org/b/119375 fast/workers/worker-call.html [ Failure ]
-
-webkit.org/b/114470 editing/spelling/spelling-exactly-selected-multiple-words.html [ Skip ]
-webkit.org/b/114470 editing/spelling/spelling-should-select-multiple-words.html [ Skip ]
webkit.org/b/110027 compositing/transitions/transform-on-large-layer.html [ Pass ImageOnlyFailure ]
Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (165101 => 165102)
--- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2014-03-05 10:20:23 UTC (rev 165101)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2014-03-05 10:35:14 UTC (rev 165102)
@@ -126,11 +126,9 @@
webkit.org/b/105616 editing/spelling/spelling-attribute-at-child.html
webkit.org/b/105616 editing/spelling/spelling-attribute-change.html
webkit.org/b/105616 editing/spelling/spelling-double-clicked-word.html
-webkit.org/b/105616 editing/spelling/spelling-exactly-selected-multiple-words.html
webkit.org/b/105616 editing/spelling/spelling-exactly-selected-word.html
webkit.org/b/105616 editing/spelling/spelling-hasspellingmarker.html
webkit.org/b/105616 editing/spelling/spelling-linebreak.html
-webkit.org/b/105616 editing/spelling/spelling-should-select-multiple-words.html
webkit.org/b/105616 editing/spelling/spelling-with-punctuation-selection.html
webkit.org/b/105616 editing/spelling/spelling-with-whitespace-selection.html
webkit.org/b/105616 editing/spelling/spellcheck-input-search-crash.html
Modified: trunk/LayoutTests/platform/win/TestExpectations (165101 => 165102)
--- trunk/LayoutTests/platform/win/TestExpectations 2014-03-05 10:20:23 UTC (rev 165101)
+++ trunk/LayoutTests/platform/win/TestExpectations 2014-03-05 10:35:14 UTC (rev 165102)
@@ -1974,9 +1974,7 @@
webkit.org/b/108370 editing/spelling/context-menu-suggestions-multiword-selection.html [ Failure ]
webkit.org/b/108370 editing/spelling/context-menu-suggestions-subword-selection.html [ Failure ]
webkit.org/b/108370 editing/spelling/spelling-double-clicked-word.html [ Failure ]
-webkit.org/b/108370 editing/spelling/spelling-exactly-selected-multiple-words.html [ Failure ]
webkit.org/b/108370 editing/spelling/spelling-exactly-selected-word.html [ Failure ]
-webkit.org/b/108370 editing/spelling/spelling-should-select-multiple-words.html [ Failure ]
webkit.org/b/108370 editing/spelling/spelling-with-punctuation-selection.html [ Failure ]
webkit.org/b/108370 editing/spelling/spelling-with-whitespace-selection.html [ Failure ]
webkit.org/b/108370 editing/spelling/spellcheck-async-mutation.html [ Failure ]
Modified: trunk/LayoutTests/platform/wincairo/TestExpectations (165101 => 165102)
--- trunk/LayoutTests/platform/wincairo/TestExpectations 2014-03-05 10:20:23 UTC (rev 165101)
+++ trunk/LayoutTests/platform/wincairo/TestExpectations 2014-03-05 10:35:14 UTC (rev 165102)
@@ -2821,9 +2821,7 @@
webkit.org/b/108370 editing/spelling/context-menu-suggestions-multiword-selection.html [ Skip ]
webkit.org/b/108370 editing/spelling/context-menu-suggestions-subword-selection.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-double-clicked-word.html [ Skip ]
-webkit.org/b/108370 editing/spelling/spelling-exactly-selected-multiple-words.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-exactly-selected-word.html [ Skip ]
-webkit.org/b/108370 editing/spelling/spelling-should-select-multiple-words.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-with-punctuation-selection.html [ Skip ]
webkit.org/b/108370 editing/spelling/spelling-with-whitespace-selection.html [ Skip ]
