Title: [165115] trunk/Source/_javascript_Core
- Revision
- 165115
- Author
- [email protected]
- Date
- 2014-03-05 10:59:58 -0800 (Wed, 05 Mar 2014)
Log Message
Tweak after r165109 to avoid extra copies
https://bugs.webkit.org/show_bug.cgi?id=129745
Reviewed by Geoffrey Garen.
* heap/Heap.cpp:
(JSC::Heap::visitProtectedObjects):
(JSC::Heap::visitTempSortVectors):
(JSC::Heap::clearRememberedSet):
* heap/Heap.h:
(JSC::Heap::forEachProtectedCell):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (165114 => 165115)
--- trunk/Source/_javascript_Core/ChangeLog 2014-03-05 18:37:59 UTC (rev 165114)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-03-05 18:59:58 UTC (rev 165115)
@@ -1,3 +1,17 @@
+2014-03-05 Anders Carlsson <[email protected]>
+
+ Tweak after r165109 to avoid extra copies
+ https://bugs.webkit.org/show_bug.cgi?id=129745
+
+ Reviewed by Geoffrey Garen.
+
+ * heap/Heap.cpp:
+ (JSC::Heap::visitProtectedObjects):
+ (JSC::Heap::visitTempSortVectors):
+ (JSC::Heap::clearRememberedSet):
+ * heap/Heap.h:
+ (JSC::Heap::forEachProtectedCell):
+
2014-03-05 Mark Hahnenberg <[email protected]>
DFGStoreBarrierElisionPhase should should GCState directly instead of m_gcClobberSet when calling writesOverlap()
Modified: trunk/Source/_javascript_Core/heap/Heap.cpp (165114 => 165115)
--- trunk/Source/_javascript_Core/heap/Heap.cpp 2014-03-05 18:37:59 UTC (rev 165114)
+++ trunk/Source/_javascript_Core/heap/Heap.cpp 2014-03-05 18:59:58 UTC (rev 165115)
@@ -569,7 +569,7 @@
GCPHASE(VisitProtectedObjects);
MARK_LOG_ROOT(m_slotVisitor, "Protected Objects");
- for (auto pair : m_protectedValues)
+ for (auto& pair : m_protectedValues)
heapRootVisitor.visit(&pair.key);
m_slotVisitor.donateAndDrain();
}
@@ -579,10 +579,10 @@
GCPHASE(VisitTempSortVectors);
MARK_LOG_ROOT(m_slotVisitor, "Temp Sort Vectors");
- typedef Vector<Vector<ValueStringPair, 0, UnsafeVectorOverflow>* > VectorOfValueStringVectors;
+ typedef Vector<Vector<ValueStringPair, 0, UnsafeVectorOverflow>*> VectorOfValueStringVectors;
- for (auto vector : m_tempSortingVectors) {
- for (auto valueStringPair : *vector) {
+ for (auto* vector : m_tempSortingVectors) {
+ for (auto& valueStringPair : *vector) {
if (valueStringPair.first)
heapRootVisitor.visit(&valueStringPair.first);
}
@@ -668,7 +668,7 @@
{
#if ENABLE(GGC)
GCPHASE(ClearRememberedSet);
- for (auto cell : rememberedSet)
+ for (auto* cell : rememberedSet)
MarkedBlock::blockFor(cell)->clearRemembered(cell);
#else
UNUSED_PARAM(rememberedSet);
Modified: trunk/Source/_javascript_Core/heap/Heap.h (165114 => 165115)
--- trunk/Source/_javascript_Core/heap/Heap.h 2014-03-05 18:37:59 UTC (rev 165114)
+++ trunk/Source/_javascript_Core/heap/Heap.h 2014-03-05 18:59:58 UTC (rev 165115)
@@ -328,7 +328,7 @@
HashSet<const JSCell*> m_copyingRememberedSet;
ProtectCountSet m_protectedValues;
- Vector<Vector<ValueStringPair, 0, UnsafeVectorOverflow>* > m_tempSortingVectors;
+ Vector<Vector<ValueStringPair, 0, UnsafeVectorOverflow>*> m_tempSortingVectors;
OwnPtr<HashSet<MarkedArgumentBuffer*>> m_markListSet;
MachineThreads m_machineThreads;
@@ -451,7 +451,7 @@
template<typename Functor> inline typename Functor::ReturnType Heap::forEachProtectedCell(Functor& functor)
{
- for (auto pair : m_protectedValues)
+ for (auto& pair : m_protectedValues)
functor(pair.key);
m_handleSet.forEachStrongHandle(functor, m_protectedValues);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
