Title: [165174] trunk/Tools
Revision
165174
Author
[email protected]
Date
2014-03-05 22:46:53 -0800 (Wed, 05 Mar 2014)

Log Message

[GTK][CMake] Tarball is created with wrong tarball paths
https://bugs.webkit.org/show_bug.cgi?id=129496

Reviewed by Daniel Bates.

* gtk/make-dist.py:
(Manifest.__init__): I inadvertently inverted the logic of these checks when
landing the original patch with some suggestions from the reviewer. With the
checks corrected, the tarball path is constructed properly.

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (165173 => 165174)


--- trunk/Tools/ChangeLog	2014-03-06 06:46:23 UTC (rev 165173)
+++ trunk/Tools/ChangeLog	2014-03-06 06:46:53 UTC (rev 165174)
@@ -1,3 +1,15 @@
+2014-03-05  Martin Robinson  <[email protected]>
+
+        [GTK][CMake] Tarball is created with wrong tarball paths
+        https://bugs.webkit.org/show_bug.cgi?id=129496
+
+        Reviewed by Daniel Bates.
+
+        * gtk/make-dist.py:
+        (Manifest.__init__): I inadvertently inverted the logic of these checks when
+        landing the original patch with some suggestions from the reviewer. With the
+        checks corrected, the tarball path is constructed properly.
+
 2014-03-05  Jae Hyun Park  <[email protected]>
 
         Unreviewed. Update my email in contributors.json

Modified: trunk/Tools/gtk/make-dist.py (165173 => 165174)


--- trunk/Tools/gtk/make-dist.py	2014-03-06 06:46:23 UTC (rev 165173)
+++ trunk/Tools/gtk/make-dist.py	2014-03-06 06:46:53 UTC (rev 165174)
@@ -120,9 +120,9 @@
         self.build_root = os.path.abspath(build_root)
 
         # Normalize the tarball root so that it starts and ends with a slash.
-        if self.tarball_root.endswith('/'):
+        if not self.tarball_root.endswith('/'):
             self.tarball_root = self.tarball_root + '/'
-        if self.tarball_root.startswith('/'):
+        if not self.tarball_root.startswith('/'):
             self.tarball_root = '/' + self.tarball_root
 
         with open(manifest_filename, 'r') as file:
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to