Title: [165286] branches/safari-537.75-branch/Source/WebCore
Diff
Modified: branches/safari-537.75-branch/Source/WebCore/ChangeLog (165285 => 165286)
--- branches/safari-537.75-branch/Source/WebCore/ChangeLog 2014-03-07 21:33:44 UTC (rev 165285)
+++ branches/safari-537.75-branch/Source/WebCore/ChangeLog 2014-03-07 21:49:21 UTC (rev 165286)
@@ -1,3 +1,33 @@
+2014-03-07 Matthew Hanson <[email protected]>
+
+ Merge r165206.
+
+ 2014-03-05 Jon Honeycutt <[email protected]>
+
+ Invalid cast in WebCore::RenderLayer::FilterInfo::updateReferenceFilterClients()
+
+ <https://bugs.webkit.org/show_bug.cgi?id=121887>
+ <rdar://problem/15073043>
+
+ Clang appears to be optimizing out a branch in RenderObject::node()
+ when compiling RenderLayer::FilterInfo::updateReferenceFilterClients().
+ We'll work around this by factoring out the code in question into a
+ separate member function marked NEVER_INLINE.
+
+ No test possible due to <https://bugs.webkit.org/show_bug.cgi?id=129757>.
+
+ Reviewed by David Kilzer.
+
+ * rendering/RenderLayerFilterInfo.cpp:
+ (WebCore::RenderLayer::FilterInfo::layerElement):
+ Code moved from updateReferenceFilterClients(). Returns the Element*
+ for m_layer.
+ (WebCore::RenderLayer::FilterInfo::updateReferenceFilterClients):
+ Use layerElement().
+
+ * rendering/RenderLayerFilterInfo.h:
+ Declared layerElement().
+
2014-03-06 Matthew Hanson <[email protected]>
Merge r164249.
Modified: branches/safari-537.75-branch/Source/WebCore/rendering/RenderLayerFilterInfo.cpp (165285 => 165286)
--- branches/safari-537.75-branch/Source/WebCore/rendering/RenderLayerFilterInfo.cpp 2014-03-07 21:33:44 UTC (rev 165285)
+++ branches/safari-537.75-branch/Source/WebCore/rendering/RenderLayerFilterInfo.cpp 2014-03-07 21:49:21 UTC (rev 165286)
@@ -122,6 +122,12 @@
renderer->repaint();
}
+// FIXME: Remove this helper function when <rdar://problem/16230015> is fixed.
+NEVER_INLINE Node* RenderLayerFilterInfo::layerElement() const
+{
+ return m_layer->renderer()->node();
+}
+
void RenderLayerFilterInfo::updateReferenceFilterClients(const FilterOperations& operations)
{
removeReferenceFilterClients();
@@ -140,7 +146,7 @@
} else {
// Reference is internal; add layer as a client so we can trigger
// filter repaint on SVG attribute change.
- Element* filter = m_layer->renderer()->node()->document()->getElementById(referenceFilterOperation->fragment());
+ Element* filter = layerElement()->document()->getElementById(referenceFilterOperation->fragment());
if (!filter || !filter->renderer() || !filter->renderer()->isSVGResourceFilter())
continue;
filter->renderer()->toRenderSVGResourceContainer()->addClientRenderLayer(m_layer);
Modified: branches/safari-537.75-branch/Source/WebCore/rendering/RenderLayerFilterInfo.h (165285 => 165286)
--- branches/safari-537.75-branch/Source/WebCore/rendering/RenderLayerFilterInfo.h 2014-03-07 21:33:44 UTC (rev 165285)
+++ branches/safari-537.75-branch/Source/WebCore/rendering/RenderLayerFilterInfo.h 2014-03-07 21:49:21 UTC (rev 165286)
@@ -97,6 +97,8 @@
RenderLayerFilterInfo(RenderLayer*);
~RenderLayerFilterInfo();
+ Node* layerElement() const;
+
RenderLayer* m_layer;
RefPtr<FilterEffectRenderer> m_renderer;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
