Title: [165324] trunk/Source/WebCore
- Revision
- 165324
- Author
- mmaxfi...@apple.com
- Date
- 2014-03-07 21:25:07 -0800 (Fri, 07 Mar 2014)
Log Message
Comment in RenderStyle is no longer accurate
https://bugs.webkit.org/show_bug.cgi?id=129956
Reviewed by Simon Fraser.
RenderStyle::createStyleInheritingFromPseudoStyle was moved from RenderImage. Before it
was moved, there was an image-specific comment in the function. However, that comment
is both irrelevant to RenderStyle, and incorrect as the function is necessary for
RenderQuotes as well.
No new tests are necessary because there is no behavior change.
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::createStyleInheritingFromPseudoStyle):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (165323 => 165324)
--- trunk/Source/WebCore/ChangeLog 2014-03-08 05:10:30 UTC (rev 165323)
+++ trunk/Source/WebCore/ChangeLog 2014-03-08 05:25:07 UTC (rev 165324)
@@ -1,3 +1,20 @@
+2014-03-07 Myles C. Maxfield <mmaxfi...@apple.com>
+
+ Comment in RenderStyle is no longer accurate
+ https://bugs.webkit.org/show_bug.cgi?id=129956
+
+ Reviewed by Simon Fraser.
+
+ RenderStyle::createStyleInheritingFromPseudoStyle was moved from RenderImage. Before it
+ was moved, there was an image-specific comment in the function. However, that comment
+ is both irrelevant to RenderStyle, and incorrect as the function is necessary for
+ RenderQuotes as well.
+
+ No new tests are necessary because there is no behavior change.
+
+ * rendering/style/RenderStyle.cpp:
+ (WebCore::RenderStyle::createStyleInheritingFromPseudoStyle):
+
2014-03-07 Thiago de Barros Lacerda <thiago.lace...@openbossa.org>
[WebRTC] Throw SYNTAX_ERROR when maxRetransmits and maxRetransmitTime are both set in RTCDataChannelInit
Modified: trunk/Source/WebCore/rendering/style/RenderStyle.cpp (165323 => 165324)
--- trunk/Source/WebCore/rendering/style/RenderStyle.cpp 2014-03-08 05:10:30 UTC (rev 165323)
+++ trunk/Source/WebCore/rendering/style/RenderStyle.cpp 2014-03-08 05:25:07 UTC (rev 165324)
@@ -111,9 +111,6 @@
{
ASSERT(pseudoStyle.styleType() == BEFORE || pseudoStyle.styleType() == AFTER);
- // Images are special and must inherit the pseudoStyle so the width and height of
- // the pseudo element doesn't change the size of the image. In all other cases we
- // can just share the style.
auto style = RenderStyle::create();
style.get().inheritFrom(&pseudoStyle);
return style;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes