Title: [165481] trunk/Source/WebKit2
- Revision
- 165481
- Author
- [email protected]
- Date
- 2014-03-12 11:00:17 -0700 (Wed, 12 Mar 2014)
Log Message
BundlePageDiagnosticLoggingClient leaks every string passing through it.
<https://webkit.org/b/130140>
<rdar://problem/15416838>
Use toAPI() instead of toCopiedAPI() so the receiving end doesn't need
to worry about adopting the WKStringRef.
Reviewed by Anders Carlsson.
* WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.cpp:
(WebKit::InjectedBundlePageDiagnosticLoggingClient::logDiagnosticMessage):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (165480 => 165481)
--- trunk/Source/WebKit2/ChangeLog 2014-03-12 17:55:34 UTC (rev 165480)
+++ trunk/Source/WebKit2/ChangeLog 2014-03-12 18:00:17 UTC (rev 165481)
@@ -1,3 +1,17 @@
+2014-03-12 Andreas Kling <[email protected]>
+
+ BundlePageDiagnosticLoggingClient leaks every string passing through it.
+ <https://webkit.org/b/130140>
+ <rdar://problem/15416838>
+
+ Use toAPI() instead of toCopiedAPI() so the receiving end doesn't need
+ to worry about adopting the WKStringRef.
+
+ Reviewed by Anders Carlsson.
+
+ * WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.cpp:
+ (WebKit::InjectedBundlePageDiagnosticLoggingClient::logDiagnosticMessage):
+
2014-03-12 Tim Horton <[email protected]>
Hook up image controls for WebKit1
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.cpp (165480 => 165481)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.cpp 2014-03-12 17:55:34 UTC (rev 165480)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.cpp 2014-03-12 18:00:17 UTC (rev 165481)
@@ -35,7 +35,7 @@
{
if (!m_client.logDiagnosticMessage)
return;
- m_client.logDiagnosticMessage(toAPI(page), toCopiedAPI(message), toCopiedAPI(description), toCopiedAPI(success), m_client.base.clientInfo);
+ m_client.logDiagnosticMessage(toAPI(page), toAPI(message), toAPI(description), toAPI(success), m_client.base.clientInfo);
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes