Title: [165490] trunk/Source/_javascript_Core
- Revision
- 165490
- Author
- [email protected]
- Date
- 2014-03-12 11:29:00 -0700 (Wed, 12 Mar 2014)
Log Message
Remove HandleSet::m_nextToFinalize
https://bugs.webkit.org/show_bug.cgi?id=130109
Reviewed by Mark Lam.
This is a remnant of when HandleSet contained things that needed to be finalized.
* heap/HandleSet.cpp:
(JSC::HandleSet::HandleSet):
(JSC::HandleSet::writeBarrier):
* heap/HandleSet.h:
(JSC::HandleSet::allocate):
(JSC::HandleSet::deallocate):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (165489 => 165490)
--- trunk/Source/_javascript_Core/ChangeLog 2014-03-12 18:26:33 UTC (rev 165489)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-03-12 18:29:00 UTC (rev 165490)
@@ -1,5 +1,21 @@
2014-03-12 Mark Hahnenberg <[email protected]>
+ Remove HandleSet::m_nextToFinalize
+ https://bugs.webkit.org/show_bug.cgi?id=130109
+
+ Reviewed by Mark Lam.
+
+ This is a remnant of when HandleSet contained things that needed to be finalized.
+
+ * heap/HandleSet.cpp:
+ (JSC::HandleSet::HandleSet):
+ (JSC::HandleSet::writeBarrier):
+ * heap/HandleSet.h:
+ (JSC::HandleSet::allocate):
+ (JSC::HandleSet::deallocate):
+
+2014-03-12 Mark Hahnenberg <[email protected]>
+
Layout Test fast/workers/worker-gc.html is failing
https://bugs.webkit.org/show_bug.cgi?id=130135
Modified: trunk/Source/_javascript_Core/heap/HandleSet.cpp (165489 => 165490)
--- trunk/Source/_javascript_Core/heap/HandleSet.cpp 2014-03-12 18:26:33 UTC (rev 165489)
+++ trunk/Source/_javascript_Core/heap/HandleSet.cpp 2014-03-12 18:29:00 UTC (rev 165490)
@@ -37,7 +37,6 @@
HandleSet::HandleSet(VM* vm)
: m_vm(vm)
- , m_nextToFinalize(0)
{
grow();
}
@@ -73,10 +72,6 @@
void HandleSet::writeBarrier(HandleSlot slot, const JSValue& value)
{
- // Forbid assignment to handles during the finalization phase, since it would violate many GC invariants.
- // File a bug with stack trace if you hit this.
- RELEASE_ASSERT(!m_nextToFinalize);
-
if (!value == !*slot && slot->isCell() == value.isCell())
return;
Modified: trunk/Source/_javascript_Core/heap/HandleSet.h (165489 => 165490)
--- trunk/Source/_javascript_Core/heap/HandleSet.h 2014-03-12 18:26:33 UTC (rev 165489)
+++ trunk/Source/_javascript_Core/heap/HandleSet.h 2014-03-12 18:29:00 UTC (rev 165490)
@@ -100,7 +100,6 @@
SentinelLinkedList<Node> m_strongList;
SentinelLinkedList<Node> m_immediateList;
SinglyLinkedList<Node> m_freeList;
- Node* m_nextToFinalize;
};
inline HandleSet* HandleSet::heapFor(HandleSlot handle)
@@ -125,10 +124,6 @@
inline HandleSlot HandleSet::allocate()
{
- // Forbid assignment to handles during the finalization phase, since it would violate many GC invariants.
- // File a bug with stack trace if you hit this.
- RELEASE_ASSERT(!m_nextToFinalize);
-
if (m_freeList.isEmpty())
grow();
@@ -141,11 +136,6 @@
inline void HandleSet::deallocate(HandleSlot handle)
{
HandleSet::Node* node = toNode(handle);
- if (node == m_nextToFinalize) {
- ASSERT(m_nextToFinalize->next());
- m_nextToFinalize = m_nextToFinalize->next();
- }
-
SentinelLinkedList<HandleSet::Node>::remove(node);
m_freeList.push(node);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
