Title: [165732] trunk/Source/WebCore
- Revision
- 165732
- Author
- [email protected]
- Date
- 2014-03-17 07:59:03 -0700 (Mon, 17 Mar 2014)
Log Message
Explicitly include cstdio header for debug builds in InlineTextBox, RenderLayer, RenderObject
https://bugs.webkit.org/show_bug.cgi?id=130310
Reviewed by Darin Adler.
Building the GTK port with Clang through CMake falls into a configuration where
the cstdio header is not indirectly included in InlineTextBox, RenderLayer and
RenderObject source files. fprintf() is required for helper functions that print
out helpful debugging information in debug builds, so the cstdio header should
be included explicitly in that case.
* rendering/InlineTextBox.cpp:
* rendering/RenderLayer.cpp:
* rendering/RenderObject.cpp:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (165731 => 165732)
--- trunk/Source/WebCore/ChangeLog 2014-03-17 13:45:06 UTC (rev 165731)
+++ trunk/Source/WebCore/ChangeLog 2014-03-17 14:59:03 UTC (rev 165732)
@@ -1,3 +1,20 @@
+2014-03-17 Zan Dobersek <[email protected]>
+
+ Explicitly include cstdio header for debug builds in InlineTextBox, RenderLayer, RenderObject
+ https://bugs.webkit.org/show_bug.cgi?id=130310
+
+ Reviewed by Darin Adler.
+
+ Building the GTK port with Clang through CMake falls into a configuration where
+ the cstdio header is not indirectly included in InlineTextBox, RenderLayer and
+ RenderObject source files. fprintf() is required for helper functions that print
+ out helpful debugging information in debug builds, so the cstdio header should
+ be included explicitly in that case.
+
+ * rendering/InlineTextBox.cpp:
+ * rendering/RenderLayer.cpp:
+ * rendering/RenderObject.cpp:
+
2014-03-17 Carlos Garcia Campos <[email protected]>
[GTK] Cleanup WebKitDOMObject
Modified: trunk/Source/WebCore/rendering/InlineTextBox.cpp (165731 => 165732)
--- trunk/Source/WebCore/rendering/InlineTextBox.cpp 2014-03-17 13:45:06 UTC (rev 165731)
+++ trunk/Source/WebCore/rendering/InlineTextBox.cpp 2014-03-17 14:59:03 UTC (rev 165732)
@@ -53,6 +53,10 @@
#include "break_lines.h"
#include <wtf/text/CString.h>
+#ifndef NDEBUG
+#include <cstdio>
+#endif
+
namespace WebCore {
struct SameSizeAsInlineTextBox : public InlineBox {
Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (165731 => 165732)
--- trunk/Source/WebCore/rendering/RenderLayer.cpp 2014-03-17 13:45:06 UTC (rev 165731)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp 2014-03-17 14:59:03 UTC (rev 165732)
@@ -121,7 +121,11 @@
#include "RenderLayerFilterInfo.h"
#endif
+#ifndef NDEBUG
+#include <cstdio>
+#endif
+
#define MIN_INTERSECT_FOR_REVEAL 32
namespace WebCore {
Modified: trunk/Source/WebCore/rendering/RenderObject.cpp (165731 => 165732)
--- trunk/Source/WebCore/rendering/RenderObject.cpp 2014-03-17 13:45:06 UTC (rev 165731)
+++ trunk/Source/WebCore/rendering/RenderObject.cpp 2014-03-17 14:59:03 UTC (rev 165732)
@@ -69,6 +69,10 @@
#include "SelectionRect.h"
#endif
+#ifndef NDEBUG
+#include <cstdio>
+#endif
+
namespace WebCore {
using namespace HTMLNames;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
