Diff
Modified: trunk/Source/WebCore/ChangeLog (165756 => 165757)
--- trunk/Source/WebCore/ChangeLog 2014-03-17 21:11:30 UTC (rev 165756)
+++ trunk/Source/WebCore/ChangeLog 2014-03-17 21:24:42 UTC (rev 165757)
@@ -1,3 +1,35 @@
+2014-03-17 Andreas Kling <[email protected]>
+
+ Remove unnecessary JSC::Handle null checks in bindings code.
+ <https://webkit.org/b/130356>
+
+ Use Handle::slot() directly instead of going through Handle::get().
+ This avoids null checking the HandleSlot, which isn't necessary here
+ anyway, and the code already assumes it'll never be null.
+
+ Reviewed by Gavin Barraclough.
+
+ * bindings/js/JSCSSRuleListCustom.cpp:
+ (WebCore::JSCSSRuleListOwner::isReachableFromOpaqueRoots):
+ * bindings/js/JSCSSValueCustom.cpp:
+ (WebCore::JSCSSValueOwner::isReachableFromOpaqueRoots):
+ (WebCore::JSCSSValueOwner::finalize):
+ * bindings/js/JSMutationObserverCustom.cpp:
+ (WebCore::JSMutationObserverOwner::isReachableFromOpaqueRoots):
+ * bindings/js/JSNodeCustom.cpp:
+ (WebCore::JSNodeOwner::isReachableFromOpaqueRoots):
+ * bindings/js/JSNodeListCustom.cpp:
+ (WebCore::JSNodeListOwner::isReachableFromOpaqueRoots):
+ * bindings/js/JSTextTrackCueCustom.cpp:
+ (WebCore::JSTextTrackCueOwner::isReachableFromOpaqueRoots):
+ * bindings/js/WebCoreTypedArrayController.cpp:
+ (WebCore::WebCoreTypedArrayController::JSArrayBufferOwner::isReachableFromOpaqueRoots):
+ (WebCore::WebCoreTypedArrayController::JSArrayBufferOwner::finalize):
+ * bindings/scripts/CodeGeneratorJS.pm:
+ (GenerateImplementation):
+ * bridge/runtime_root.cpp:
+ (JSC::Bindings::RootObject::finalize):
+
2014-03-17 Krzysztof Czech <[email protected]>
AX: Reducing some code by using helper function ariaElementsFromAttribute
Modified: trunk/Source/WebCore/bindings/js/JSCSSRuleListCustom.cpp (165756 => 165757)
--- trunk/Source/WebCore/bindings/js/JSCSSRuleListCustom.cpp 2014-03-17 21:11:30 UTC (rev 165756)
+++ trunk/Source/WebCore/bindings/js/JSCSSRuleListCustom.cpp 2014-03-17 21:24:42 UTC (rev 165757)
@@ -38,7 +38,7 @@
bool JSCSSRuleListOwner::isReachableFromOpaqueRoots(JSC::Handle<JSC::Unknown> handle, void*, SlotVisitor& visitor)
{
- JSCSSRuleList* jsCSSRuleList = jsCast<JSCSSRuleList*>(handle.get().asCell());
+ JSCSSRuleList* jsCSSRuleList = jsCast<JSCSSRuleList*>(handle.slot()->asCell());
if (!jsCSSRuleList->hasCustomProperties())
return false;
if (CSSStyleSheet* styleSheet = jsCSSRuleList->impl().styleSheet())
Modified: trunk/Source/WebCore/bindings/js/JSCSSValueCustom.cpp (165756 => 165757)
--- trunk/Source/WebCore/bindings/js/JSCSSValueCustom.cpp 2014-03-17 21:11:30 UTC (rev 165756)
+++ trunk/Source/WebCore/bindings/js/JSCSSValueCustom.cpp 2014-03-17 21:24:42 UTC (rev 165757)
@@ -49,7 +49,7 @@
bool JSCSSValueOwner::isReachableFromOpaqueRoots(JSC::Handle<JSC::Unknown> handle, void* context, SlotVisitor& visitor)
{
- JSCSSValue* jsCSSValue = jsCast<JSCSSValue*>(handle.get().asCell());
+ JSCSSValue* jsCSSValue = jsCast<JSCSSValue*>(handle.slot()->asCell());
if (!jsCSSValue->hasCustomProperties())
return false;
DOMWrapperWorld* world = static_cast<DOMWrapperWorld*>(context);
@@ -61,7 +61,7 @@
void JSCSSValueOwner::finalize(JSC::Handle<JSC::Unknown> handle, void* context)
{
- JSCSSValue* jsCSSValue = jsCast<JSCSSValue*>(handle.get().asCell());
+ JSCSSValue* jsCSSValue = jsCast<JSCSSValue*>(handle.slot()->asCell());
DOMWrapperWorld& world = *static_cast<DOMWrapperWorld*>(context);
world.m_cssValueRoots.remove(&jsCSSValue->impl());
uncacheWrapper(world, &jsCSSValue->impl(), jsCSSValue);
Modified: trunk/Source/WebCore/bindings/js/JSMutationObserverCustom.cpp (165756 => 165757)
--- trunk/Source/WebCore/bindings/js/JSMutationObserverCustom.cpp 2014-03-17 21:11:30 UTC (rev 165756)
+++ trunk/Source/WebCore/bindings/js/JSMutationObserverCustom.cpp 2014-03-17 21:24:42 UTC (rev 165757)
@@ -63,7 +63,7 @@
bool JSMutationObserverOwner::isReachableFromOpaqueRoots(JSC::Handle<JSC::Unknown> handle, void*, SlotVisitor& visitor)
{
- MutationObserver& observer = jsCast<JSMutationObserver*>(handle.get().asCell())->impl();
+ MutationObserver& observer = jsCast<JSMutationObserver*>(handle.slot()->asCell())->impl();
auto observedNodes = observer.getObservedNodes();
for (auto it = observedNodes.begin(), end = observedNodes.end(); it != end; ++it) {
if (visitor.containsOpaqueRoot(root(*it)))
Modified: trunk/Source/WebCore/bindings/js/JSNodeCustom.cpp (165756 => 165757)
--- trunk/Source/WebCore/bindings/js/JSNodeCustom.cpp 2014-03-17 21:11:30 UTC (rev 165756)
+++ trunk/Source/WebCore/bindings/js/JSNodeCustom.cpp 2014-03-17 21:24:42 UTC (rev 165757)
@@ -128,7 +128,7 @@
bool JSNodeOwner::isReachableFromOpaqueRoots(JSC::Handle<JSC::Unknown> handle, void*, SlotVisitor& visitor)
{
- JSNode* jsNode = jsCast<JSNode*>(handle.get().asCell());
+ JSNode* jsNode = jsCast<JSNode*>(handle.slot()->asCell());
return isReachableFromDOM(jsNode, &jsNode->impl(), visitor);
}
Modified: trunk/Source/WebCore/bindings/js/JSNodeListCustom.cpp (165756 => 165757)
--- trunk/Source/WebCore/bindings/js/JSNodeListCustom.cpp 2014-03-17 21:11:30 UTC (rev 165756)
+++ trunk/Source/WebCore/bindings/js/JSNodeListCustom.cpp 2014-03-17 21:24:42 UTC (rev 165757)
@@ -39,7 +39,7 @@
bool JSNodeListOwner::isReachableFromOpaqueRoots(JSC::Handle<JSC::Unknown> handle, void*, SlotVisitor& visitor)
{
- JSNodeList* jsNodeList = jsCast<JSNodeList*>(handle.get().asCell());
+ JSNodeList* jsNodeList = jsCast<JSNodeList*>(handle.slot()->asCell());
if (!jsNodeList->hasCustomProperties())
return false;
if (jsNodeList->impl().isLiveNodeList())
Modified: trunk/Source/WebCore/bindings/js/JSTextTrackCueCustom.cpp (165756 => 165757)
--- trunk/Source/WebCore/bindings/js/JSTextTrackCueCustom.cpp 2014-03-17 21:11:30 UTC (rev 165756)
+++ trunk/Source/WebCore/bindings/js/JSTextTrackCueCustom.cpp 2014-03-17 21:24:42 UTC (rev 165757)
@@ -39,7 +39,7 @@
bool JSTextTrackCueOwner::isReachableFromOpaqueRoots(JSC::Handle<JSC::Unknown> handle, void*, SlotVisitor& visitor)
{
- JSTextTrackCue* jsTextTrackCue = jsCast<JSTextTrackCue*>(handle.get().asCell());
+ JSTextTrackCue* jsTextTrackCue = jsCast<JSTextTrackCue*>(handle.slot()->asCell());
TextTrackCue& textTrackCue = jsTextTrackCue->impl();
// If the cue is firing event listeners, its wrapper is reachable because
Modified: trunk/Source/WebCore/bindings/js/WebCoreTypedArrayController.cpp (165756 => 165757)
--- trunk/Source/WebCore/bindings/js/WebCoreTypedArrayController.cpp 2014-03-17 21:11:30 UTC (rev 165756)
+++ trunk/Source/WebCore/bindings/js/WebCoreTypedArrayController.cpp 2014-03-17 21:24:42 UTC (rev 165757)
@@ -49,7 +49,7 @@
bool WebCoreTypedArrayController::JSArrayBufferOwner::isReachableFromOpaqueRoots(JSC::Handle<JSC::Unknown> handle, void*, JSC::SlotVisitor& visitor)
{
- auto& wrapper = *JSC::jsCast<JSC::JSArrayBuffer*>(handle.get().asCell());
+ auto& wrapper = *JSC::jsCast<JSC::JSArrayBuffer*>(handle.slot()->asCell());
if (!wrapper.hasCustomProperties())
return false;
return visitor.containsOpaqueRoot(wrapper.impl());
@@ -57,7 +57,7 @@
void WebCoreTypedArrayController::JSArrayBufferOwner::finalize(JSC::Handle<JSC::Unknown> handle, void* context)
{
- auto& wrapper = *static_cast<JSC::JSArrayBuffer*>(handle.get().asCell());
+ auto& wrapper = *static_cast<JSC::JSArrayBuffer*>(handle.slot()->asCell());
auto& buffer = *wrapper.impl();
uncacheWrapper(*static_cast<DOMWrapperWorld*>(context), &buffer, &wrapper);
buffer.deref();
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (165756 => 165757)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2014-03-17 21:11:30 UTC (rev 165756)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2014-03-17 21:24:42 UTC (rev 165757)
@@ -2921,14 +2921,14 @@
# check below the isObservable check.
my $emittedJSCast = 0;
if ($codeGenerator->InheritsExtendedAttribute($interface, "ActiveDOMObject")) {
- push(@implContent, " JS${interfaceName}* js${interfaceName} = jsCast<JS${interfaceName}*>(handle.get().asCell());\n");
+ push(@implContent, " JS${interfaceName}* js${interfaceName} = jsCast<JS${interfaceName}*>(handle.slot()->asCell());\n");
$emittedJSCast = 1;
push(@implContent, " if (js${interfaceName}->impl().hasPendingActivity())\n");
push(@implContent, " return true;\n");
}
if ($codeGenerator->InheritsExtendedAttribute($interface, "EventTarget")) {
if (!$emittedJSCast) {
- push(@implContent, " JS${interfaceName}* js${interfaceName} = jsCast<JS${interfaceName}*>(handle.get().asCell());\n");
+ push(@implContent, " JS${interfaceName}* js${interfaceName} = jsCast<JS${interfaceName}*>(handle.slot()->asCell());\n");
$emittedJSCast = 1;
}
push(@implContent, " if (js${interfaceName}->impl().isFiringEventListeners())\n");
@@ -2936,7 +2936,7 @@
}
if ($codeGenerator->InheritsInterface($interface, "Node")) {
if (!$emittedJSCast) {
- push(@implContent, " JS${interfaceName}* js${interfaceName} = jsCast<JS${interfaceName}*>(handle.get().asCell());\n");
+ push(@implContent, " JS${interfaceName}* js${interfaceName} = jsCast<JS${interfaceName}*>(handle.slot()->asCell());\n");
$emittedJSCast = 1;
}
push(@implContent, " if (JSNodeOwner::isReachableFromOpaqueRoots(handle, 0, visitor))\n");
@@ -2944,7 +2944,7 @@
}
if (GetGenerateIsReachable($interface)) {
if (!$emittedJSCast) {
- push(@implContent, " JS${interfaceName}* js${interfaceName} = jsCast<JS${interfaceName}*>(handle.get().asCell());\n");
+ push(@implContent, " JS${interfaceName}* js${interfaceName} = jsCast<JS${interfaceName}*>(handle.slot()->asCell());\n");
$emittedJSCast = 1;
}
push(@implContent, " if (!isObservable(js${interfaceName}))\n");
@@ -3001,7 +3001,7 @@
$codeGenerator->InheritsExtendedAttribute($interface, "ActiveDOMObject"))) {
push(@implContent, "void JS${interfaceName}Owner::finalize(JSC::Handle<JSC::Unknown> handle, void* context)\n");
push(@implContent, "{\n");
- push(@implContent, " JS${interfaceName}* js${interfaceName} = jsCast<JS${interfaceName}*>(handle.get().asCell());\n");
+ push(@implContent, " JS${interfaceName}* js${interfaceName} = jsCast<JS${interfaceName}*>(handle.slot()->asCell());\n");
push(@implContent, " DOMWrapperWorld& world = *static_cast<DOMWrapperWorld*>(context);\n");
push(@implContent, " uncacheWrapper(world, &js${interfaceName}->impl(), js${interfaceName});\n");
push(@implContent, " js${interfaceName}->releaseImpl();\n");
Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.cpp (165756 => 165757)
--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.cpp 2014-03-17 21:11:30 UTC (rev 165756)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.cpp 2014-03-17 21:24:42 UTC (rev 165757)
@@ -233,7 +233,7 @@
void JSTestActiveDOMObjectOwner::finalize(JSC::Handle<JSC::Unknown> handle, void* context)
{
- JSTestActiveDOMObject* jsTestActiveDOMObject = jsCast<JSTestActiveDOMObject*>(handle.get().asCell());
+ JSTestActiveDOMObject* jsTestActiveDOMObject = jsCast<JSTestActiveDOMObject*>(handle.slot()->asCell());
DOMWrapperWorld& world = *static_cast<DOMWrapperWorld*>(context);
uncacheWrapper(world, &jsTestActiveDOMObject->impl(), jsTestActiveDOMObject);
jsTestActiveDOMObject->releaseImpl();
Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp (165756 => 165757)
--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp 2014-03-17 21:11:30 UTC (rev 165756)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp 2014-03-17 21:24:42 UTC (rev 165757)
@@ -200,7 +200,7 @@
void JSTestCustomNamedGetterOwner::finalize(JSC::Handle<JSC::Unknown> handle, void* context)
{
- JSTestCustomNamedGetter* jsTestCustomNamedGetter = jsCast<JSTestCustomNamedGetter*>(handle.get().asCell());
+ JSTestCustomNamedGetter* jsTestCustomNamedGetter = jsCast<JSTestCustomNamedGetter*>(handle.slot()->asCell());
DOMWrapperWorld& world = *static_cast<DOMWrapperWorld*>(context);
uncacheWrapper(world, &jsTestCustomNamedGetter->impl(), jsTestCustomNamedGetter);
jsTestCustomNamedGetter->releaseImpl();
Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp (165756 => 165757)
--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp 2014-03-17 21:11:30 UTC (rev 165756)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp 2014-03-17 21:24:42 UTC (rev 165757)
@@ -245,7 +245,7 @@
void JSTestEventConstructorOwner::finalize(JSC::Handle<JSC::Unknown> handle, void* context)
{
- JSTestEventConstructor* jsTestEventConstructor = jsCast<JSTestEventConstructor*>(handle.get().asCell());
+ JSTestEventConstructor* jsTestEventConstructor = jsCast<JSTestEventConstructor*>(handle.slot()->asCell());
DOMWrapperWorld& world = *static_cast<DOMWrapperWorld*>(context);
uncacheWrapper(world, &jsTestEventConstructor->impl(), jsTestEventConstructor);
jsTestEventConstructor->releaseImpl();
Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.cpp (165756 => 165757)
--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.cpp 2014-03-17 21:11:30 UTC (rev 165756)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.cpp 2014-03-17 21:24:42 UTC (rev 165757)
@@ -305,7 +305,7 @@
bool JSTestEventTargetOwner::isReachableFromOpaqueRoots(JSC::Handle<JSC::Unknown> handle, void*, SlotVisitor& visitor)
{
- JSTestEventTarget* jsTestEventTarget = jsCast<JSTestEventTarget*>(handle.get().asCell());
+ JSTestEventTarget* jsTestEventTarget = jsCast<JSTestEventTarget*>(handle.slot()->asCell());
if (jsTestEventTarget->impl().isFiringEventListeners())
return true;
UNUSED_PARAM(visitor);
@@ -314,7 +314,7 @@
void JSTestEventTargetOwner::finalize(JSC::Handle<JSC::Unknown> handle, void* context)
{
- JSTestEventTarget* jsTestEventTarget = jsCast<JSTestEventTarget*>(handle.get().asCell());
+ JSTestEventTarget* jsTestEventTarget = jsCast<JSTestEventTarget*>(handle.slot()->asCell());
DOMWrapperWorld& world = *static_cast<DOMWrapperWorld*>(context);
uncacheWrapper(world, &jsTestEventTarget->impl(), jsTestEventTarget);
jsTestEventTarget->releaseImpl();
Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestException.cpp (165756 => 165757)
--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestException.cpp 2014-03-17 21:11:30 UTC (rev 165756)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestException.cpp 2014-03-17 21:24:42 UTC (rev 165757)
@@ -185,7 +185,7 @@
void JSTestExceptionOwner::finalize(JSC::Handle<JSC::Unknown> handle, void* context)
{
- JSTestException* jsTestException = jsCast<JSTestException*>(handle.get().asCell());
+ JSTestException* jsTestException = jsCast<JSTestException*>(handle.slot()->asCell());
DOMWrapperWorld& world = *static_cast<DOMWrapperWorld*>(context);
uncacheWrapper(world, &jsTestException->impl(), jsTestException);
jsTestException->releaseImpl();
Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp (165756 => 165757)
--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp 2014-03-17 21:11:30 UTC (rev 165756)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp 2014-03-17 21:24:42 UTC (rev 165757)
@@ -149,7 +149,7 @@
bool JSTestGenerateIsReachableOwner::isReachableFromOpaqueRoots(JSC::Handle<JSC::Unknown> handle, void*, SlotVisitor& visitor)
{
- JSTestGenerateIsReachable* jsTestGenerateIsReachable = jsCast<JSTestGenerateIsReachable*>(handle.get().asCell());
+ JSTestGenerateIsReachable* jsTestGenerateIsReachable = jsCast<JSTestGenerateIsReachable*>(handle.slot()->asCell());
if (!isObservable(jsTestGenerateIsReachable))
return false;
TestGenerateIsReachable* root = &jsTestGenerateIsReachable->impl();
@@ -158,7 +158,7 @@
void JSTestGenerateIsReachableOwner::finalize(JSC::Handle<JSC::Unknown> handle, void* context)
{
- JSTestGenerateIsReachable* jsTestGenerateIsReachable = jsCast<JSTestGenerateIsReachable*>(handle.get().asCell());
+ JSTestGenerateIsReachable* jsTestGenerateIsReachable = jsCast<JSTestGenerateIsReachable*>(handle.slot()->asCell());
DOMWrapperWorld& world = *static_cast<DOMWrapperWorld*>(context);
uncacheWrapper(world, &jsTestGenerateIsReachable->impl(), jsTestGenerateIsReachable);
jsTestGenerateIsReachable->releaseImpl();
Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp (165756 => 165757)
--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp 2014-03-17 21:11:30 UTC (rev 165756)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp 2014-03-17 21:24:42 UTC (rev 165757)
@@ -962,7 +962,7 @@
#endif
bool JSTestInterfaceOwner::isReachableFromOpaqueRoots(JSC::Handle<JSC::Unknown> handle, void*, SlotVisitor& visitor)
{
- JSTestInterface* jsTestInterface = jsCast<JSTestInterface*>(handle.get().asCell());
+ JSTestInterface* jsTestInterface = jsCast<JSTestInterface*>(handle.slot()->asCell());
if (jsTestInterface->impl().hasPendingActivity())
return true;
UNUSED_PARAM(visitor);
@@ -971,7 +971,7 @@
void JSTestInterfaceOwner::finalize(JSC::Handle<JSC::Unknown> handle, void* context)
{
- JSTestInterface* jsTestInterface = jsCast<JSTestInterface*>(handle.get().asCell());
+ JSTestInterface* jsTestInterface = jsCast<JSTestInterface*>(handle.slot()->asCell());
DOMWrapperWorld& world = *static_cast<DOMWrapperWorld*>(context);
uncacheWrapper(world, &jsTestInterface->impl(), jsTestInterface);
jsTestInterface->releaseImpl();
Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp (165756 => 165757)
--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp 2014-03-17 21:11:30 UTC (rev 165756)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp 2014-03-17 21:24:42 UTC (rev 165757)
@@ -173,7 +173,7 @@
void JSTestMediaQueryListListenerOwner::finalize(JSC::Handle<JSC::Unknown> handle, void* context)
{
- JSTestMediaQueryListListener* jsTestMediaQueryListListener = jsCast<JSTestMediaQueryListListener*>(handle.get().asCell());
+ JSTestMediaQueryListListener* jsTestMediaQueryListListener = jsCast<JSTestMediaQueryListListener*>(handle.slot()->asCell());
DOMWrapperWorld& world = *static_cast<DOMWrapperWorld*>(context);
uncacheWrapper(world, &jsTestMediaQueryListListener->impl(), jsTestMediaQueryListListener);
jsTestMediaQueryListListener->releaseImpl();
Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedConstructor.cpp (165756 => 165757)
--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedConstructor.cpp 2014-03-17 21:11:30 UTC (rev 165756)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedConstructor.cpp 2014-03-17 21:24:42 UTC (rev 165757)
@@ -194,7 +194,7 @@
bool JSTestNamedConstructorOwner::isReachableFromOpaqueRoots(JSC::Handle<JSC::Unknown> handle, void*, SlotVisitor& visitor)
{
- JSTestNamedConstructor* jsTestNamedConstructor = jsCast<JSTestNamedConstructor*>(handle.get().asCell());
+ JSTestNamedConstructor* jsTestNamedConstructor = jsCast<JSTestNamedConstructor*>(handle.slot()->asCell());
if (jsTestNamedConstructor->impl().hasPendingActivity())
return true;
UNUSED_PARAM(visitor);
@@ -203,7 +203,7 @@
void JSTestNamedConstructorOwner::finalize(JSC::Handle<JSC::Unknown> handle, void* context)
{
- JSTestNamedConstructor* jsTestNamedConstructor = jsCast<JSTestNamedConstructor*>(handle.get().asCell());
+ JSTestNamedConstructor* jsTestNamedConstructor = jsCast<JSTestNamedConstructor*>(handle.slot()->asCell());
DOMWrapperWorld& world = *static_cast<DOMWrapperWorld*>(context);
uncacheWrapper(world, &jsTestNamedConstructor->impl(), jsTestNamedConstructor);
jsTestNamedConstructor->releaseImpl();
Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp (165756 => 165757)
--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp 2014-03-17 21:11:30 UTC (rev 165756)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp 2014-03-17 21:24:42 UTC (rev 165757)
@@ -4779,7 +4779,7 @@
void JSTestObjOwner::finalize(JSC::Handle<JSC::Unknown> handle, void* context)
{
- JSTestObj* jsTestObj = jsCast<JSTestObj*>(handle.get().asCell());
+ JSTestObj* jsTestObj = jsCast<JSTestObj*>(handle.slot()->asCell());
DOMWrapperWorld& world = *static_cast<DOMWrapperWorld*>(context);
uncacheWrapper(world, &jsTestObj->impl(), jsTestObj);
jsTestObj->releaseImpl();
Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp (165756 => 165757)
--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp 2014-03-17 21:11:30 UTC (rev 165756)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp 2014-03-17 21:24:42 UTC (rev 165757)
@@ -224,7 +224,7 @@
void JSTestOverloadedConstructorsOwner::finalize(JSC::Handle<JSC::Unknown> handle, void* context)
{
- JSTestOverloadedConstructors* jsTestOverloadedConstructors = jsCast<JSTestOverloadedConstructors*>(handle.get().asCell());
+ JSTestOverloadedConstructors* jsTestOverloadedConstructors = jsCast<JSTestOverloadedConstructors*>(handle.slot()->asCell());
DOMWrapperWorld& world = *static_cast<DOMWrapperWorld*>(context);
uncacheWrapper(world, &jsTestOverloadedConstructors->impl(), jsTestOverloadedConstructors);
jsTestOverloadedConstructors->releaseImpl();
Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp (165756 => 165757)
--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp 2014-03-17 21:11:30 UTC (rev 165756)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp 2014-03-17 21:24:42 UTC (rev 165757)
@@ -323,7 +323,7 @@
void JSTestSerializedScriptValueInterfaceOwner::finalize(JSC::Handle<JSC::Unknown> handle, void* context)
{
- JSTestSerializedScriptValueInterface* jsTestSerializedScriptValueInterface = jsCast<JSTestSerializedScriptValueInterface*>(handle.get().asCell());
+ JSTestSerializedScriptValueInterface* jsTestSerializedScriptValueInterface = jsCast<JSTestSerializedScriptValueInterface*>(handle.slot()->asCell());
DOMWrapperWorld& world = *static_cast<DOMWrapperWorld*>(context);
uncacheWrapper(world, &jsTestSerializedScriptValueInterface->impl(), jsTestSerializedScriptValueInterface);
jsTestSerializedScriptValueInterface->releaseImpl();
Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp (165756 => 165757)
--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp 2014-03-17 21:11:30 UTC (rev 165756)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp 2014-03-17 21:24:42 UTC (rev 165757)
@@ -735,7 +735,7 @@
void JSTestTypedefsOwner::finalize(JSC::Handle<JSC::Unknown> handle, void* context)
{
- JSTestTypedefs* jsTestTypedefs = jsCast<JSTestTypedefs*>(handle.get().asCell());
+ JSTestTypedefs* jsTestTypedefs = jsCast<JSTestTypedefs*>(handle.slot()->asCell());
DOMWrapperWorld& world = *static_cast<DOMWrapperWorld*>(context);
uncacheWrapper(world, &jsTestTypedefs->impl(), jsTestTypedefs);
jsTestTypedefs->releaseImpl();
Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSattribute.cpp (165756 => 165757)
--- trunk/Source/WebCore/bindings/scripts/test/JS/JSattribute.cpp 2014-03-17 21:11:30 UTC (rev 165756)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSattribute.cpp 2014-03-17 21:24:42 UTC (rev 165757)
@@ -174,7 +174,7 @@
void JSattributeOwner::finalize(JSC::Handle<JSC::Unknown> handle, void* context)
{
- JSattribute* jsattribute = jsCast<JSattribute*>(handle.get().asCell());
+ JSattribute* jsattribute = jsCast<JSattribute*>(handle.slot()->asCell());
DOMWrapperWorld& world = *static_cast<DOMWrapperWorld*>(context);
uncacheWrapper(world, &jsattribute->impl(), jsattribute);
jsattribute->releaseImpl();
Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSreadonly.cpp (165756 => 165757)
--- trunk/Source/WebCore/bindings/scripts/test/JS/JSreadonly.cpp 2014-03-17 21:11:30 UTC (rev 165756)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSreadonly.cpp 2014-03-17 21:24:42 UTC (rev 165757)
@@ -149,7 +149,7 @@
void JSreadonlyOwner::finalize(JSC::Handle<JSC::Unknown> handle, void* context)
{
- JSreadonly* jsreadonly = jsCast<JSreadonly*>(handle.get().asCell());
+ JSreadonly* jsreadonly = jsCast<JSreadonly*>(handle.slot()->asCell());
DOMWrapperWorld& world = *static_cast<DOMWrapperWorld*>(context);
uncacheWrapper(world, &jsreadonly->impl(), jsreadonly);
jsreadonly->releaseImpl();
Modified: trunk/Source/WebCore/bridge/runtime_root.cpp (165756 => 165757)
--- trunk/Source/WebCore/bridge/runtime_root.cpp 2014-03-17 21:11:30 UTC (rev 165756)
+++ trunk/Source/WebCore/bridge/runtime_root.cpp 2014-03-17 21:24:42 UTC (rev 165757)
@@ -200,7 +200,7 @@
void RootObject::finalize(JSC::Handle<JSC::Unknown> handle, void*)
{
- RuntimeObject* object = static_cast<RuntimeObject*>(handle.get().asCell());
+ RuntimeObject* object = static_cast<RuntimeObject*>(handle.slot()->asCell());
Ref<RootObject> protect(*this);
object->invalidate();
