Diff
Modified: trunk/Source/WebKit2/ChangeLog (165793 => 165794)
--- trunk/Source/WebKit2/ChangeLog 2014-03-18 03:16:43 UTC (rev 165793)
+++ trunk/Source/WebKit2/ChangeLog 2014-03-18 03:17:44 UTC (rev 165794)
@@ -1,3 +1,37 @@
+2014-03-17 Thiago de Barros Lacerda <[email protected]>
+
+ [WK2] Getting rid of compilation warnings
+ https://bugs.webkit.org/show_bug.cgi?id=130348
+
+ Reviewed by Benjamin Poulain.
+
+ * UIProcess/API/APIHistoryClient.h:
+ (API::HistoryClient::didPerformClientRedirect):
+ (API::HistoryClient::didPerformServerRedirect):
+ (API::HistoryClient::didUpdateHistoryTitle):
+ * UIProcess/API/APILoaderClient.h:
+ (API::LoaderClient::didStartProvisionalLoadForFrame):
+ (API::LoaderClient::didReceiveServerRedirectForProvisionalLoadForFrame):
+ (API::LoaderClient::didFailProvisionalLoadWithErrorForFrame):
+ (API::LoaderClient::didCommitLoadForFrame):
+ (API::LoaderClient::didFinishLoadForFrame):
+ (API::LoaderClient::didFailLoadWithErrorForFrame):
+ (API::LoaderClient::didChangeBackForwardList):
+ * UIProcess/API/APIPolicyClient.h:
+ (API::PolicyClient::decidePolicyForNavigationAction):
+ (API::PolicyClient::decidePolicyForNewWindowAction):
+ (API::PolicyClient::decidePolicyForResponse):
+ (API::PolicyClient::unableToImplementPolicy):
+ * UIProcess/API/APIUIClient.h:
+ (API::UIClient::exceededDatabaseQuota):
+ (API::UIClient::saveDataToFileInDownloadsFolder):
+ * UIProcess/API/C/WKPage.cpp:
+ (WKPageSetPageLoaderClient):
+ * UIProcess/APISession.cpp:
+ (API::generateID):
+ * WebProcess/Plugins/PluginView.cpp:
+ (WebKit::PluginView::viewStateDidChange):
+
2014-03-17 Anders Carlsson <[email protected]>
Update the bundle parameters dictionary and send out KVO notifications
Modified: trunk/Source/WebKit2/UIProcess/API/APIHistoryClient.h (165793 => 165794)
--- trunk/Source/WebKit2/UIProcess/API/APIHistoryClient.h 2014-03-18 03:16:43 UTC (rev 165793)
+++ trunk/Source/WebKit2/UIProcess/API/APIHistoryClient.h 2014-03-18 03:17:44 UTC (rev 165794)
@@ -42,9 +42,21 @@
virtual ~HistoryClient() { }
virtual void didNavigateWithNavigationData(WebKit::WebContext*, WebKit::WebPageProxy*, const WebKit::WebNavigationDataStore&, WebKit::WebFrameProxy*) { }
- virtual void didPerformClientRedirect(WebKit::WebContext*, WebKit::WebPageProxy*, const WTF::String& sourceURL, const WTF::String& destinationURL, WebKit::WebFrameProxy*) { }
- virtual void didPerformServerRedirect(WebKit::WebContext*, WebKit::WebPageProxy*, const WTF::String& sourceURL, const WTF::String& destinationURL, WebKit::WebFrameProxy*) { }
- virtual void didUpdateHistoryTitle(WebKit::WebContext*, WebKit::WebPageProxy*, const WTF::String& title, const WTF::String& url, WebKit::WebFrameProxy*) { }
+ virtual void didPerformClientRedirect(WebKit::WebContext*, WebKit::WebPageProxy*, const WTF::String& sourceURL, const WTF::String& destinationURL, WebKit::WebFrameProxy*)
+ {
+ UNUSED_PARAM(sourceURL);
+ UNUSED_PARAM(destinationURL);
+ }
+ virtual void didPerformServerRedirect(WebKit::WebContext*, WebKit::WebPageProxy*, const WTF::String& sourceURL, const WTF::String& destinationURL, WebKit::WebFrameProxy*)
+ {
+ UNUSED_PARAM(sourceURL);
+ UNUSED_PARAM(destinationURL);
+ }
+ virtual void didUpdateHistoryTitle(WebKit::WebContext*, WebKit::WebPageProxy*, const WTF::String& title, const WTF::String& url, WebKit::WebFrameProxy*)
+ {
+ UNUSED_PARAM(title);
+ UNUSED_PARAM(url);
+ }
virtual void populateVisitedLinks(WebKit::WebContext*) { }
virtual bool shouldTrackVisitedLinks() const { return false; }
};
Modified: trunk/Source/WebKit2/UIProcess/API/APILoaderClient.h (165793 => 165794)
--- trunk/Source/WebKit2/UIProcess/API/APILoaderClient.h 2014-03-18 03:16:43 UTC (rev 165793)
+++ trunk/Source/WebKit2/UIProcess/API/APILoaderClient.h 2014-03-18 03:17:44 UTC (rev 165794)
@@ -53,13 +53,13 @@
public:
virtual ~LoaderClient() { }
- virtual void didStartProvisionalLoadForFrame(WebKit::WebPageProxy*, WebKit::WebFrameProxy*, uint64_t navigationID, API::Object*) { }
- virtual void didReceiveServerRedirectForProvisionalLoadForFrame(WebKit::WebPageProxy*, WebKit::WebFrameProxy*, uint64_t navigationID, API::Object*) { }
- virtual void didFailProvisionalLoadWithErrorForFrame(WebKit::WebPageProxy*, WebKit::WebFrameProxy*, uint64_t navigationID, const WebCore::ResourceError&, API::Object*) { }
- virtual void didCommitLoadForFrame(WebKit::WebPageProxy*, WebKit::WebFrameProxy*, uint64_t navigationID, API::Object*) { }
+ virtual void didStartProvisionalLoadForFrame(WebKit::WebPageProxy*, WebKit::WebFrameProxy*, uint64_t navigationID, API::Object*) { UNUSED_PARAM(navigationID); }
+ virtual void didReceiveServerRedirectForProvisionalLoadForFrame(WebKit::WebPageProxy*, WebKit::WebFrameProxy*, uint64_t navigationID, API::Object*) { UNUSED_PARAM(navigationID); }
+ virtual void didFailProvisionalLoadWithErrorForFrame(WebKit::WebPageProxy*, WebKit::WebFrameProxy*, uint64_t navigationID, const WebCore::ResourceError&, API::Object*) { UNUSED_PARAM(navigationID); }
+ virtual void didCommitLoadForFrame(WebKit::WebPageProxy*, WebKit::WebFrameProxy*, uint64_t navigationID, API::Object*) { UNUSED_PARAM(navigationID); }
virtual void didFinishDocumentLoadForFrame(WebKit::WebPageProxy*, WebKit::WebFrameProxy*, API::Object*) { }
- virtual void didFinishLoadForFrame(WebKit::WebPageProxy*, WebKit::WebFrameProxy*, uint64_t navigationID, API::Object*) { }
- virtual void didFailLoadWithErrorForFrame(WebKit::WebPageProxy*, WebKit::WebFrameProxy*, uint64_t navigationID, const WebCore::ResourceError&, API::Object*) { }
+ virtual void didFinishLoadForFrame(WebKit::WebPageProxy*, WebKit::WebFrameProxy*, uint64_t navigationID, API::Object*) { UNUSED_PARAM(navigationID); }
+ virtual void didFailLoadWithErrorForFrame(WebKit::WebPageProxy*, WebKit::WebFrameProxy*, uint64_t navigationID, const WebCore::ResourceError&, API::Object*) { UNUSED_PARAM(navigationID); }
virtual void didSameDocumentNavigationForFrame(WebKit::WebPageProxy*, WebKit::WebFrameProxy*, WebKit::SameDocumentNavigationType, API::Object*) { }
virtual void didReceiveTitleForFrame(WebKit::WebPageProxy*, const WTF::String&, WebKit::WebFrameProxy*, API::Object*) { }
virtual void didFirstLayoutForFrame(WebKit::WebPageProxy*, WebKit::WebFrameProxy*, API::Object*) { }
@@ -87,7 +87,11 @@
virtual void processDidBecomeResponsive(WebKit::WebPageProxy*) { }
virtual void processDidCrash(WebKit::WebPageProxy*) { }
- virtual void didChangeBackForwardList(WebKit::WebPageProxy*, WebKit::WebBackForwardListItem* addedItem, Vector<RefPtr<WebKit::WebBackForwardListItem>> removedItems) { }
+ virtual void didChangeBackForwardList(WebKit::WebPageProxy*, WebKit::WebBackForwardListItem* addedItem, Vector<RefPtr<WebKit::WebBackForwardListItem>> removedItems)
+ {
+ UNUSED_PARAM(addedItem);
+ UNUSED_PARAM(removedItems);
+ }
virtual void willGoToBackForwardListItem(WebKit::WebPageProxy*, WebKit::WebBackForwardListItem*, API::Object*) { }
#if ENABLE(NETSCAPE_PLUGIN_API)
Modified: trunk/Source/WebKit2/UIProcess/API/APIPolicyClient.h (165793 => 165794)
--- trunk/Source/WebKit2/UIProcess/API/APIPolicyClient.h 2014-03-18 03:16:43 UTC (rev 165793)
+++ trunk/Source/WebKit2/UIProcess/API/APIPolicyClient.h 2014-03-18 03:17:44 UTC (rev 165794)
@@ -51,10 +51,26 @@
public:
virtual ~PolicyClient() { }
- virtual void decidePolicyForNavigationAction(WebKit::WebPageProxy*, WebKit::WebFrameProxy*, const WebKit::NavigationActionData&, WebKit::WebFrameProxy* originatingFrame, const WebCore::ResourceRequest& originalRequest, const WebCore::ResourceRequest&, RefPtr<WebKit::WebFramePolicyListenerProxy> listener, API::Object* userData) { listener->use(); }
- virtual void decidePolicyForNewWindowAction(WebKit::WebPageProxy*, WebKit::WebFrameProxy*, const WebKit::NavigationActionData&, const WebCore::ResourceRequest&, const WTF::String& frameName, RefPtr<WebKit::WebFramePolicyListenerProxy> listener, API::Object* userData) { listener->use(); }
- virtual void decidePolicyForResponse(WebKit::WebPageProxy*, WebKit::WebFrameProxy*, const WebCore::ResourceResponse&, const WebCore::ResourceRequest&, bool canShowMIMEType, RefPtr<WebKit::WebFramePolicyListenerProxy> listener, API::Object* userData) { listener->use(); }
- virtual void unableToImplementPolicy(WebKit::WebPageProxy*, WebKit::WebFrameProxy*, const WebCore::ResourceError&, API::Object* userData) { }
+ virtual void decidePolicyForNavigationAction(WebKit::WebPageProxy*, WebKit::WebFrameProxy*, const WebKit::NavigationActionData&, WebKit::WebFrameProxy* originatingFrame, const WebCore::ResourceRequest& originalRequest, const WebCore::ResourceRequest&, RefPtr<WebKit::WebFramePolicyListenerProxy> listener, API::Object* userData)
+ {
+ UNUSED_PARAM(originatingFrame);
+ UNUSED_PARAM(originalRequest);
+ UNUSED_PARAM(userData);
+ listener->use();
+ }
+ virtual void decidePolicyForNewWindowAction(WebKit::WebPageProxy*, WebKit::WebFrameProxy*, const WebKit::NavigationActionData&, const WebCore::ResourceRequest&, const WTF::String& frameName, RefPtr<WebKit::WebFramePolicyListenerProxy> listener, API::Object* userData)
+ {
+ UNUSED_PARAM(frameName);
+ UNUSED_PARAM(userData);
+ listener->use();
+ }
+ virtual void decidePolicyForResponse(WebKit::WebPageProxy*, WebKit::WebFrameProxy*, const WebCore::ResourceResponse&, const WebCore::ResourceRequest&, bool canShowMIMEType, RefPtr<WebKit::WebFramePolicyListenerProxy> listener, API::Object* userData)
+ {
+ UNUSED_PARAM(canShowMIMEType);
+ UNUSED_PARAM(userData);
+ listener->use();
+ }
+ virtual void unableToImplementPolicy(WebKit::WebPageProxy*, WebKit::WebFrameProxy*, const WebCore::ResourceError&, API::Object* userData) { UNUSED_PARAM(userData); }
};
} // namespace API
Modified: trunk/Source/WebKit2/UIProcess/API/APIUIClient.h (165793 => 165794)
--- trunk/Source/WebKit2/UIProcess/API/APIUIClient.h 2014-03-18 03:16:43 UTC (rev 165793)
+++ trunk/Source/WebKit2/UIProcess/API/APIUIClient.h 2014-03-18 03:17:44 UTC (rev 165794)
@@ -104,7 +104,15 @@
virtual void didDraw(WebKit::WebPageProxy*) { }
virtual void pageDidScroll(WebKit::WebPageProxy*) { }
- virtual unsigned long long exceededDatabaseQuota(WebKit::WebPageProxy*, WebKit::WebFrameProxy*, WebKit::WebSecurityOrigin*, const WTF::String& databaseName, const WTF::String& databaseDisplayName, unsigned long long currentQuota, unsigned long long currentOriginUsage, unsigned long long currentDatabaseUsage, unsigned long long expectedUsage) { return currentQuota; }
+ virtual unsigned long long exceededDatabaseQuota(WebKit::WebPageProxy*, WebKit::WebFrameProxy*, WebKit::WebSecurityOrigin*, const WTF::String& databaseName, const WTF::String& databaseDisplayName, unsigned long long currentQuota, unsigned long long currentOriginUsage, unsigned long long currentDatabaseUsage, unsigned long long expectedUsage)
+ {
+ UNUSED_PARAM(databaseName);
+ UNUSED_PARAM(databaseDisplayName);
+ UNUSED_PARAM(currentOriginUsage);
+ UNUSED_PARAM(currentDatabaseUsage);
+ UNUSED_PARAM(expectedUsage);
+ return currentQuota;
+ }
virtual bool runOpenPanel(WebKit::WebPageProxy*, WebKit::WebFrameProxy*, WebKit::WebOpenPanelParameters*, WebKit::WebOpenPanelResultListenerProxy*) { return false; }
virtual bool decidePolicyForGeolocationPermissionRequest(WebKit::WebPageProxy*, WebKit::WebFrameProxy*, WebKit::WebSecurityOrigin*, WebKit::GeolocationPermissionRequestProxy*) { return false; }
@@ -120,7 +128,12 @@
virtual bool canRunModal() const { return false; }
virtual void runModal(WebKit::WebPageProxy*) { }
- virtual void saveDataToFileInDownloadsFolder(WebKit::WebPageProxy*, const WTF::String& suggestedFilename, const WTF::String& mimeType, const WTF::String& originatingURLString, API::Data*) { }
+ virtual void saveDataToFileInDownloadsFolder(WebKit::WebPageProxy*, const WTF::String& suggestedFilename, const WTF::String& mimeType, const WTF::String& originatingURLString, API::Data*)
+ {
+ UNUSED_PARAM(suggestedFilename);
+ UNUSED_PARAM(mimeType);
+ UNUSED_PARAM(originatingURLString);
+ }
virtual bool shouldInterruptJavaScript(WebKit::WebPageProxy*) { return false; }
};
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp (165793 => 165794)
--- trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp 2014-03-18 03:16:43 UTC (rev 165793)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp 2014-03-18 03:17:44 UTC (rev 165794)
@@ -699,7 +699,7 @@
}
private:
- virtual void didStartProvisionalLoadForFrame(WebPageProxy* page, WebFrameProxy* frame, uint64_t navigationID, API::Object* userData) override
+ virtual void didStartProvisionalLoadForFrame(WebPageProxy* page, WebFrameProxy* frame, uint64_t, API::Object* userData) override
{
if (!m_client.didStartProvisionalLoadForFrame)
return;
@@ -707,7 +707,7 @@
m_client.didStartProvisionalLoadForFrame(toAPI(page), toAPI(frame), toAPI(userData), m_client.base.clientInfo);
}
- virtual void didReceiveServerRedirectForProvisionalLoadForFrame(WebPageProxy* page, WebFrameProxy* frame, uint64_t navigationID, API::Object* userData) override
+ virtual void didReceiveServerRedirectForProvisionalLoadForFrame(WebPageProxy* page, WebFrameProxy* frame, uint64_t, API::Object* userData) override
{
if (!m_client.didReceiveServerRedirectForProvisionalLoadForFrame)
return;
@@ -715,7 +715,7 @@
m_client.didReceiveServerRedirectForProvisionalLoadForFrame(toAPI(page), toAPI(frame), toAPI(userData), m_client.base.clientInfo);
}
- virtual void didFailProvisionalLoadWithErrorForFrame(WebPageProxy* page, WebFrameProxy* frame, uint64_t navigationID, const ResourceError& error, API::Object* userData) override
+ virtual void didFailProvisionalLoadWithErrorForFrame(WebPageProxy* page, WebFrameProxy* frame, uint64_t, const ResourceError& error, API::Object* userData) override
{
if (!m_client.didFailProvisionalLoadWithErrorForFrame)
return;
@@ -723,7 +723,7 @@
m_client.didFailProvisionalLoadWithErrorForFrame(toAPI(page), toAPI(frame), toAPI(error), toAPI(userData), m_client.base.clientInfo);
}
- virtual void didCommitLoadForFrame(WebPageProxy* page, WebFrameProxy* frame, uint64_t navigationID, API::Object* userData) override
+ virtual void didCommitLoadForFrame(WebPageProxy* page, WebFrameProxy* frame, uint64_t, API::Object* userData) override
{
if (!m_client.didCommitLoadForFrame)
return;
@@ -739,7 +739,7 @@
m_client.didFinishDocumentLoadForFrame(toAPI(page), toAPI(frame), toAPI(userData), m_client.base.clientInfo);
}
- virtual void didFinishLoadForFrame(WebPageProxy* page, WebFrameProxy* frame, uint64_t navigationID, API::Object* userData) override
+ virtual void didFinishLoadForFrame(WebPageProxy* page, WebFrameProxy* frame, uint64_t, API::Object* userData) override
{
if (!m_client.didFinishLoadForFrame)
return;
@@ -747,7 +747,7 @@
m_client.didFinishLoadForFrame(toAPI(page), toAPI(frame), toAPI(userData), m_client.base.clientInfo);
}
- virtual void didFailLoadWithErrorForFrame(WebPageProxy* page, WebFrameProxy* frame, uint64_t navigationID, const ResourceError& error, API::Object* userData) override
+ virtual void didFailLoadWithErrorForFrame(WebPageProxy* page, WebFrameProxy* frame, uint64_t, const ResourceError& error, API::Object* userData) override
{
if (!m_client.didFailLoadWithErrorForFrame)
return;
Modified: trunk/Source/WebKit2/UIProcess/APISession.cpp (165793 => 165794)
--- trunk/Source/WebKit2/UIProcess/APISession.cpp 2014-03-18 03:16:43 UTC (rev 165793)
+++ trunk/Source/WebKit2/UIProcess/APISession.cpp 2014-03-18 03:17:44 UTC (rev 165794)
@@ -35,7 +35,7 @@
ASSERT(RunLoop::isMain());
static uint64_t uniqueSessionID = WebCore::SessionID::legacyPrivateSessionID().sessionID();
- ASSERT(isEphemeral);
+ ASSERT_UNUSED(isEphemeral, isEphemeral);
return ++uniqueSessionID;
}
Modified: trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp (165793 => 165794)
--- trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp 2014-03-18 03:16:43 UTC (rev 165793)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp 2014-03-18 03:17:44 UTC (rev 165794)
@@ -500,6 +500,8 @@
{
#if PLATFORM(COCOA)
platformViewStateDidChange(changed);
+#else
+ UNUSED_PARAM(changed);
#endif
}
