Title: [165831] trunk/Source/_javascript_Core
Revision
165831
Author
[email protected]
Date
2014-03-18 12:39:18 -0700 (Tue, 18 Mar 2014)

Log Message

Removed extra parens from if statement in a preprocessor define.
https://bugs.webkit.org/show_bug.cgi?id=130408

Patch by Matthew Mirman <[email protected]> on 2014-03-18
Reviewed by Filip Pizlo.

* parser/Parser.cpp:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (165830 => 165831)


--- trunk/Source/_javascript_Core/ChangeLog	2014-03-18 19:30:39 UTC (rev 165830)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-03-18 19:39:18 UTC (rev 165831)
@@ -1,3 +1,12 @@
+2014-03-18  Matthew Mirman  <[email protected]>
+
+        Removed extra parens from if statement in a preprocessor define.
+        https://bugs.webkit.org/show_bug.cgi?id=130408
+
+        Reviewed by Filip Pizlo.
+
+        * parser/Parser.cpp:
+
 2014-03-18  Filip Pizlo  <[email protected]>
 
         More FTL enabling.

Modified: trunk/Source/_javascript_Core/parser/Parser.cpp (165830 => 165831)


--- trunk/Source/_javascript_Core/parser/Parser.cpp	2014-03-18 19:30:39 UTC (rev 165830)
+++ trunk/Source/_javascript_Core/parser/Parser.cpp	2014-03-18 19:39:18 UTC (rev 165831)
@@ -50,7 +50,7 @@
 #define failWithMessage(...) do { { handleErrorToken(); updateErrorMessage(true, __VA_ARGS__); } return 0; } while (0)
 #define failWithStackOverflow() do { updateErrorMessage(false, "Stack exhausted"); m_hasStackOverflow = true; return 0; } while (0)
 #define failIfFalse(cond, ...) do { if (!(cond)) { handleErrorToken(); internalFailWithMessage(true, __VA_ARGS__); } } while (0)
-#define failIfTrue(cond, ...) do { if ((cond)) { handleErrorToken(); internalFailWithMessage(true, __VA_ARGS__); } } while (0)
+#define failIfTrue(cond, ...) do { if (cond) { handleErrorToken(); internalFailWithMessage(true, __VA_ARGS__); } } while (0)
 #define failIfTrueIfStrict(cond, ...) do { if ((cond) && strictMode()) internalFailWithMessage(false, __VA_ARGS__); } while (0)
 #define failIfFalseIfStrict(cond, ...) do { if ((!(cond)) && strictMode()) internalFailWithMessage(false, __VA_ARGS__); } while (0)
 #define consumeOrFail(tokenType, ...) do { if (!consume(tokenType)) { handleErrorToken(); internalFailWithMessage(true, __VA_ARGS__); } } while (0)
@@ -58,7 +58,7 @@
 #define matchOrFail(tokenType, ...) do { if (!match(tokenType)) { handleErrorToken(); internalFailWithMessage(true, __VA_ARGS__); } } while (0)
 #define failIfStackOverflow() do { if (!canRecurse()) failWithStackOverflow(); } while (0)
 #define semanticFail(...) do { internalFailWithMessage(false, __VA_ARGS__); } while (0)
-#define semanticFailIfTrue(cond, ...) do { if ((cond)) internalFailWithMessage(false, __VA_ARGS__); } while (0)
+#define semanticFailIfTrue(cond, ...) do { if (cond) internalFailWithMessage(false, __VA_ARGS__); } while (0)
 #define semanticFailIfFalse(cond, ...) do { if (!(cond)) internalFailWithMessage(false, __VA_ARGS__); } while (0)
 #define regexFail(failure) do { setErrorMessage(failure); return 0; } while (0)
 #define failDueToUnexpectedToken() do {\
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to