Title: [165841] trunk/Source/WebKit2
Revision
165841
Author
[email protected]
Date
2014-03-18 13:45:27 -0700 (Tue, 18 Mar 2014)

Log Message

REGRESSION: Visited link coloring seems to be completely broken in tip of tree
https://bugs.webkit.org/show_bug.cgi?id=130419
<rdar://problem/16337850>

Reviewed by Dan Bernstein.

Make sure to send any queued up messages before calling connectionWillOpen so we'll ensure
FIFO ordering if any messages are sent from within connectionWillOpen.

* Shared/ChildProcessProxy.cpp:
(WebKit::ChildProcessProxy::didFinishLaunching):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (165840 => 165841)


--- trunk/Source/WebKit2/ChangeLog	2014-03-18 20:36:09 UTC (rev 165840)
+++ trunk/Source/WebKit2/ChangeLog	2014-03-18 20:45:27 UTC (rev 165841)
@@ -1,3 +1,17 @@
+2014-03-18  Anders Carlsson  <[email protected]>
+
+        REGRESSION: Visited link coloring seems to be completely broken in tip of tree
+        https://bugs.webkit.org/show_bug.cgi?id=130419
+        <rdar://problem/16337850>
+
+        Reviewed by Dan Bernstein.
+
+        Make sure to send any queued up messages before calling connectionWillOpen so we'll ensure
+        FIFO ordering if any messages are sent from within connectionWillOpen.
+
+        * Shared/ChildProcessProxy.cpp:
+        (WebKit::ChildProcessProxy::didFinishLaunching):
+
 2014-03-18  Joseph Pecoraro  <[email protected]>
 
         WebPageCreationParameters colorSpace should be MAC not COCOA

Modified: trunk/Source/WebKit2/Shared/ChildProcessProxy.cpp (165840 => 165841)


--- trunk/Source/WebKit2/Shared/ChildProcessProxy.cpp	2014-03-18 20:36:09 UTC (rev 165840)
+++ trunk/Source/WebKit2/Shared/ChildProcessProxy.cpp	2014-03-18 20:45:27 UTC (rev 165841)
@@ -132,15 +132,15 @@
     m_connection->setShouldCloseConnectionOnMachExceptions();
 #endif
 
-    connectionWillOpen(m_connection.get());
-    m_connection->open();
-
     for (size_t i = 0; i < m_pendingMessages.size(); ++i) {
         std::unique_ptr<IPC::MessageEncoder> message = std::move(m_pendingMessages[i].first);
         unsigned messageSendFlags = m_pendingMessages[i].second;
         m_connection->sendMessage(std::move(message), messageSendFlags);
     }
 
+    connectionWillOpen(m_connection.get());
+    m_connection->open();
+
     m_pendingMessages.clear();
 }
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to