Title: [166062] trunk/Tools
- Revision
- 166062
- Author
- [email protected]
- Date
- 2014-03-21 07:49:34 -0700 (Fri, 21 Mar 2014)
Log Message
[webkitpy] Fix has_valid_reviewer()
https://bugs.webkit.org/show_bug.cgi?id=130589
Patch by Eva Balazsfalvi <[email protected]> on 2014-03-21
Reviewed by Csaba Osztrogonác.
* Scripts/webkitpy/common/checkout/changelog.py:
(ChangeLogEntry.has_valid_reviewer):
* Scripts/webkitpy/common/checkout/changelog_unittest.py:
(test_has_valid_reviewer):
* Scripts/webkitpy/common/config/committers.py:
(CommitterList._reviewer_only):
(CommitterList.committer_by_name):
(CommitterList.reviewer_by_email):
(CommitterList):
(CommitterList.reviewer_by_name):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (166061 => 166062)
--- trunk/Tools/ChangeLog 2014-03-21 14:44:10 UTC (rev 166061)
+++ trunk/Tools/ChangeLog 2014-03-21 14:49:34 UTC (rev 166062)
@@ -1,3 +1,21 @@
+2014-03-21 Eva Balazsfalvi <[email protected]>
+
+ [webkitpy] Fix has_valid_reviewer()
+ https://bugs.webkit.org/show_bug.cgi?id=130589
+
+ Reviewed by Csaba Osztrogonác.
+
+ * Scripts/webkitpy/common/checkout/changelog.py:
+ (ChangeLogEntry.has_valid_reviewer):
+ * Scripts/webkitpy/common/checkout/changelog_unittest.py:
+ (test_has_valid_reviewer):
+ * Scripts/webkitpy/common/config/committers.py:
+ (CommitterList._reviewer_only):
+ (CommitterList.committer_by_name):
+ (CommitterList.reviewer_by_email):
+ (CommitterList):
+ (CommitterList.reviewer_by_name):
+
2014-03-21 Jozsef Berta <[email protected]>
Add cache support for jhbuild
Modified: trunk/Tools/Scripts/webkitpy/common/checkout/changelog.py (166061 => 166062)
--- trunk/Tools/Scripts/webkitpy/common/checkout/changelog.py 2014-03-21 14:44:10 UTC (rev 166061)
+++ trunk/Tools/Scripts/webkitpy/common/checkout/changelog.py 2014-03-21 14:49:34 UTC (rev 166062)
@@ -257,7 +257,7 @@
def has_valid_reviewer(self):
if self._reviewers_text_list:
for reviewer in self._reviewers_text_list:
- reviewer = self._committer_list.committer_by_name(reviewer)
+ reviewer = self._committer_list.reviewer_by_name(reviewer)
if reviewer:
return True
return bool(re.search("unreviewed", self._contents, re.IGNORECASE))
Modified: trunk/Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py (166061 => 166062)
--- trunk/Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py 2014-03-21 14:44:10 UTC (rev 166061)
+++ trunk/Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py 2014-03-21 14:49:34 UTC (rev 166062)
@@ -471,6 +471,7 @@
self._assert_has_valid_reviewer("Rubber stamped by Eric.", False)
self._assert_has_valid_reviewer("Rubber stamped by Eric Seidel.", True)
self._assert_has_valid_reviewer("Unreviewed build fix.", True)
+ self._assert_has_valid_reviewer("Reviewed by Gabor Rapcsanyi.", False)
def test_is_touched_files_text_clean(self):
tests = [
Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (166061 => 166062)
--- trunk/Tools/Scripts/webkitpy/common/config/committers.py 2014-03-21 14:44:10 UTC (rev 166061)
+++ trunk/Tools/Scripts/webkitpy/common/config/committers.py 2014-03-21 14:49:34 UTC (rev 166062)
@@ -184,9 +184,6 @@
return None
return record
- def committer_by_name(self, name):
- return self._committer_only(self.contributor_by_name(name))
-
def contributor_by_irc_nickname(self, irc_nickname):
for contributor in self.contributors():
# FIXME: This should do case-insensitive comparison or assert that all IRC nicknames are in lowercase
@@ -269,5 +266,11 @@
def committer_by_email(self, email):
return self._committer_only(self.contributor_by_email(email))
+ def committer_by_name(self, name):
+ return self._committer_only(self.contributor_by_name(name))
+
def reviewer_by_email(self, email):
return self._reviewer_only(self.contributor_by_email(email))
+
+ def reviewer_by_name(self, email):
+ return self._reviewer_only(self.contributor_by_name(email))
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
