Title: [166205] trunk/Source/WebCore
- Revision
- 166205
- Author
- bda...@apple.com
- Date
- 2014-03-24 16:23:22 -0700 (Mon, 24 Mar 2014)
Log Message
Legacy-style scrollbars constantly redraw after scrolling
https://bugs.webkit.org/show_bug.cgi?id=130699
Reviewed by Simon Fraser.
The constant re-draw was happening because we were never calling [ScrollbarPainter
setUsePresentationValue:NO]. This is a silly bug where were should have been
looking at PlatformWheelEvent::momentumPhase() instead of
PlatformWheelEvent::phase()
* page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::handleWheelEvent):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (166204 => 166205)
--- trunk/Source/WebCore/ChangeLog 2014-03-24 23:21:50 UTC (rev 166204)
+++ trunk/Source/WebCore/ChangeLog 2014-03-24 23:23:22 UTC (rev 166205)
@@ -1,3 +1,18 @@
+2014-03-24 Beth Dakin <bda...@apple.com>
+
+ Legacy-style scrollbars constantly redraw after scrolling
+ https://bugs.webkit.org/show_bug.cgi?id=130699
+
+ Reviewed by Simon Fraser.
+
+ The constant re-draw was happening because we were never calling [ScrollbarPainter
+ setUsePresentationValue:NO]. This is a silly bug where were should have been
+ looking at PlatformWheelEvent::momentumPhase() instead of
+ PlatformWheelEvent::phase()
+
+ * page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
+ (WebCore::ScrollingTreeScrollingNodeMac::handleWheelEvent):
+
2014-03-24 Daniel Bates <daba...@apple.com>
XSS Auditor doesn't block <script> injected before an existing <script>
Modified: trunk/Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm (166204 => 166205)
--- trunk/Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm 2014-03-24 23:21:50 UTC (rev 166204)
+++ trunk/Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm 2014-03-24 23:23:22 UTC (rev 166205)
@@ -136,7 +136,7 @@
if (!canHaveScrollbars())
return;
- if (wheelEvent.phase() == PlatformWheelEventPhaseEnded || wheelEvent.phase() == PlatformWheelEventPhaseCancelled) {
+ if (wheelEvent.momentumPhase() == PlatformWheelEventPhaseEnded || wheelEvent.momentumPhase() == PlatformWheelEventPhaseCancelled) {
// If the wheel event is ending or cancelled, then we can tell the ScrollbarPainter API that we won't
// be updating the position from our scrolling thread anymore for the time being.
if (m_verticalScrollbarPainter)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
