Title: [166253] trunk/Source/WebKit2
- Revision
- 166253
- Author
- ander...@apple.com
- Date
- 2014-03-25 14:18:20 -0700 (Tue, 25 Mar 2014)
Log Message
Add more properties to WKWindowFeatures
https://bugs.webkit.org/show_bug.cgi?id=130738
Reviewed by Tim Horton.
* UIProcess/API/Cocoa/WKWindowFeatures.h:
* UIProcess/API/Cocoa/WKWindowFeatures.mm:
(-[WKWindowFeatures _initWithWindowFeatures:WebCore::]):
(-[WKWindowFeatures menuBarVisibility]):
(-[WKWindowFeatures statusBarVisibility]):
(-[WKWindowFeatures toolbarsVisibility]):
(-[WKWindowFeatures allowsResizing]):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (166252 => 166253)
--- trunk/Source/WebKit2/ChangeLog 2014-03-25 21:07:32 UTC (rev 166252)
+++ trunk/Source/WebKit2/ChangeLog 2014-03-25 21:18:20 UTC (rev 166253)
@@ -1,5 +1,20 @@
2014-03-25 Anders Carlsson <ander...@apple.com>
+ Add more properties to WKWindowFeatures
+ https://bugs.webkit.org/show_bug.cgi?id=130738
+
+ Reviewed by Tim Horton.
+
+ * UIProcess/API/Cocoa/WKWindowFeatures.h:
+ * UIProcess/API/Cocoa/WKWindowFeatures.mm:
+ (-[WKWindowFeatures _initWithWindowFeatures:WebCore::]):
+ (-[WKWindowFeatures menuBarVisibility]):
+ (-[WKWindowFeatures statusBarVisibility]):
+ (-[WKWindowFeatures toolbarsVisibility]):
+ (-[WKWindowFeatures allowsResizing]):
+
+2014-03-25 Anders Carlsson <ander...@apple.com>
+
Fix iOS build.
* UIProcess/API/Cocoa/WKWebView.h:
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWindowFeatures.h (166252 => 166253)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWindowFeatures.h 2014-03-25 21:07:32 UTC (rev 166252)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWindowFeatures.h 2014-03-25 21:18:20 UTC (rev 166253)
@@ -31,6 +31,12 @@
WK_API_CLASS
@interface WKWindowFeatures : NSObject
+@property (nonatomic, readonly) NSNumber *menuBarVisibility;
+@property (nonatomic, readonly) NSNumber *statusBarVisibility;
+@property (nonatomic, readonly) NSNumber *toolbarVisibility;
+
+@property (nonatomic, readonly) NSNumber *allowsResizing;
+
@property (nonatomic, readonly) NSNumber *x;
@property (nonatomic, readonly) NSNumber *y;
@property (nonatomic, readonly) NSNumber *width;
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWindowFeatures.mm (166252 => 166253)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWindowFeatures.mm 2014-03-25 21:07:32 UTC (rev 166252)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWindowFeatures.mm 2014-03-25 21:18:20 UTC (rev 166253)
@@ -32,6 +32,12 @@
#import <wtf/RetainPtr.h>
@implementation WKWindowFeatures {
+ RetainPtr<NSNumber> _menuBarVisibility;
+ RetainPtr<NSNumber> _statusBarVisibility;
+ RetainPtr<NSNumber> _toolbarsVisibility;
+
+ RetainPtr<NSNumber> _allowsResizing;
+
RetainPtr<NSNumber> _x;
RetainPtr<NSNumber> _y;
RetainPtr<NSNumber> _width;
@@ -43,6 +49,12 @@
if (!(self = [super init]))
return nil;
+ // FIXME: These should be set to nil if the features didn't exist in the string.
+ _menuBarVisibility = @(windowFeatures.menuBarVisible);
+ _statusBarVisibility = @(windowFeatures.statusBarVisible);
+ _toolbarVisibility = @(windowFeatures.toolBarVisible);
+ _allowsResizing = @(windowFeatures.resizable);
+
if (windowFeatures.xSet)
_x = @(windowFeatures.x);
if (windowFeatures.ySet)
@@ -55,6 +67,26 @@
return self;
}
+- (NSNumber *)menuBarVisibility
+{
+ return _menuBarVisibility.get();
+}
+
+- (NSNumber *)statusBarVisibility
+{
+ return _statusBarVisibility.get();
+}
+
+- (NSNumber *)toolbarsVisibility
+{
+ return _toolbarsVisibility.get();
+}
+
+- (NSNumber *)allowsResizing
+{
+ return _allowsResizing.get();
+}
+
- (NSNumber *)x
{
return _x.get();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
