Title: [166297] trunk/LayoutTests
Revision
166297
Author
da...@apple.com
Date
2014-03-26 09:19:21 -0700 (Wed, 26 Mar 2014)

Log Message

Update LayoutTests to depend on load events rather than on starting loads synchronously
https://bugs.webkit.org/show_bug.cgi?id=130776

Reviewed by Antti Koivisto.

These tests were depending on loads starting synchronously. Instead, they should simply
depend on proper load event behavior.

* dom/html/level1/core/selfhtml.js:
(startTest): Call waitUntilDone immediately, not when the test starts.
* dom/html/level2/core/selfhtml.js:
(startTest): Ditto.
* dom/html/level2/events/selfhtml.js:
(startTest): Ditto.
* dom/html/level2/html/selfhtml.js:
(startTest): Ditto.

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (166296 => 166297)


--- trunk/LayoutTests/ChangeLog	2014-03-26 15:25:28 UTC (rev 166296)
+++ trunk/LayoutTests/ChangeLog	2014-03-26 16:19:21 UTC (rev 166297)
@@ -1,3 +1,22 @@
+2014-03-26  Darin Adler  <da...@apple.com>
+
+        Update LayoutTests to depend on load events rather than on starting loads synchronously
+        https://bugs.webkit.org/show_bug.cgi?id=130776
+
+        Reviewed by Antti Koivisto.
+
+        These tests were depending on loads starting synchronously. Instead, they should simply
+        depend on proper load event behavior.
+
+        * dom/html/level1/core/selfhtml.js:
+        (startTest): Call waitUntilDone immediately, not when the test starts.
+        * dom/html/level2/core/selfhtml.js:
+        (startTest): Ditto.
+        * dom/html/level2/events/selfhtml.js:
+        (startTest): Ditto.
+        * dom/html/level2/html/selfhtml.js:
+        (startTest): Ditto.
+
 2014-03-26  James Craig  <jcr...@apple.com>
 
         Web Inspector: AXI: crash when inspecting "bar" text node in getAccessibilityPropertiesForNode layout test

Modified: trunk/LayoutTests/dom/html/level1/core/selfhtml.js (166296 => 166297)


--- trunk/LayoutTests/dom/html/level1/core/selfhtml.js	2014-03-26 15:25:28 UTC (rev 166296)
+++ trunk/LayoutTests/dom/html/level1/core/selfhtml.js	2014-03-26 16:19:21 UTC (rev 166297)
@@ -670,8 +670,6 @@
 
 
 
-function startTest() {
-
 //
 //  WebKit modification: 18-August-2005
 //
@@ -686,6 +684,8 @@
 //  End WebKit modification
 //
 
+function startTest() {
+
 	//
 	//   invoke test setup
 	//

Modified: trunk/LayoutTests/dom/html/level2/core/selfhtml.js (166296 => 166297)


--- trunk/LayoutTests/dom/html/level2/core/selfhtml.js	2014-03-26 15:25:28 UTC (rev 166296)
+++ trunk/LayoutTests/dom/html/level2/core/selfhtml.js	2014-03-26 16:19:21 UTC (rev 166297)
@@ -670,8 +670,6 @@
 
 
 
-function startTest() {
-
 //
 //  WebKit modification: 18-August-2005
 //
@@ -686,6 +684,8 @@
 //  End WebKit modification
 //
 
+function startTest() {
+
 	//
 	//   invoke test setup
 	//

Modified: trunk/LayoutTests/dom/html/level2/events/selfhtml.js (166296 => 166297)


--- trunk/LayoutTests/dom/html/level2/events/selfhtml.js	2014-03-26 15:25:28 UTC (rev 166296)
+++ trunk/LayoutTests/dom/html/level2/events/selfhtml.js	2014-03-26 16:19:21 UTC (rev 166297)
@@ -670,8 +670,6 @@
 
 
 
-function startTest() {
-
 //
 //  WebKit modification: 18-August-2005
 //
@@ -686,6 +684,8 @@
 //  End WebKit modification
 //
 
+function startTest() {
+
 	//
 	//   invoke test setup
 	//

Modified: trunk/LayoutTests/dom/html/level2/html/selfhtml.js (166296 => 166297)


--- trunk/LayoutTests/dom/html/level2/html/selfhtml.js	2014-03-26 15:25:28 UTC (rev 166296)
+++ trunk/LayoutTests/dom/html/level2/html/selfhtml.js	2014-03-26 16:19:21 UTC (rev 166297)
@@ -670,8 +670,6 @@
 
 
 
-function startTest() {
-
 //
 //  WebKit modification: 18-August-2005
 //
@@ -686,6 +684,8 @@
 //  End WebKit modification
 //
 
+function startTest() {
+
 	//
 	//   invoke test setup
 	//
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to