Title: [166410] trunk/Source/WebKit2
- Revision
- 166410
- Author
- [email protected]
- Date
- 2014-03-28 09:42:02 -0700 (Fri, 28 Mar 2014)
Log Message
[GTK] Running minibrowser with url crashes in debug build
https://bugs.webkit.org/show_bug.cgi?id=130492
Reviewed by Martin Robinson.
Use the ResourceRequest(const URL& url) constructor, instead of the
one taking a String, to call WebPageProxy::loadRequest(), so we
ensure that the passed URI is correctly constructed.
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_load_uri): Create an URL out of a SoupURI and
use that to create a ResourceRequest to pass to loadRequest().
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (166409 => 166410)
--- trunk/Source/WebKit2/ChangeLog 2014-03-28 16:18:01 UTC (rev 166409)
+++ trunk/Source/WebKit2/ChangeLog 2014-03-28 16:42:02 UTC (rev 166410)
@@ -1,3 +1,18 @@
+2014-03-28 Mario Sanchez Prada <[email protected]>
+
+ [GTK] Running minibrowser with url crashes in debug build
+ https://bugs.webkit.org/show_bug.cgi?id=130492
+
+ Reviewed by Martin Robinson.
+
+ Use the ResourceRequest(const URL& url) constructor, instead of the
+ one taking a String, to call WebPageProxy::loadRequest(), so we
+ ensure that the passed URI is correctly constructed.
+
+ * UIProcess/API/gtk/WebKitWebView.cpp:
+ (webkit_web_view_load_uri): Create an URL out of a SoupURI and
+ use that to create a ResourceRequest to pass to loadRequest().
+
2014-03-27 Pratik Solanki <[email protected]>
[iOS WebKit2] Tweak cache sizes for iOS
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp (166409 => 166410)
--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp 2014-03-28 16:18:01 UTC (rev 166409)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp 2014-03-28 16:42:02 UTC (rev 166410)
@@ -2004,7 +2004,8 @@
g_return_if_fail(WEBKIT_IS_WEB_VIEW(webView));
g_return_if_fail(uri);
- getPage(webView)->loadRequest(String::fromUTF8(uri));
+ GUniquePtr<SoupURI> soupURI(soup_uri_new(uri));
+ getPage(webView)->loadRequest(URL(soupURI.get()));
}
/**
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
