Title: [166607] trunk/Source/WebKit2
Revision
166607
Author
timothy_hor...@apple.com
Date
2014-04-01 13:47:18 -0700 (Tue, 01 Apr 2014)

Log Message

[iOS WebKit2] Partial repaint is broken
https://bugs.webkit.org/show_bug.cgi?id=131056

Reviewed by Dean Jackson.

* Shared/mac/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::display):
We need to check if the repaint rects themselves cover the whole
layer's surface, not just their bounds. Otherwise, we'll optimize
out the back->front copy and end up not painting the whole layer.

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (166606 => 166607)


--- trunk/Source/WebKit2/ChangeLog	2014-04-01 20:35:47 UTC (rev 166606)
+++ trunk/Source/WebKit2/ChangeLog	2014-04-01 20:47:18 UTC (rev 166607)
@@ -1,3 +1,16 @@
+2014-04-01  Tim Horton  <timothy_hor...@apple.com>
+
+        [iOS WebKit2] Partial repaint is broken
+        https://bugs.webkit.org/show_bug.cgi?id=131056
+
+        Reviewed by Dean Jackson.
+
+        * Shared/mac/RemoteLayerBackingStore.mm:
+        (WebKit::RemoteLayerBackingStore::display):
+        We need to check if the repaint rects themselves cover the whole
+        layer's surface, not just their bounds. Otherwise, we'll optimize
+        out the back->front copy and end up not painting the whole layer.
+
 2014-04-01  Anders Carlsson  <ander...@apple.com>
 
         Pass a WKNavigationAction to the create UIDelegate method

Modified: trunk/Source/WebKit2/Shared/mac/RemoteLayerBackingStore.mm (166606 => 166607)


--- trunk/Source/WebKit2/Shared/mac/RemoteLayerBackingStore.mm	2014-04-01 20:35:47 UTC (rev 166606)
+++ trunk/Source/WebKit2/Shared/mac/RemoteLayerBackingStore.mm	2014-04-01 20:47:18 UTC (rev 166607)
@@ -180,7 +180,7 @@
     scaledSize.scale(m_scale);
     IntSize expandedScaledSize = expandedIntSize(scaledSize);
 
-    bool willPaintEntireBackingStore = m_dirtyRegion.bounds().contains(layerBounds);
+    bool willPaintEntireBackingStore = m_dirtyRegion.contains(layerBounds);
 #if USE(IOSURFACE)
     if (m_acceleratesDrawing) {
         std::swap(m_frontSurface, m_backSurface);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to