Title: [167260] trunk/PerformanceTests
- Revision
- 167260
- Author
- [email protected]
- Date
- 2014-04-14 12:11:50 -0700 (Mon, 14 Apr 2014)
Log Message
A few MallocBench record/replay fixes
https://bugs.webkit.org/show_bug.cgi?id=131627
Reviewed by Andreas Kling.
* MallocBench/MallocBench/Interpreter.cpp:
(Interpreter::run): Accept 0-sized allocations without asserting because
WebKit does that sometimes.
* MallocBench/MallocBench/flickr.ops:
* MallocBench/MallocBench/flickr_memory_warning.ops:
* MallocBench/MallocBench/reddit.ops:
* MallocBench/MallocBench/reddit_memory_warning.ops:
* MallocBench/MallocBench/theverge.ops:
* MallocBench/MallocBench/theverge_memory_warning.ops: Updated these
recordings because a bug in the recording mechanism caused one out of
every few thousand slot values to be bogus.
Modified Paths
Diff
Modified: trunk/PerformanceTests/ChangeLog (167259 => 167260)
--- trunk/PerformanceTests/ChangeLog 2014-04-14 19:02:26 UTC (rev 167259)
+++ trunk/PerformanceTests/ChangeLog 2014-04-14 19:11:50 UTC (rev 167260)
@@ -1,3 +1,23 @@
+2014-04-14 Geoffrey Garen <[email protected]>
+
+ A few MallocBench record/replay fixes
+ https://bugs.webkit.org/show_bug.cgi?id=131627
+
+ Reviewed by Andreas Kling.
+
+ * MallocBench/MallocBench/Interpreter.cpp:
+ (Interpreter::run): Accept 0-sized allocations without asserting because
+ WebKit does that sometimes.
+
+ * MallocBench/MallocBench/flickr.ops:
+ * MallocBench/MallocBench/flickr_memory_warning.ops:
+ * MallocBench/MallocBench/reddit.ops:
+ * MallocBench/MallocBench/reddit_memory_warning.ops:
+ * MallocBench/MallocBench/theverge.ops:
+ * MallocBench/MallocBench/theverge_memory_warning.ops: Updated these
+ recordings because a bug in the recording mechanism caused one out of
+ every few thousand slot values to be bogus.
+
2014-04-13 Geoffrey Garen <[email protected]>
Added some website recordings to MallocBench -- taken from Membuster
Modified: trunk/PerformanceTests/MallocBench/MallocBench/Interpreter.cpp (167259 => 167260)
--- trunk/PerformanceTests/MallocBench/MallocBench/Interpreter.cpp 2014-04-14 19:02:26 UTC (rev 167259)
+++ trunk/PerformanceTests/MallocBench/MallocBench/Interpreter.cpp 2014-04-14 19:11:50 UTC (rev 167260)
@@ -101,14 +101,12 @@
}
case op_free: {
assert(m_objects[op.slot].object);
- assert(m_objects[op.slot].size);
mbfree(m_objects[op.slot].object, m_objects[op.slot].size);
m_objects[op.slot] = { 0, 0 };
break;
}
case op_realloc: {
assert(m_objects[op.slot].object);
- assert(m_objects[op.slot].size);
m_objects[op.slot] = { mbrealloc(m_objects[op.slot].object, m_objects[op.slot].size, op.size), op.size };
break;
}
Modified: trunk/PerformanceTests/MallocBench/MallocBench/flickr.ops
(Binary files differ)
Modified: trunk/PerformanceTests/MallocBench/MallocBench/flickr_memory_warning.ops
(Binary files differ)
Modified: trunk/PerformanceTests/MallocBench/MallocBench/reddit.ops
(Binary files differ)
Modified: trunk/PerformanceTests/MallocBench/MallocBench/reddit_memory_warning.ops
(Binary files differ)
Modified: trunk/PerformanceTests/MallocBench/MallocBench/theverge.ops
(Binary files differ)
Modified: trunk/PerformanceTests/MallocBench/MallocBench/theverge_memory_warning.ops
(Binary files differ)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
