Title: [167282] trunk/Source/WebCore
Revision
167282
Author
[email protected]
Date
2014-04-14 17:14:59 -0700 (Mon, 14 Apr 2014)

Log Message

[MSE][Mac] video.currentTime is sometimes negative.
https://bugs.webkit.org/show_bug.cgi?id=131644

Reviewed by Eric Carlson.

AVSampleBufferRenderSynchronizer will occasionally return slightly negative values
when beginning playback. Clamp the return value to 0.

* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::currentTimeDouble):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (167281 => 167282)


--- trunk/Source/WebCore/ChangeLog	2014-04-15 00:07:15 UTC (rev 167281)
+++ trunk/Source/WebCore/ChangeLog	2014-04-15 00:14:59 UTC (rev 167282)
@@ -1,3 +1,16 @@
+2014-04-14  Jer Noble  <[email protected]>
+
+        [MSE][Mac] video.currentTime is sometimes negative.
+        https://bugs.webkit.org/show_bug.cgi?id=131644
+
+        Reviewed by Eric Carlson.
+
+        AVSampleBufferRenderSynchronizer will occasionally return slightly negative values
+        when beginning playback. Clamp the return value to 0.
+
+        * platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
+        (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::currentTimeDouble):
+
 2014-04-14  Bem Jones-Bey  <[email protected]>
 
         [CSSExclusions] Remove FIXME referencing closed bug

Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm (167281 => 167282)


--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm	2014-04-15 00:07:15 UTC (rev 167281)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm	2014-04-15 00:14:59 UTC (rev 167282)
@@ -391,7 +391,7 @@
 
 double MediaPlayerPrivateMediaSourceAVFObjC::currentTimeDouble() const
 {
-    return CMTimeGetSeconds(CMTimebaseGetTime([m_synchronizer timebase]));
+    return std::max<double>(0, CMTimeGetSeconds(CMTimebaseGetTime([m_synchronizer timebase])));
 }
 
 double MediaPlayerPrivateMediaSourceAVFObjC::startTimeDouble() const
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to