Title: [167299] trunk
- Revision
- 167299
- Author
- [email protected]
- Date
- 2014-04-14 23:24:42 -0700 (Mon, 14 Apr 2014)
Log Message
Unreviewed, rolling out r167261.
https://bugs.webkit.org/show_bug.cgi?id=131667
broke many navigation tests (Requested by ap on #webkit).
Reverted changeset:
"Web Replay: memoize fallback time values for
document.lastModified"
https://bugs.webkit.org/show_bug.cgi?id=131318
http://trac.webkit.org/changeset/167261
Modified Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (167298 => 167299)
--- trunk/LayoutTests/ChangeLog 2014-04-15 06:13:58 UTC (rev 167298)
+++ trunk/LayoutTests/ChangeLog 2014-04-15 06:24:42 UTC (rev 167299)
@@ -1,5 +1,19 @@
2014-04-14 Commit Queue <[email protected]>
+ Unreviewed, rolling out r167261.
+ https://bugs.webkit.org/show_bug.cgi?id=131667
+
+ broke many navigation tests (Requested by ap on #webkit).
+
+ Reverted changeset:
+
+ "Web Replay: memoize fallback time values for
+ document.lastModified"
+ https://bugs.webkit.org/show_bug.cgi?id=131318
+ http://trac.webkit.org/changeset/167261
+
+2014-04-14 Commit Queue <[email protected]>
+
Unreviewed, rolling out r167272.
https://bugs.webkit.org/show_bug.cgi?id=131666
Deleted: trunk/LayoutTests/http/tests/inspector/replay/document-last-modified-fallback-value.html (167298 => 167299)
--- trunk/LayoutTests/http/tests/inspector/replay/document-last-modified-fallback-value.html 2014-04-15 06:13:58 UTC (rev 167298)
+++ trunk/LayoutTests/http/tests/inspector/replay/document-last-modified-fallback-value.html 2014-04-15 06:24:42 UTC (rev 167299)
@@ -1,33 +0,0 @@
-<html>
-<head>
-<script type="text/_javascript_" src=""
-<script type="text/_javascript_" src=""
-<script>
-
-function appendFrameWithLastModifiedDate(text) {
- document.write('<iframe src="" + escape(text) + '"></iframe>');
-}
-
-appendFrameWithLastModifiedDate('');
-
-function dumpNondeterministicState()
-{
- return Date.parse(frames[0].document.body.textContent);
-}
-
-function test()
-{
- function statesAreEqual(a, b)
- {
- return a === b;
- }
-
- InspectorTest.Replay.runSingleSegmentRefTest(statesAreEqual);
-}
-
-</script>
-</head>
-<body _onload_="runTest()">
-<p>Tests that we can capture and replay nondeterminism in fallback values for document.lastModified</p>
-</body>
-</html>
Modified: trunk/Source/WebCore/ChangeLog (167298 => 167299)
--- trunk/Source/WebCore/ChangeLog 2014-04-15 06:13:58 UTC (rev 167298)
+++ trunk/Source/WebCore/ChangeLog 2014-04-15 06:24:42 UTC (rev 167299)
@@ -1,3 +1,17 @@
+2014-04-14 Commit Queue <[email protected]>
+
+ Unreviewed, rolling out r167261.
+ https://bugs.webkit.org/show_bug.cgi?id=131667
+
+ broke many navigation tests (Requested by ap on #webkit).
+
+ Reverted changeset:
+
+ "Web Replay: memoize fallback time values for
+ document.lastModified"
+ https://bugs.webkit.org/show_bug.cgi?id=131318
+ http://trac.webkit.org/changeset/167261
+
2014-04-14 Simon Fraser <[email protected]>
[iOS WK2] Pages often blank on first load if page loaded by typing the URL
Modified: trunk/Source/WebCore/dom/Document.cpp (167298 => 167299)
--- trunk/Source/WebCore/dom/Document.cpp 2014-04-15 06:13:58 UTC (rev 167298)
+++ trunk/Source/WebCore/dom/Document.cpp 2014-04-15 06:24:42 UTC (rev 167299)
@@ -220,7 +220,6 @@
#endif
#if ENABLE(WEB_REPLAY)
-#include "WebReplayInputs.h"
#include <replay/EmptyInputCursor.h>
#endif
@@ -3892,20 +3891,8 @@
// FIXME: If this document came from the file system, the HTML5
// specificiation tells us to read the last modification date from the file
// system.
- if (!foundDate) {
- double fallbackDate = currentTimeMS();
-#if ENABLE(WEB_REPLAY)
- InputCursor& cursor = inputCursor();
- if (cursor.isCapturing())
- cursor.appendInput<DocumentLastModifiedDate>(fallbackDate);
- else if (cursor.isReplaying()) {
- if (DocumentLastModifiedDate* input = cursor.fetchInput<DocumentLastModifiedDate>())
- fallbackDate = input->fallbackValue();
- }
-#endif
- date.setMillisecondsSinceEpochForDateTime(fallbackDate);
- }
-
+ if (!foundDate)
+ date.setMillisecondsSinceEpochForDateTime(currentTimeMS());
return String::format("%02d/%02d/%04d %02d:%02d:%02d", date.month() + 1, date.monthDay(), date.fullYear(), date.hour(), date.minute(), date.second());
}
Modified: trunk/Source/WebCore/replay/WebInputs.json (167298 => 167299)
--- trunk/Source/WebCore/replay/WebInputs.json 2014-04-15 06:13:58 UTC (rev 167298)
+++ trunk/Source/WebCore/replay/WebInputs.json 2014-04-15 06:24:42 UTC (rev 167299)
@@ -165,14 +165,6 @@
"members": [ ]
},
{
- "name": "DocumentLastModifiedDate",
- "description": "A fallback value used for the document's last modified date if the Last-Modified header can't be found or used.",
- "queue": "SCRIPT_MEMOIZED",
- "members": [
- { "name": "fallbackValue", "type": "double" }
- ]
- },
- {
"name": "EndSegmentSentinel",
"description": "A sentinel input to signal the end of a segment.",
"queue": "EVENT_LOOP",
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
