Title: [167537] trunk/Source/WebKit2
- Revision
- 167537
- Author
- [email protected]
- Date
- 2014-04-19 10:46:07 -0700 (Sat, 19 Apr 2014)
Log Message
[Cocoa] Crash in -[WKWebProcessPlugInHitTestResult nodeHandle] when nodeHandle() is null
https://bugs.webkit.org/show_bug.cgi?id=131888
Reviewed by Jon Honeycutt.
* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInHitTestResult.mm:
(-[WKWebProcessPlugInHitTestResult nodeHandle]): Added a null check.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (167536 => 167537)
--- trunk/Source/WebKit2/ChangeLog 2014-04-19 17:36:22 UTC (rev 167536)
+++ trunk/Source/WebKit2/ChangeLog 2014-04-19 17:46:07 UTC (rev 167537)
@@ -1,3 +1,13 @@
+2014-04-19 Dan Bernstein <[email protected]>
+
+ [Cocoa] Crash in -[WKWebProcessPlugInHitTestResult nodeHandle] when nodeHandle() is null
+ https://bugs.webkit.org/show_bug.cgi?id=131888
+
+ Reviewed by Jon Honeycutt.
+
+ * WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInHitTestResult.mm:
+ (-[WKWebProcessPlugInHitTestResult nodeHandle]): Added a null check.
+
2014-04-19 Simon Fraser <[email protected]>
[iOS WK2] Fuzzy layers on sites using perspective and transforms
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInHitTestResult.mm (167536 => 167537)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInHitTestResult.mm 2014-04-19 17:36:22 UTC (rev 167536)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInHitTestResult.mm 2014-04-19 17:46:07 UTC (rev 167537)
@@ -45,7 +45,7 @@
- (WKWebProcessPlugInNodeHandle *)nodeHandle
{
RefPtr<InjectedBundleNodeHandle> nodeHandle = _hitTestResult->nodeHandle();
- return [wrapper(*nodeHandle.release().leakRef()) autorelease];
+ return nodeHandle ? [wrapper(*nodeHandle.release().leakRef()) autorelease] : nil;
}
#pragma mark WKObject protocol implementation
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
