Title: [167656] trunk/Source/WebKit2
- Revision
- 167656
- Author
- carlo...@webkit.org
- Date
- 2014-04-22 06:36:21 -0700 (Tue, 22 Apr 2014)
Log Message
[GTK] Crash after getting web view context property with g_object_get
https://bugs.webkit.org/show_bug.cgi?id=131983
Reviewed by Philippe Normand.
The problem is that the getter is using g_value_take_object() and
the default context is destroyed when the caller releases its ref.
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewGetProperty): Use g_value_set_object() instead of
g_value_take_object().
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (167655 => 167656)
--- trunk/Source/WebKit2/ChangeLog 2014-04-22 12:00:04 UTC (rev 167655)
+++ trunk/Source/WebKit2/ChangeLog 2014-04-22 13:36:21 UTC (rev 167656)
@@ -1,3 +1,17 @@
+2014-04-22 Carlos Garcia Campos <cgar...@igalia.com>
+
+ [GTK] Crash after getting web view context property with g_object_get
+ https://bugs.webkit.org/show_bug.cgi?id=131983
+
+ Reviewed by Philippe Normand.
+
+ The problem is that the getter is using g_value_take_object() and
+ the default context is destroyed when the caller releases its ref.
+
+ * UIProcess/API/gtk/WebKitWebView.cpp:
+ (webkitWebViewGetProperty): Use g_value_set_object() instead of
+ g_value_take_object().
+
2014-04-22 Ryuan Choi <ryuan.c...@samsung.com>
[EFL][WK2] Remove unnecessary includes in files of Source/WebKit2/UIProcess/API/efl
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp (167655 => 167656)
--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp 2014-04-22 12:00:04 UTC (rev 167655)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp 2014-04-22 13:36:21 UTC (rev 167656)
@@ -560,7 +560,7 @@
switch (propId) {
case PROP_WEB_CONTEXT:
- g_value_take_object(value, webView->priv->context);
+ g_value_set_object(value, webView->priv->context);
break;
case PROP_GROUP:
g_value_set_object(value, webkit_web_view_get_group(webView));
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
