Title: [167783] trunk/Source/WebKit2
- Revision
- 167783
- Author
- [email protected]
- Date
- 2014-04-24 17:17:07 -0700 (Thu, 24 Apr 2014)
Log Message
[iOS] Add some missing overrides and remove unnecessary virtuals
https://bugs.webkit.org/show_bug.cgi?id=132153
Patch by Joseph Pecoraro <[email protected]> on 2014-04-24
Reviewed by Darin Adler.
* UIProcess/ios/PageClientImplIOS.h:
* UIProcess/ios/WebVideoFullscreenManagerProxy.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (167782 => 167783)
--- trunk/Source/WebKit2/ChangeLog 2014-04-25 00:14:14 UTC (rev 167782)
+++ trunk/Source/WebKit2/ChangeLog 2014-04-25 00:17:07 UTC (rev 167783)
@@ -1,3 +1,13 @@
+2014-04-24 Joseph Pecoraro <[email protected]>
+
+ [iOS] Add some missing overrides and remove unnecessary virtuals
+ https://bugs.webkit.org/show_bug.cgi?id=132153
+
+ Reviewed by Darin Adler.
+
+ * UIProcess/ios/PageClientImplIOS.h:
+ * UIProcess/ios/WebVideoFullscreenManagerProxy.h:
+
2014-04-24 Tim Horton <[email protected]>
WebKit2 View Gestures: Use a single struct for the snapshot, and pass it around
Modified: trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.h (167782 => 167783)
--- trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.h 2014-04-25 00:14:14 UTC (rev 167782)
+++ trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.h 2014-04-25 00:17:07 UTC (rev 167783)
@@ -113,9 +113,9 @@
virtual void stopAssistingNode() override;
virtual void selectionDidChange() override;
virtual bool interpretKeyEvent(const NativeWebKeyboardEvent&, bool isCharEvent) override;
- virtual void positionInformationDidChange(const InteractionInformationAtPosition&);
- virtual void saveImageToLibrary(PassRefPtr<WebCore::SharedBuffer>);
- virtual void didUpdateBlockSelectionWithTouch(uint32_t touch, uint32_t flags, float growThreshold, float shrinkThreshold);
+ virtual void positionInformationDidChange(const InteractionInformationAtPosition&) override;
+ virtual void saveImageToLibrary(PassRefPtr<WebCore::SharedBuffer>) override;
+ virtual void didUpdateBlockSelectionWithTouch(uint32_t touch, uint32_t flags, float growThreshold, float shrinkThreshold) override;
virtual void showPlaybackTargetPicker(bool hasVideo, const WebCore::IntRect& elementRect) override;
#if ENABLE(INSPECTOR)
Modified: trunk/Source/WebKit2/UIProcess/ios/WebVideoFullscreenManagerProxy.h (167782 => 167783)
--- trunk/Source/WebKit2/UIProcess/ios/WebVideoFullscreenManagerProxy.h 2014-04-25 00:14:14 UTC (rev 167782)
+++ trunk/Source/WebKit2/UIProcess/ios/WebVideoFullscreenManagerProxy.h 2014-04-25 00:17:07 UTC (rev 167783)
@@ -52,8 +52,8 @@
virtual void didReceiveMessage(IPC::Connection*, IPC::MessageDecoder&) override;
// Translate to FullscreenInterface
- virtual void enterFullscreenWithID(uint32_t, WebCore::IntRect initialRect);
- virtual void setSeekableRangesVector(Vector<std::pair<double, double>>&);
+ void enterFullscreenWithID(uint32_t, WebCore::IntRect initialRect);
+ void setSeekableRangesVector(Vector<std::pair<double, double>>&);
// Fullscreen Observer
virtual void requestExitFullscreen() override;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes