Title: [167814] trunk/Source/_javascript_Core
- Revision
- 167814
- Author
- [email protected]
- Date
- 2014-04-25 12:39:09 -0700 (Fri, 25 Apr 2014)
Log Message
DFG worklist scanning should not treat the key as a separate entity
https://bugs.webkit.org/show_bug.cgi?id=132167
Reviewed by Mark Hahnenberg.
This simplifies the interface to the GC and will enable more optimizations.
* dfg/DFGCompilationKey.cpp:
(JSC::DFG::CompilationKey::visitChildren): Deleted.
* dfg/DFGCompilationKey.h:
* dfg/DFGPlan.cpp:
(JSC::DFG::Plan::visitChildren):
* dfg/DFGWorklist.cpp:
(JSC::DFG::Worklist::visitChildren):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (167813 => 167814)
--- trunk/Source/_javascript_Core/ChangeLog 2014-04-25 18:51:20 UTC (rev 167813)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-04-25 19:39:09 UTC (rev 167814)
@@ -1,3 +1,20 @@
+2014-04-24 Filip Pizlo <[email protected]>
+
+ DFG worklist scanning should not treat the key as a separate entity
+ https://bugs.webkit.org/show_bug.cgi?id=132167
+
+ Reviewed by Mark Hahnenberg.
+
+ This simplifies the interface to the GC and will enable more optimizations.
+
+ * dfg/DFGCompilationKey.cpp:
+ (JSC::DFG::CompilationKey::visitChildren): Deleted.
+ * dfg/DFGCompilationKey.h:
+ * dfg/DFGPlan.cpp:
+ (JSC::DFG::Plan::visitChildren):
+ * dfg/DFGWorklist.cpp:
+ (JSC::DFG::Worklist::visitChildren):
+
2014-04-25 Oliver Hunt <[email protected]>
Remove unused parameter from codeblock linking function
Modified: trunk/Source/_javascript_Core/dfg/DFGCompilationKey.cpp (167813 => 167814)
--- trunk/Source/_javascript_Core/dfg/DFGCompilationKey.cpp 2014-04-25 18:51:20 UTC (rev 167813)
+++ trunk/Source/_javascript_Core/dfg/DFGCompilationKey.cpp 2014-04-25 19:39:09 UTC (rev 167814)
@@ -43,11 +43,6 @@
out.print("(Compile of ", *m_profiledBlock, " with ", m_mode, ")");
}
-void CompilationKey::visitChildren(CodeBlockSet& codeBlocks)
-{
- codeBlocks.mark(m_profiledBlock);
-}
-
} } // namespace JSC::DFG
Modified: trunk/Source/_javascript_Core/dfg/DFGCompilationKey.h (167813 => 167814)
--- trunk/Source/_javascript_Core/dfg/DFGCompilationKey.h 2014-04-25 18:51:20 UTC (rev 167813)
+++ trunk/Source/_javascript_Core/dfg/DFGCompilationKey.h 2014-04-25 19:39:09 UTC (rev 167814)
@@ -80,8 +80,6 @@
return WTF::pairIntHash(WTF::PtrHash<CodeBlock*>::hash(m_profiledBlock), m_mode);
}
- void visitChildren(CodeBlockSet&);
-
void dump(PrintStream&) const;
private:
Modified: trunk/Source/_javascript_Core/dfg/DFGPlan.cpp (167813 => 167814)
--- trunk/Source/_javascript_Core/dfg/DFGPlan.cpp 2014-04-25 18:51:20 UTC (rev 167813)
+++ trunk/Source/_javascript_Core/dfg/DFGPlan.cpp 2014-04-25 19:39:09 UTC (rev 167814)
@@ -424,6 +424,7 @@
for (unsigned i = mustHandleValues.size(); i--;)
visitor.appendUnbarrieredValue(&mustHandleValues[i]);
+ codeBlocks.mark(codeBlock->alternative());
codeBlocks.mark(codeBlock.get());
codeBlocks.mark(profiledDFGCodeBlock.get());
Modified: trunk/Source/_javascript_Core/dfg/DFGWorklist.cpp (167813 => 167814)
--- trunk/Source/_javascript_Core/dfg/DFGWorklist.cpp 2014-04-25 18:51:20 UTC (rev 167813)
+++ trunk/Source/_javascript_Core/dfg/DFGWorklist.cpp 2014-04-25 19:39:09 UTC (rev 167814)
@@ -229,7 +229,6 @@
Plan* plan = iter->value.get();
if (&plan->vm != vm)
continue;
- iter->key.visitChildren(codeBlocks);
iter->value->visitChildren(visitor, codeBlocks);
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
