Title: [167977] trunk/Source
- Revision
- 167977
- Author
- eric.carl...@apple.com
- Date
- 2014-04-29 19:52:01 -0700 (Tue, 29 Apr 2014)
Log Message
[Mac] tag the video layers with descriptive name to aid debugging
https://bugs.webkit.org/show_bug.cgi?id=132371
Reviewed by Darin Adler.
Source/WebCore:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer): Set the AVPlayerLayer
name in a debug build.
Source/WebKit2:
* WebProcess/ios/WebVideoFullscreenManager.mm:
(WebKit::WebVideoFullscreenManager::enterFullscreenForNode): Set the
fullscreen host layer name in a debug build.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (167976 => 167977)
--- trunk/Source/WebCore/ChangeLog 2014-04-30 01:53:53 UTC (rev 167976)
+++ trunk/Source/WebCore/ChangeLog 2014-04-30 02:52:01 UTC (rev 167977)
@@ -1,3 +1,14 @@
+2014-04-29 Eric Carlson <eric.carl...@apple.com>
+
+ [Mac] tag the video layers with descriptive name to aid debugging
+ https://bugs.webkit.org/show_bug.cgi?id=132371
+
+ Reviewed by Darin Adler.
+
+ * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+ (WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer): Set the AVPlayerLayer
+ name in a debug build.
+
2014-04-29 Nikos Andronikos <nikos.andronikos-web...@cisra.canon.com.au>
[GTK][cmake] CMake variable (non)expansion causing 'File name too long' build error.
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (167976 => 167977)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2014-04-30 01:53:53 UTC (rev 167976)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2014-04-30 02:52:01 UTC (rev 167977)
@@ -534,7 +534,7 @@
[m_videoLayer.get() setPlayer:m_avPlayer.get()];
[m_videoLayer.get() setBackgroundColor:cachedCGColor(Color::black, ColorSpaceDeviceRGB)];
#ifndef NDEBUG
- [m_videoLayer.get() setName:@"Video layer"];
+ [m_videoLayer.get() setName:@"MediaPlayerPrivate AVPlayerLayer"];
#endif
updateVideoLayerGravity();
LOG(Media, "MediaPlayerPrivateAVFoundationObjC::createVideoLayer(%p) - returning %p", this, m_videoLayer.get());
Modified: trunk/Source/WebKit2/ChangeLog (167976 => 167977)
--- trunk/Source/WebKit2/ChangeLog 2014-04-30 01:53:53 UTC (rev 167976)
+++ trunk/Source/WebKit2/ChangeLog 2014-04-30 02:52:01 UTC (rev 167977)
@@ -1,3 +1,14 @@
+2014-04-29 Eric Carlson <eric.carl...@apple.com>
+
+ [Mac] tag the video layers with descriptive name to aid debugging
+ https://bugs.webkit.org/show_bug.cgi?id=132371
+
+ Reviewed by Darin Adler.
+
+ * WebProcess/ios/WebVideoFullscreenManager.mm:
+ (WebKit::WebVideoFullscreenManager::enterFullscreenForNode): Set the
+ fullscreen host layer name in a debug build.
+
2014-04-29 Brady Eidson <beid...@apple.com>
Handle selection services menu.
Modified: trunk/Source/WebKit2/WebProcess/ios/WebVideoFullscreenManager.mm (167976 => 167977)
--- trunk/Source/WebKit2/WebProcess/ios/WebVideoFullscreenManager.mm 2014-04-30 01:53:53 UTC (rev 167976)
+++ trunk/Source/WebKit2/WebProcess/ios/WebVideoFullscreenManager.mm 2014-04-30 02:52:01 UTC (rev 167977)
@@ -95,6 +95,9 @@
setMediaElement(toHTMLMediaElement(node));
PlatformLayer* videoLayer = [CALayer layer];
+#ifndef NDEBUG
+ [videoLayer setName:@"Web video fullscreen manager layer"];
+#endif
m_layerHostingContext = LayerHostingContext::createForExternalHostingProcess();
m_layerHostingContext->setRootLayer(videoLayer);
setVideoFullscreenLayer(videoLayer);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
