Title: [168742] trunk/Source/WebCore
- Revision
- 168742
- Author
- [email protected]
- Date
- 2014-05-13 14:45:39 -0700 (Tue, 13 May 2014)
Log Message
Followup to: Update positioning/drawing of the image controls button.
<rdar://problem/16885077> and https://bugs.webkit.org/show_bug.cgi?id=132883
Reviewed by Tim Horton.
Cleared up the actual intent behind review feedback on the original patch.
* html/shadow/mac/ImageControlsButtonElementMac.cpp:
(WebCore::ImageControlsButtonElementMac::maybeCreate):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (168741 => 168742)
--- trunk/Source/WebCore/ChangeLog 2014-05-13 21:38:52 UTC (rev 168741)
+++ trunk/Source/WebCore/ChangeLog 2014-05-13 21:45:39 UTC (rev 168742)
@@ -1,5 +1,17 @@
2014-05-13 Brady Eidson <[email protected]>
+ Followup to: Update positioning/drawing of the image controls button.
+ <rdar://problem/16885077> and https://bugs.webkit.org/show_bug.cgi?id=132883
+
+ Reviewed by Tim Horton.
+
+ Cleared up the actual intent behind review feedback on the original patch.
+
+ * html/shadow/mac/ImageControlsButtonElementMac.cpp:
+ (WebCore::ImageControlsButtonElementMac::maybeCreate):
+
+2014-05-13 Brady Eidson <[email protected]>
+
Update positioning/drawing of the image controls button.
<rdar://problem/16885077> and https://bugs.webkit.org/show_bug.cgi?id=132883
Modified: trunk/Source/WebCore/html/shadow/mac/ImageControlsButtonElementMac.cpp (168741 => 168742)
--- trunk/Source/WebCore/html/shadow/mac/ImageControlsButtonElementMac.cpp 2014-05-13 21:38:52 UTC (rev 168741)
+++ trunk/Source/WebCore/html/shadow/mac/ImageControlsButtonElementMac.cpp 2014-05-13 21:45:39 UTC (rev 168742)
@@ -98,10 +98,10 @@
button->setAttribute(HTMLNames::classAttr, "x-webkit-image-controls-button");
IntSize positionOffset = document.page()->theme().imageControlsButtonPositionOffset();
- button->setInlineStyleProperty(CSSPropertyTop, String::format("%ipx", positionOffset.height()));
+ button->setInlineStyleProperty(CSSPropertyTop, positionOffset.height(), CSSPrimitiveValue::CSS_PX);
// FIXME: Why is right: 0px off the right edge of the parent?
- button->setInlineStyleProperty(CSSPropertyRight, String::format("%ipx", positionOffset.width()));
+ button->setInlineStyleProperty(CSSPropertyRight, positionOffset.width(), CSSPrimitiveValue::CSS_PX);
return button.release();
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
