Title: [168777] trunk/Source/WebCore
- Revision
- 168777
- Author
- [email protected]
- Date
- 2014-05-13 20:58:43 -0700 (Tue, 13 May 2014)
Log Message
m_layerForOverhangAreas is sometimes not positioned correctly when topContentInset
has changed
https://bugs.webkit.org/show_bug.cgi?id=132898
-and corresponding-
<rdar://problem/16644710>
Reviewed by Anders Carlsson.
This function is called whenever the topContentInset changes, so use it as an
opportunity to ensure that m_layerForOverhangAreas has been positioned correctly.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::frameViewDidChangeSize):
Everyone gets an anchor point!
(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (168776 => 168777)
--- trunk/Source/WebCore/ChangeLog 2014-05-14 03:57:18 UTC (rev 168776)
+++ trunk/Source/WebCore/ChangeLog 2014-05-14 03:58:43 UTC (rev 168777)
@@ -1,3 +1,21 @@
+2014-05-13 Beth Dakin <[email protected]>
+
+ m_layerForOverhangAreas is sometimes not positioned correctly when topContentInset
+ has changed
+ https://bugs.webkit.org/show_bug.cgi?id=132898
+ -and corresponding-
+ <rdar://problem/16644710>
+
+ Reviewed by Anders Carlsson.
+
+ This function is called whenever the topContentInset changes, so use it as an
+ opportunity to ensure that m_layerForOverhangAreas has been positioned correctly.
+ * rendering/RenderLayerCompositor.cpp:
+ (WebCore::RenderLayerCompositor::frameViewDidChangeSize):
+
+ Everyone gets an anchor point!
+ (WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
+
2014-05-13 Dean Jackson <[email protected]>
Attempted build fix after https://bugs.webkit.org/show_bug.cgi?id=132891
Modified: trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp (168776 => 168777)
--- trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2014-05-14 03:57:18 UTC (rev 168776)
+++ trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2014-05-14 03:58:43 UTC (rev 168777)
@@ -1549,8 +1549,10 @@
updateOverflowControlsLayers();
#if ENABLE(RUBBER_BANDING)
- if (m_layerForOverhangAreas)
+ if (m_layerForOverhangAreas) {
m_layerForOverhangAreas->setSize(frameView.frameRect().size());
+ m_layerForOverhangAreas->setPosition(FloatPoint(0, m_renderView.frameView().topContentInset()));
+ }
#endif
}
}
@@ -3082,6 +3084,7 @@
overhangAreaSize.setHeight(overhangAreaSize.height() - topContentInset);
m_layerForOverhangAreas->setSize(overhangAreaSize);
m_layerForOverhangAreas->setPosition(FloatPoint(0, topContentInset));
+ m_layerForOverhangAreas->setAnchorPoint(FloatPoint3D());
if (m_renderView.frameView().frame().settings().backgroundShouldExtendBeyondPage())
m_layerForOverhangAreas->setBackgroundColor(m_renderView.frameView().documentBackgroundColor());
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes