Title: [169019] trunk
- Revision
- 169019
- Author
- [email protected]
- Date
- 2014-05-18 15:03:07 -0700 (Sun, 18 May 2014)
Log Message
REGRESSION (r156546): Default media controls are laid out incorrectly when media element is styled with direction:rtl
https://bugs.webkit.org/show_bug.cgi?id=132531
<rdar://problem/16806267>
Source/WebCore:
Reviewed by Mark Rowe.
This was already tested by the media/video-rtl.htm reftest, now unskipped.
* Modules/mediacontrols/mediaControlsApple.css:
(audio::-webkit-media-controls-panel): Add missing direction: ltr
LayoutTests:
Reviewed by Mark Rowe.
* platform/mac/TestExpectations: Unskip media/video-rtl.html
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (169018 => 169019)
--- trunk/LayoutTests/ChangeLog 2014-05-18 21:36:49 UTC (rev 169018)
+++ trunk/LayoutTests/ChangeLog 2014-05-18 22:03:07 UTC (rev 169019)
@@ -1,3 +1,13 @@
+2014-05-18 Maciej Stachowiak <[email protected]>
+
+ REGRESSION (r156546): Default media controls are laid out incorrectly when media element is styled with direction:rtl
+ https://bugs.webkit.org/show_bug.cgi?id=132531
+ <rdar://problem/16806267>
+
+ Reviewed by Mark Rowe.
+
+ * platform/mac/TestExpectations: Unskip media/video-rtl.html
+
2014-05-18 Rik Cabanier <[email protected]>
support for navigator.hardwareConcurrency
Modified: trunk/LayoutTests/platform/mac/TestExpectations (169018 => 169019)
--- trunk/LayoutTests/platform/mac/TestExpectations 2014-05-18 21:36:49 UTC (rev 169018)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2014-05-18 22:03:07 UTC (rev 169019)
@@ -1169,7 +1169,6 @@
webkit.org/b/122021 media/video-controls-captions-trackmenu-only-captions-descriptions-and-subtitles.html
webkit.org/b/122021 media/video-display-toggle.html
webkit.org/b/122021 media/video-empty-source.html
-webkit.org/b/122021 media/video-rtl.html
webkit.org/b/122021 media/video-volume-slider.html
webkit.org/b/122021 media/volume-bar-empty-when-muted.html
webkit.org/b/122021 media/track/track-cue-rendering-vertical.html [ Pass Failure ]
Modified: trunk/Source/WebCore/ChangeLog (169018 => 169019)
--- trunk/Source/WebCore/ChangeLog 2014-05-18 21:36:49 UTC (rev 169018)
+++ trunk/Source/WebCore/ChangeLog 2014-05-18 22:03:07 UTC (rev 169019)
@@ -1,3 +1,16 @@
+2014-05-18 Maciej Stachowiak <[email protected]>
+
+ REGRESSION (r156546): Default media controls are laid out incorrectly when media element is styled with direction:rtl
+ https://bugs.webkit.org/show_bug.cgi?id=132531
+ <rdar://problem/16806267>
+
+ Reviewed by Mark Rowe.
+
+ This was already tested by the media/video-rtl.htm reftest, now unskipped.
+
+ * Modules/mediacontrols/mediaControlsApple.css:
+ (audio::-webkit-media-controls-panel): Add missing direction: ltr
+
2014-05-18 Rik Cabanier <[email protected]>
support for navigator.hardwareConcurrency
Modified: trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.css (169018 => 169019)
--- trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.css 2014-05-18 21:36:49 UTC (rev 169018)
+++ trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.css 2014-05-18 22:03:07 UTC (rev 169019)
@@ -94,6 +94,8 @@
-webkit-align-items: center;
-webkit-user-select: none;
+ direction: ltr;
+
transition: opacity 0.25s linear;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
