Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (169039 => 169040)
--- trunk/Source/_javascript_Core/ChangeLog 2014-05-19 08:44:52 UTC (rev 169039)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-05-19 09:00:56 UTC (rev 169040)
@@ -1,3 +1,19 @@
+2014-05-19 Tanay C <[email protected]>
+
+ Removing some check-webkit-style warnings from ./dfg
+ https://bugs.webkit.org/show_bug.cgi?id=132854
+
+ Reviewed by Darin Adler.
+
+ * dfg/DFGAbstractInterpreter.h:
+ * dfg/DFGAbstractValue.h:
+ * dfg/DFGBlockInsertionSet.h:
+ * dfg/DFGCommonData.h:
+ * dfg/DFGDominators.h:
+ * dfg/DFGGraph.h:
+ * dfg/DFGInPlaceAbstractState.h:
+ * dfg/DFGPredictionPropagationPhase.h:
+
2014-05-18 Filip Pizlo <[email protected]>
Unreviewed, remove bogus comment. We already made the FTL use our calling convention.
Modified: trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreter.h (169039 => 169040)
--- trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreter.h 2014-05-19 08:44:52 UTC (rev 169039)
+++ trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreter.h 2014-05-19 09:00:56 UTC (rev 169040)
@@ -38,7 +38,7 @@
template<typename AbstractStateType>
class AbstractInterpreter {
public:
- AbstractInterpreter(Graph&, AbstractStateType& state);
+ AbstractInterpreter(Graph&, AbstractStateType&);
~AbstractInterpreter();
AbstractValue& forNode(Node* node)
Modified: trunk/Source/_javascript_Core/dfg/DFGAbstractValue.h (169039 => 169040)
--- trunk/Source/_javascript_Core/dfg/DFGAbstractValue.h 2014-05-19 08:44:52 UTC (rev 169039)
+++ trunk/Source/_javascript_Core/dfg/DFGAbstractValue.h 2014-05-19 09:00:56 UTC (rev 169040)
@@ -200,11 +200,11 @@
FiltrationResult filter(Graph&, const StructureSet&);
- FiltrationResult filterArrayModes(ArrayModes arrayModes);
+ FiltrationResult filterArrayModes(ArrayModes);
- FiltrationResult filter(SpeculatedType type);
+ FiltrationResult filter(SpeculatedType);
- FiltrationResult filterByValue(JSValue value);
+ FiltrationResult filterByValue(JSValue);
bool validate(JSValue value) const
{
@@ -397,7 +397,7 @@
checkConsistency();
}
- void setFuturePossibleStructure(Graph&, Structure* structure);
+ void setFuturePossibleStructure(Graph&, Structure*);
void filterValueByType();
void filterArrayModesByType();
Modified: trunk/Source/_javascript_Core/dfg/DFGBlockInsertionSet.h (169039 => 169040)
--- trunk/Source/_javascript_Core/dfg/DFGBlockInsertionSet.h 2014-05-19 08:44:52 UTC (rev 169039)
+++ trunk/Source/_javascript_Core/dfg/DFGBlockInsertionSet.h 2014-05-19 09:00:56 UTC (rev 169040)
@@ -38,11 +38,11 @@
class BlockInsertionSet {
public:
- BlockInsertionSet(Graph& graph);
+ BlockInsertionSet(Graph&);
~BlockInsertionSet();
- void insert(const BlockInsertion& insertion);
- void insert(size_t index, PassRefPtr<BasicBlock> block);
+ void insert(const BlockInsertion&);
+ void insert(size_t index, PassRefPtr<BasicBlock>);
BasicBlock* insert(size_t index, float executionCount);
BasicBlock* insertBefore(BasicBlock* before, float executionCount);
Modified: trunk/Source/_javascript_Core/dfg/DFGCommonData.h (169039 => 169040)
--- trunk/Source/_javascript_Core/dfg/DFGCommonData.h 2014-05-19 08:44:52 UTC (rev 169039)
+++ trunk/Source/_javascript_Core/dfg/DFGCommonData.h 2014-05-19 09:00:56 UTC (rev 169040)
@@ -78,7 +78,7 @@
{ }
void notifyCompilingStructureTransition(Plan&, CodeBlock*, Node*);
- unsigned addCodeOrigin(CodeOrigin codeOrigin);
+ unsigned addCodeOrigin(CodeOrigin);
void shrinkToFit();
Modified: trunk/Source/_javascript_Core/dfg/DFGDominators.h (169039 => 169040)
--- trunk/Source/_javascript_Core/dfg/DFGDominators.h 2014-05-19 08:44:52 UTC (rev 169039)
+++ trunk/Source/_javascript_Core/dfg/DFGDominators.h 2014-05-19 09:00:56 UTC (rev 169040)
@@ -42,7 +42,7 @@
Dominators();
~Dominators();
- void compute(Graph& graph);
+ void compute(Graph&);
bool dominates(BlockIndex from, BlockIndex to) const
{
@@ -55,7 +55,7 @@
return dominates(from->index, to->index);
}
- void dump(Graph& graph, PrintStream&) const;
+ void dump(Graph&, PrintStream&) const;
private:
bool pruneDominators(Graph&, BlockIndex);
Modified: trunk/Source/_javascript_Core/dfg/DFGGraph.h (169039 => 169040)
--- trunk/Source/_javascript_Core/dfg/DFGGraph.h 2014-05-19 08:44:52 UTC (rev 169039)
+++ trunk/Source/_javascript_Core/dfg/DFGGraph.h 2014-05-19 09:00:56 UTC (rev 169040)
@@ -180,7 +180,7 @@
// CodeBlock is optional, but may allow additional information to be dumped (e.g. Identifier names).
void dump(PrintStream& = WTF::dataFile(), DumpContext* = 0);
enum PhiNodeDumpMode { DumpLivePhisOnly, DumpAllPhis };
- void dumpBlockHeader(PrintStream&, const char* prefix, BasicBlock*, PhiNodeDumpMode, DumpContext* context);
+ void dumpBlockHeader(PrintStream&, const char* prefix, BasicBlock*, PhiNodeDumpMode, DumpContext*);
void dump(PrintStream&, Edge);
void dump(PrintStream&, const char* prefix, Node*, DumpContext* = 0);
static int amountOfNodeWhiteSpace(Node*);
@@ -188,7 +188,7 @@
// Dump the code origin of the given node as a diff from the code origin of the
// preceding node. Returns true if anything was printed.
- bool dumpCodeOrigin(PrintStream&, const char* prefix, Node* previousNode, Node* currentNode, DumpContext* context);
+ bool dumpCodeOrigin(PrintStream&, const char* prefix, Node* previousNode, Node* currentNode, DumpContext*);
SpeculatedType getJSConstantSpeculation(Node* node)
{
Modified: trunk/Source/_javascript_Core/dfg/DFGInPlaceAbstractState.h (169039 => 169040)
--- trunk/Source/_javascript_Core/dfg/DFGInPlaceAbstractState.h 2014-05-19 08:44:52 UTC (rev 169039)
+++ trunk/Source/_javascript_Core/dfg/DFGInPlaceAbstractState.h 2014-05-19 09:00:56 UTC (rev 169040)
@@ -38,7 +38,7 @@
class InPlaceAbstractState {
public:
- InPlaceAbstractState(Graph& graph);
+ InPlaceAbstractState(Graph&);
~InPlaceAbstractState();
Modified: trunk/Source/_javascript_Core/dfg/DFGPredictionPropagationPhase.h (169039 => 169040)
--- trunk/Source/_javascript_Core/dfg/DFGPredictionPropagationPhase.h 2014-05-19 08:44:52 UTC (rev 169039)
+++ trunk/Source/_javascript_Core/dfg/DFGPredictionPropagationPhase.h 2014-05-19 09:00:56 UTC (rev 169040)
@@ -46,7 +46,7 @@
bool performPredictionPropagation(Graph&);
// Helper used for FixupPhase for computing the predicted type of a ToPrimitive.
-SpeculatedType resultOfToPrimitive(SpeculatedType type);
+SpeculatedType resultOfToPrimitive(SpeculatedType);
} } // namespace JSC::DFG::Phase
