Title: [169065] trunk/Source/WebCore
- Revision
- 169065
- Author
- [email protected]
- Date
- 2014-05-19 14:09:01 -0700 (Mon, 19 May 2014)
Log Message
Scrollbars display incorrectly after switching between fast and slow scrolling
mode, affects Find and real sites
https://bugs.webkit.org/show_bug.cgi?id=133077
-and corresponding-
<rdar://problem/16888608>
Reviewed by Tim Horton.
We should always return true here when updating on the secondary thread is
supported. It does not need to be gated on whether we are actively taking
advantage of that support at this moment.
* platform/Scrollbar.cpp:
(WebCore::Scrollbar::supportsUpdateOnSecondaryThread):
Always update the presentationValue whenever we update the doubleValue just to
keep them in sync.
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::setPaintCharacteristicsForScrollbar):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (169064 => 169065)
--- trunk/Source/WebCore/ChangeLog 2014-05-19 21:02:24 UTC (rev 169064)
+++ trunk/Source/WebCore/ChangeLog 2014-05-19 21:09:01 UTC (rev 169065)
@@ -1,3 +1,24 @@
+2014-05-19 Beth Dakin <[email protected]>
+
+ Scrollbars display incorrectly after switching between fast and slow scrolling
+ mode, affects Find and real sites
+ https://bugs.webkit.org/show_bug.cgi?id=133077
+ -and corresponding-
+ <rdar://problem/16888608>
+
+ Reviewed by Tim Horton.
+
+ We should always return true here when updating on the secondary thread is
+ supported. It does not need to be gated on whether we are actively taking
+ advantage of that support at this moment.
+ * platform/Scrollbar.cpp:
+ (WebCore::Scrollbar::supportsUpdateOnSecondaryThread):
+
+ Always update the presentationValue whenever we update the doubleValue just to
+ keep them in sync.
+ * platform/mac/ScrollbarThemeMac.mm:
+ (WebCore::ScrollbarThemeMac::setPaintCharacteristicsForScrollbar):
+
2014-05-19 Simon Fraser <[email protected]>
Split scrolling tree ScrollingNodes into FrameScrollingNodes and OverflowScrollingNodes
Modified: trunk/Source/WebCore/platform/Scrollbar.cpp (169064 => 169065)
--- trunk/Source/WebCore/platform/Scrollbar.cpp 2014-05-19 21:02:24 UTC (rev 169064)
+++ trunk/Source/WebCore/platform/Scrollbar.cpp 2014-05-19 21:09:01 UTC (rev 169065)
@@ -550,7 +550,7 @@
// It's unfortunate that this needs to be done with an ifdef. Ideally there would be a way to feature-detect
// the necessary support within AppKit.
#if ENABLE(ASYNC_SCROLLING) && PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101000
- return m_scrollableArea ? !m_scrollableArea->updatesScrollLayerPositionOnMainThread() : false;
+ return true;
#else
return false;
#endif
Modified: trunk/Source/WebCore/platform/mac/ScrollbarThemeMac.mm (169064 => 169065)
--- trunk/Source/WebCore/platform/mac/ScrollbarThemeMac.mm 2014-05-19 21:02:24 UTC (rev 169064)
+++ trunk/Source/WebCore/platform/mac/ScrollbarThemeMac.mm 2014-05-19 21:09:01 UTC (rev 169065)
@@ -479,6 +479,7 @@
[painter setEnabled:scrollbar->enabled()];
[painter setBoundsSize:scrollbar->frameRect().size()];
[painter setDoubleValue:value];
+ [painter setPresentationValue:value];
[painter setKnobProportion:proportion];
END_BLOCK_OBJC_EXCEPTIONS;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
