Title: [169091] trunk/Source/WebKit2
- Revision
- 169091
- Author
- [email protected]
- Date
- 2014-05-19 18:09:37 -0700 (Mon, 19 May 2014)
Log Message
WK2 iOS: Pressing the form navigation button causes the keyboard to be dismissed.
https://bugs.webkit.org/show_bug.cgi?id=133100
<rdar://problem/16808673>
Reviewed by Benjamin Poulain.
The call to focusNextAssistedNode is the result of a user action, since
it is called when the user pressed the form navigation buttons.
Therefore we must set m_userIsInteracting to true before changing the focus
to make sure the focus change is honored.
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::focusNextAssistedNode):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (169090 => 169091)
--- trunk/Source/WebKit2/ChangeLog 2014-05-20 00:55:42 UTC (rev 169090)
+++ trunk/Source/WebKit2/ChangeLog 2014-05-20 01:09:37 UTC (rev 169091)
@@ -1,3 +1,19 @@
+2014-05-19 Enrica Casucci <[email protected]>
+
+ WK2 iOS: Pressing the form navigation button causes the keyboard to be dismissed.
+ https://bugs.webkit.org/show_bug.cgi?id=133100
+ <rdar://problem/16808673>
+
+ Reviewed by Benjamin Poulain.
+
+ The call to focusNextAssistedNode is the result of a user action, since
+ it is called when the user pressed the form navigation buttons.
+ Therefore we must set m_userIsInteracting to true before changing the focus
+ to make sure the focus change is honored.
+
+ * WebProcess/WebPage/ios/WebPageIOS.mm:
+ (WebKit::WebPage::focusNextAssistedNode):
+
2014-05-19 Beth Dakin <[email protected]>
TelephoneNumberOverlayController should use a modern loop for text quad bounding
Modified: trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm (169090 => 169091)
--- trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm 2014-05-20 00:55:42 UTC (rev 169090)
+++ trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm 2014-05-20 01:09:37 UTC (rev 169091)
@@ -1773,8 +1773,10 @@
void WebPage::focusNextAssistedNode(bool isForward)
{
Element* nextElement = nextFocusableElement(m_assistedNode.get(), m_page.get(), isForward);
+ m_userIsInteracting = true;
if (nextElement)
nextElement->focus();
+ m_userIsInteracting = false;
}
void WebPage::getAssistedNodeInformation(AssistedNodeInformation& information)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
