Log Message
Make fast/dom/remove-element-with-{id|name}-that-was-inserted-on-DOMNodeRemoved.html reliable
<http://webkit.org/b/133088>Reviewed by Alexey Proskuryakov. * fast/dom/remove-element-with-id-that-was-inserted-on-DOMNodeRemoved.html: * fast/dom/remove-element-with-name-that-was-inserted-on-DOMNodeRemoved.html: - Use waitUntilDone()/notifyDone() to make the tests reliable since they use setTimeout().
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (169110 => 169111)
--- trunk/LayoutTests/ChangeLog 2014-05-20 14:34:56 UTC (rev 169110)
+++ trunk/LayoutTests/ChangeLog 2014-05-20 14:47:02 UTC (rev 169111)
@@ -1,3 +1,15 @@
+2014-05-20 David Kilzer <[email protected]>
+
+ Make fast/dom/remove-element-with-{id|name}-that-was-inserted-on-DOMNodeRemoved.html reliable
+ <http://webkit.org/b/133088>
+
+ Reviewed by Alexey Proskuryakov.
+
+ * fast/dom/remove-element-with-id-that-was-inserted-on-DOMNodeRemoved.html:
+ * fast/dom/remove-element-with-name-that-was-inserted-on-DOMNodeRemoved.html:
+ - Use waitUntilDone()/notifyDone() to make the tests reliable
+ since they use setTimeout().
+
2014-05-20 Radu Stavila <[email protected]>
[CSS Regions] Block incorrectly sized when containing an unsplittable box
Modified: trunk/LayoutTests/fast/dom/remove-element-with-id-that-was-inserted-on-DOMNodeRemoved.html (169110 => 169111)
--- trunk/LayoutTests/fast/dom/remove-element-with-id-that-was-inserted-on-DOMNodeRemoved.html 2014-05-20 14:34:56 UTC (rev 169110)
+++ trunk/LayoutTests/fast/dom/remove-element-with-id-that-was-inserted-on-DOMNodeRemoved.html 2014-05-20 14:47:02 UTC (rev 169111)
@@ -4,8 +4,10 @@
<body id="declarativeBody"></body>
<!-- Notice a <script> is only executed once. -->
<script>
-if (window.testRunner)
+if (window.testRunner) {
testRunner.dumpAsText();
+ testRunner.waitUntilDone();
+}
var savedDocumentElement;
function appendBodyElementToSavedDocument()
@@ -27,5 +29,7 @@
<!-- This must be in its own <script> so that we execute it (for the first time) when we re-insert it into the document in insertSavedDocument(). -->
<script id="script2">
document.write("PASS, removed element, with HTML attribute id, which was inserted on event DOMNodeRemoved."); // Destroys the entire document, including <body id="declarativeBody"> and <body id="programmaticBody">.
+if (window.testRunner)
+ testRunner.notifyDone();
</script>
</html>
Modified: trunk/LayoutTests/fast/dom/remove-element-with-name-that-was-inserted-on-DOMNodeRemoved.html (169110 => 169111)
--- trunk/LayoutTests/fast/dom/remove-element-with-name-that-was-inserted-on-DOMNodeRemoved.html 2014-05-20 14:34:56 UTC (rev 169110)
+++ trunk/LayoutTests/fast/dom/remove-element-with-name-that-was-inserted-on-DOMNodeRemoved.html 2014-05-20 14:47:02 UTC (rev 169111)
@@ -4,8 +4,10 @@
<body data-debug-name="declarativeBody"></body> <!-- This element isn't necessary, but makes it straightforward to reason about the test when debugging it. -->
<!-- Notice a <script> is only executed once. -->
<script>
-if (window.testRunner)
+if (window.testRunner) {
testRunner.dumpAsText();
+ testRunner.waitUntilDone();
+}
var savedDocumentElement;
function appendBodyElementToSavedDocument()
@@ -36,5 +38,7 @@
// following line to its own <script> and altering the execution time of this page (say, by stepping through code in a WebCore debug session)
// tends to affect the result of |elements| (see remark [1]).
document.write("PASS, removed element, with HTML attribute name, which was inserted on event DOMNodeRemoved.");
+if (window.testRunner)
+ testRunner.notifyDone();
</script>
</html>
_______________________________________________ webkit-changes mailing list [email protected] https://lists.webkit.org/mailman/listinfo/webkit-changes
