Title: [169119] trunk/Source/WebCore
- Revision
- 169119
- Author
- [email protected]
- Date
- 2014-05-20 10:29:35 -0700 (Tue, 20 May 2014)
Log Message
Fix web timing assertion failure.
https://bugs.webkit.org/show_bug.cgi?id=133094
<rdar://problem/16966032>
Patch by Alex Christensen <[email protected]> on 2014-05-20
Reviewed by Alexey Proskuryakov.
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::getConnectionTimingData):
Set requestStart and responseStart to 0 instead of -1 to match the
ResourceLoadTiming constructor and prevent the assertion failure in
PerformanceTiming::responseStart.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (169118 => 169119)
--- trunk/Source/WebCore/ChangeLog 2014-05-20 17:13:35 UTC (rev 169118)
+++ trunk/Source/WebCore/ChangeLog 2014-05-20 17:29:35 UTC (rev 169119)
@@ -1,3 +1,17 @@
+2014-05-20 Alex Christensen <[email protected]>
+
+ Fix web timing assertion failure.
+ https://bugs.webkit.org/show_bug.cgi?id=133094
+ <rdar://problem/16966032>
+
+ Reviewed by Alexey Proskuryakov.
+
+ * platform/network/mac/ResourceHandleMac.mm:
+ (WebCore::ResourceHandle::getConnectionTimingData):
+ Set requestStart and responseStart to 0 instead of -1 to match the
+ ResourceLoadTiming constructor and prevent the assertion failure in
+ PerformanceTiming::responseStart.
+
2014-05-20 Prashant Hiremath <[email protected]>
Only set title on SVG documents
Modified: trunk/Source/WebCore/platform/network/mac/ResourceHandleMac.mm (169118 => 169119)
--- trunk/Source/WebCore/platform/network/mac/ResourceHandleMac.mm 2014-05-20 17:13:35 UTC (rev 169118)
+++ trunk/Source/WebCore/platform/network/mac/ResourceHandleMac.mm 2014-05-20 17:29:35 UTC (rev 169119)
@@ -732,8 +732,8 @@
timing.connectStart = connectStart <= 0 ? -1 : (connectStart - referenceStart) * 1000;
timing.secureConnectionStart = secureConnectionStart <= 0 ? -1 : (secureConnectionStart - referenceStart) * 1000;
timing.connectEnd = connectEnd <= 0 ? -1 : (connectEnd - referenceStart) * 1000;
- timing.requestStart = requestStart <= 0 ? -1 : (requestStart - referenceStart) * 1000;
- timing.responseStart = responseStart <= 0 ? -1 : (responseStart - referenceStart) * 1000;
+ timing.requestStart = requestStart <= 0 ? 0 : (requestStart - referenceStart) * 1000;
+ timing.responseStart = responseStart <= 0 ? 0 : (responseStart - referenceStart) * 1000;
}
#if USE(CFNETWORK)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
