Title: [169129] trunk/Source/WebCore
- Revision
- 169129
- Author
- [email protected]
- Date
- 2014-05-20 13:36:27 -0700 (Tue, 20 May 2014)
Log Message
REGRESSION: All non-mainframe scrollbars don't paint after r169065
https://bugs.webkit.org/show_bug.cgi?id=133132
-and corresponding-
<rdar://problem/16968850>
Reviewed by Geoff Garen.
We should not universally return true here. This feature will only work for
scrollbars with layers.
* platform/ScrollableArea.h:
* platform/Scrollbar.cpp:
(WebCore::Scrollbar::supportsUpdateOnSecondaryThread):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (169128 => 169129)
--- trunk/Source/WebCore/ChangeLog 2014-05-20 20:34:35 UTC (rev 169128)
+++ trunk/Source/WebCore/ChangeLog 2014-05-20 20:36:27 UTC (rev 169129)
@@ -1,3 +1,18 @@
+2014-05-20 Beth Dakin <[email protected]>
+
+ REGRESSION: All non-mainframe scrollbars don't paint after r169065
+ https://bugs.webkit.org/show_bug.cgi?id=133132
+ -and corresponding-
+ <rdar://problem/16968850>
+
+ Reviewed by Geoff Garen.
+
+ We should not universally return true here. This feature will only work for
+ scrollbars with layers.
+ * platform/ScrollableArea.h:
+ * platform/Scrollbar.cpp:
+ (WebCore::Scrollbar::supportsUpdateOnSecondaryThread):
+
2014-05-20 Daniel Bates <[email protected]>
Element within flattened frame may update its scroll state during the layout phase of the wrong RenderView
Modified: trunk/Source/WebCore/platform/ScrollableArea.h (169128 => 169129)
--- trunk/Source/WebCore/platform/ScrollableArea.h 2014-05-20 20:34:35 UTC (rev 169128)
+++ trunk/Source/WebCore/platform/ScrollableArea.h 2014-05-20 20:36:27 UTC (rev 169129)
@@ -234,6 +234,9 @@
virtual GraphicsLayer* layerForHorizontalScrollbar() const { return 0; }
virtual GraphicsLayer* layerForVerticalScrollbar() const { return 0; }
+ bool hasLayerForHorizontalScrollbar() const;
+ bool hasLayerForVerticalScrollbar() const;
+
void verticalScrollbarLayerDidChange();
void horizontalScrollbarLayerDidChange();
@@ -254,8 +257,6 @@
virtual GraphicsLayer* layerForOverhangAreas() const { return 0; }
#endif
- bool hasLayerForHorizontalScrollbar() const;
- bool hasLayerForVerticalScrollbar() const;
bool hasLayerForScrollCorner() const;
private:
Modified: trunk/Source/WebCore/platform/Scrollbar.cpp (169128 => 169129)
--- trunk/Source/WebCore/platform/Scrollbar.cpp 2014-05-20 20:34:35 UTC (rev 169128)
+++ trunk/Source/WebCore/platform/Scrollbar.cpp 2014-05-20 20:36:27 UTC (rev 169129)
@@ -550,7 +550,7 @@
// It's unfortunate that this needs to be done with an ifdef. Ideally there would be a way to feature-detect
// the necessary support within AppKit.
#if ENABLE(ASYNC_SCROLLING) && PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101000
- return true;
+ return m_scrollableArea->hasLayerForVerticalScrollbar() || m_scrollableArea->hasLayerForHorizontalScrollbar();
#else
return false;
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
