Title: [169142] trunk/Source/WebKit2
- Revision
- 169142
- Author
- [email protected]
- Date
- 2014-05-20 17:13:30 -0700 (Tue, 20 May 2014)
Log Message
REGRESSION (WK2): Tapping on the input field in duckduckgo.com shows the keyboard but not the caret.
https://bugs.webkit.org/show_bug.cgi?id=133140
<rdar://problem/16980898>
Reviewed by Benjamin Poulain.
When a page focuses a field on load, we receive the call to startAssistingNode
but we don't create a text interaction assistant if the focus is not originated
by a user action. Upon receiving the selection change notification we don't
call the text interaction assistant, since we don't have one, but we do call
the web selection assistant. We don't have any valid rects for web selection
and we clear the selection on the page, causing the caret not to appear and
the typing to have no effect.
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _updateChangedSelection]):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (169141 => 169142)
--- trunk/Source/WebKit2/ChangeLog 2014-05-21 00:07:56 UTC (rev 169141)
+++ trunk/Source/WebKit2/ChangeLog 2014-05-21 00:13:30 UTC (rev 169142)
@@ -1,3 +1,22 @@
+2014-05-20 Enrica Casucci <[email protected]>
+
+ REGRESSION (WK2): Tapping on the input field in duckduckgo.com shows the keyboard but not the caret.
+ https://bugs.webkit.org/show_bug.cgi?id=133140
+ <rdar://problem/16980898>
+
+ Reviewed by Benjamin Poulain.
+
+ When a page focuses a field on load, we receive the call to startAssistingNode
+ but we don't create a text interaction assistant if the focus is not originated
+ by a user action. Upon receiving the selection change notification we don't
+ call the text interaction assistant, since we don't have one, but we do call
+ the web selection assistant. We don't have any valid rects for web selection
+ and we clear the selection on the page, causing the caret not to appear and
+ the typing to have no effect.
+
+ * UIProcess/ios/WKContentViewInteraction.mm:
+ (-[WKContentView _updateChangedSelection]):
+
2014-05-20 Dean Jackson <[email protected]>
[Mac] Allow popup menus to override default appearance
Modified: trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm (169141 => 169142)
--- trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm 2014-05-21 00:07:56 UTC (rev 169141)
+++ trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm 2014-05-21 00:13:30 UTC (rev 169142)
@@ -2199,7 +2199,7 @@
_markedText = (_page->editorState().hasComposition) ? _page->editorState().markedText : String();
if (!_showingTextStyleOptions)
[_textSelectionAssistant selectionChanged];
- } else
+ } else if (!_page->editorState().isContentEditable)
[_webSelectionAssistant selectionChanged];
_selectionNeedsUpdate = NO;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
