Title: [169232] trunk/LayoutTests
Revision
169232
Author
[email protected]
Date
2014-05-22 17:39:36 -0700 (Thu, 22 May 2014)

Log Message

Fix the  compositing/transitions/transform-on-large-layer.html test
https://bugs.webkit.org/show_bug.cgi?id=133195

Reviewed by Dean Jackson.

This test used window resize when it doesn't need to and was flakey.

* compositing/transitions/transform-on-large-layer.html:
* platform/efl/TestExpectations:
* platform/mac/TestExpectations:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (169231 => 169232)


--- trunk/LayoutTests/ChangeLog	2014-05-23 00:31:20 UTC (rev 169231)
+++ trunk/LayoutTests/ChangeLog	2014-05-23 00:39:36 UTC (rev 169232)
@@ -1,5 +1,18 @@
 2014-05-22  Simon Fraser  <[email protected]>
 
+        Fix the  compositing/transitions/transform-on-large-layer.html test
+        https://bugs.webkit.org/show_bug.cgi?id=133195
+
+        Reviewed by Dean Jackson.
+        
+        This test used window resize when it doesn't need to and was flakey.
+
+        * compositing/transitions/transform-on-large-layer.html:
+        * platform/efl/TestExpectations:
+        * platform/mac/TestExpectations:
+
+2014-05-22  Simon Fraser  <[email protected]>
+
         REGRESSION (r155977): Very stuttery 3D css animation on jtechcommunications.com
         https://bugs.webkit.org/show_bug.cgi?id=133179
         <rdar://problem/16864666>

Modified: trunk/LayoutTests/compositing/transitions/transform-on-large-layer.html (169231 => 169232)


--- trunk/LayoutTests/compositing/transitions/transform-on-large-layer.html	2014-05-23 00:31:20 UTC (rev 169231)
+++ trunk/LayoutTests/compositing/transitions/transform-on-large-layer.html	2014-05-23 00:39:36 UTC (rev 169232)
@@ -4,11 +4,11 @@
     <title>Animating transform on large tiled layer.</title>
     <style type="text/css">
         #box {
-            -webkit-transition: -webkit-transform 0.7s step-end;
             display: block;
             width: 1000px;
             height: 2000px;
             background-color: green;
+            transition: -webkit-transform 0.2s step-end;
         }
 
         #sandbox {
@@ -26,26 +26,27 @@
             -webkit-transform: translate3d(0, 100%, 0);
         }
     </style>
-    <script type="text/_javascript_">
+    <script>
+        if (window.testRunner)
+            testRunner.waitUntilDone();
+
         function run()
         {
-            if (window.testRunner) {
-                testRunner.waitUntilDone();
-                window.setTimeout('window.resizeTo(1600, 1200)', 100);
-            }
-            window._onresize_ = function() {
-                var box = document.getElementById("box");
-                box.className = "end";
-                window.setTimeout('testRunner.notifyDone()', 1500);
-            }
+            var box = document.getElementById('box');
+            box.addEventListener('transitionend', function() {
+                if (window.testRunner)
+                    testRunner.notifyDone();
+            }, false);
+
+            box.className = 'end';
         }
     </script>
 </head>
 <body _onload_="run()">
-    <div id=description>
+    <div id="description">
         The test passes if the box below turns green.
     </div>
-    <div id=sandbox> 
+    <div id="sandbox">
         <div id="box" class="start"><font style="opacity:0">ABC</font></div>
     </div>
 </body>

Modified: trunk/LayoutTests/platform/efl/TestExpectations (169231 => 169232)


--- trunk/LayoutTests/platform/efl/TestExpectations	2014-05-23 00:31:20 UTC (rev 169231)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2014-05-23 00:39:36 UTC (rev 169232)
@@ -1273,9 +1273,6 @@
 
 webkit.org/b/109950 fast/dom/Window/webkitConvertPoint.html [ Failure ]
 
-# Newly added test in r142979 is failing.
-webkit.org/b/109951 compositing/transitions/transform-on-large-layer.html [ ImageOnlyFailure ]
-
 # CUSTOM_ELEMENTS is not enabled.
 webkit.org/b/110958 fast/dom/custom [ Skip ]
 

Modified: trunk/LayoutTests/platform/mac/TestExpectations (169231 => 169232)


--- trunk/LayoutTests/platform/mac/TestExpectations	2014-05-23 00:31:20 UTC (rev 169231)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2014-05-23 00:39:36 UTC (rev 169232)
@@ -1001,8 +1001,6 @@
 webkit.org/b/119374 fast/workers/termination-early.html [ Pass Crash ]
 webkit.org/b/119375 fast/workers/worker-call.html [ Failure ]
 
-webkit.org/b/110027 compositing/transitions/transform-on-large-layer.html [ Pass ImageOnlyFailure ]
-
 webkit.org/b/110186 inspector-protocol/page/_javascript_DialogEvents.html [ Skip ]
 
 # Need support for ResourceHandle::didChangePriority and DRT support
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to