Title: [169250] trunk/Source/WebKit2
Revision
169250
Author
[email protected]
Date
2014-05-22 23:43:05 -0700 (Thu, 22 May 2014)

Log Message

Move the passed-in Vector<Attachment> in MessageDecoder constructor down into ArgumentDecoder
https://bugs.webkit.org/show_bug.cgi?id=133080

Reviewed by Andreas Kling.

* Platform/IPC/MessageDecoder.cpp:
(IPC::MessageDecoder::MessageDecoder): The Vector<Attachment> object was passed in by value.
Move it into the ArgumentDecoder constructor as it is not used elsewhere in this constructor
and produces a copy otherwise.

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (169249 => 169250)


--- trunk/Source/WebKit2/ChangeLog	2014-05-23 06:36:03 UTC (rev 169249)
+++ trunk/Source/WebKit2/ChangeLog	2014-05-23 06:43:05 UTC (rev 169250)
@@ -1,3 +1,15 @@
+2014-05-22  Zan Dobersek  <[email protected]>
+
+        Move the passed-in Vector<Attachment> in MessageDecoder constructor down into ArgumentDecoder
+        https://bugs.webkit.org/show_bug.cgi?id=133080
+
+        Reviewed by Andreas Kling.
+
+        * Platform/IPC/MessageDecoder.cpp:
+        (IPC::MessageDecoder::MessageDecoder): The Vector<Attachment> object was passed in by value.
+        Move it into the ArgumentDecoder constructor as it is not used elsewhere in this constructor
+        and produces a copy otherwise.
+
 2014-05-22  Benjamin Poulain  <[email protected]>
 
         [iOS][WK2] Add support for minimal-ui viewports

Modified: trunk/Source/WebKit2/Platform/IPC/MessageDecoder.cpp (169249 => 169250)


--- trunk/Source/WebKit2/Platform/IPC/MessageDecoder.cpp	2014-05-23 06:36:03 UTC (rev 169249)
+++ trunk/Source/WebKit2/Platform/IPC/MessageDecoder.cpp	2014-05-23 06:43:05 UTC (rev 169250)
@@ -42,7 +42,7 @@
 }
 
 MessageDecoder::MessageDecoder(const DataReference& buffer, Vector<Attachment> attachments)
-    : ArgumentDecoder(buffer.data(), buffer.size(), attachments)
+    : ArgumentDecoder(buffer.data(), buffer.size(), std::move(attachments))
 {
     if (!decode(m_messageFlags))
         return;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to