Title: [169340] trunk/Tools
Revision
169340
Author
[email protected]
Date
2014-05-26 06:55:24 -0700 (Mon, 26 May 2014)

Log Message

run-_javascript_core-tests warning fix on non Mac platforms
https://bugs.webkit.org/show_bug.cgi?id=133260

Patch by Eva Balazsfalvi <[email protected]> on 2014-05-26
Reviewed by Darin Adler.

* Scripts/webkitdirs.pm:
(argumentsForConfiguration):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (169339 => 169340)


--- trunk/Tools/ChangeLog	2014-05-26 12:06:46 UTC (rev 169339)
+++ trunk/Tools/ChangeLog	2014-05-26 13:55:24 UTC (rev 169340)
@@ -1,3 +1,13 @@
+2014-05-26  Eva Balazsfalvi  <[email protected]>
+
+        run-_javascript_core-tests warning fix on non Mac platforms
+        https://bugs.webkit.org/show_bug.cgi?id=133260
+
+        Reviewed by Darin Adler.
+
+        * Scripts/webkitdirs.pm:
+        (argumentsForConfiguration):
+
 2014-05-23  Michael Saboff  <[email protected]>
 
         REGRESSION(r169265): sh: line 0: cd: ../.vm

Modified: trunk/Tools/Scripts/webkitdirs.pm (169339 => 169340)


--- trunk/Tools/Scripts/webkitdirs.pm	2014-05-26 12:06:46 UTC (rev 169339)
+++ trunk/Tools/Scripts/webkitdirs.pm	2014-05-26 13:55:24 UTC (rev 169340)
@@ -380,8 +380,8 @@
     my @args = ();
     push(@args, '--debug') if ($configuration =~ "^Debug");
     push(@args, '--release') if ($configuration =~ "^Release");
-    push(@args, '--device') if ($xcodeSDK =~ /^iphoneos/);
-    push(@args, '--sim') if ($xcodeSDK =~ /^iphonesimulator/);
+    push(@args, '--device') if (defined $xcodeSDK && $xcodeSDK =~ /^iphoneos/);
+    push(@args, '--sim') if (defined $xcodeSDK && $xcodeSDK =~ /^iphonesimulator/);
     push(@args, '--32-bit') if ($architecture ne "x86_64" and !isWin64());
     push(@args, '--64-bit') if (isWin64());
     push(@args, '--gtk') if isGtk();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to