Title: [169878] trunk
Revision
169878
Author
commit-qu...@webkit.org
Date
2014-06-11 22:22:18 -0700 (Wed, 11 Jun 2014)

Log Message

Unreviewed, rolling out r169877.
https://bugs.webkit.org/show_bug.cgi?id=133784

rollout wrong build fix approach for EFL port (Requested by
gyuyoung on #webkit).

Reverted changeset:

"Unreviewed, EFL build fix since r169869."
http://trac.webkit.org/changeset/169877

Modified Paths

Diff

Modified: trunk/ChangeLog (169877 => 169878)


--- trunk/ChangeLog	2014-06-12 05:03:07 UTC (rev 169877)
+++ trunk/ChangeLog	2014-06-12 05:22:18 UTC (rev 169878)
@@ -1,3 +1,16 @@
+2014-06-11  Commit Queue  <commit-qu...@webkit.org>
+
+        Unreviewed, rolling out r169877.
+        https://bugs.webkit.org/show_bug.cgi?id=133784
+
+        rollout wrong build fix approach for EFL port (Requested by
+        gyuyoung on #webkit).
+
+        Reverted changeset:
+
+        "Unreviewed, EFL build fix since r169869."
+        http://trac.webkit.org/changeset/169877
+
 2014-06-11  Gyuyoung Kim  <gyuyoung....@samsung.com>
 
         Unreviewed, EFL build fix since r169869.

Modified: trunk/Source/cmake/WebKitHelpers.cmake (169877 => 169878)


--- trunk/Source/cmake/WebKitHelpers.cmake	2014-06-12 05:03:07 UTC (rev 169877)
+++ trunk/Source/cmake/WebKitHelpers.cmake	2014-06-12 05:22:18 UTC (rev 169878)
@@ -38,11 +38,12 @@
         if (OPTION_ENABLE_WERROR)
             # FIXME: When we use -fno-tree-dce to support the jsCStack branch merge, build error occurs due to the uninitialization. Temporarily we set
             # uninitialized as build warning in order to support the jsCStack merge. https://bugs.webkit.org/show_bug.cgi?id=127777.
-            set(OLD_COMPILE_FLAGS "-Wno-error=unused-parameter -Wno-error=uninitialized -Wno-error=literal-suffix ${OLD_COMPILE_FLAGS}")
+            set(OLD_COMPILE_FLAGS "-Werror -Wno-error=unused-parameter -Wno-error=uninitialized -Wno-error=literal-suffix ${OLD_COMPILE_FLAGS}")
 
-            # For EFL we need to treat undef error as build warning to support EFL port build since r169869.
+            # For EFL we need to treat literal-suffix error as build warning to support EFL port build since r169785.
+            # https://bugs.webkit.org/show_bug.cgi?id=133723.
             if (${PORT} STREQUAL "EFL")
-                set(OLD_COMPILE_FLAGS "-Wno-error=undef ${OLD_COMPILE_FLAGS}")
+                set(OLD_COMPILE_FLAGS "-Wno-error=literal-suffix ${OLD_COMPILE_FLAGS}")
             endif ()
         endif ()
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to