Title: [169921] trunk/Source/WebCore
- Revision
- 169921
- Author
- [email protected]
- Date
- 2014-06-12 16:49:02 -0700 (Thu, 12 Jun 2014)
Log Message
[MSE][Mac] Stop observing the sample buffer renderers when destroying them.
https://bugs.webkit.org/show_bug.cgi?id=133831
Reviewed by Beth Dakin.
Release our retain on our AVSampleBufferDisplayLayer and AVSampleBufferAudioRenderer by stopping
our observation of its properties when removing them from the SourceBufferPrivateAVFObjC object.
* platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(WebCore::SourceBufferPrivateAVFObjC::destroyRenderers):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (169920 => 169921)
--- trunk/Source/WebCore/ChangeLog 2014-06-12 23:30:51 UTC (rev 169920)
+++ trunk/Source/WebCore/ChangeLog 2014-06-12 23:49:02 UTC (rev 169921)
@@ -1,3 +1,16 @@
+2014-06-12 Jer Noble <[email protected]>
+
+ [MSE][Mac] Stop observing the sample buffer renderers when destroying them.
+ https://bugs.webkit.org/show_bug.cgi?id=133831
+
+ Reviewed by Beth Dakin.
+
+ Release our retain on our AVSampleBufferDisplayLayer and AVSampleBufferAudioRenderer by stopping
+ our observation of its properties when removing them from the SourceBufferPrivateAVFObjC object.
+
+ * platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
+ (WebCore::SourceBufferPrivateAVFObjC::destroyRenderers):
+
2014-06-12 Brent Fulgham <[email protected]>
Correct file locations after r169914. These should have been
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm (169920 => 169921)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm 2014-06-12 23:30:51 UTC (rev 169920)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm 2014-06-12 23:49:02 UTC (rev 169921)
@@ -719,6 +719,7 @@
m_mediaSource->player()->removeDisplayLayer(m_displayLayer.get());
[m_displayLayer flush];
[m_displayLayer stopRequestingMediaData];
+ [m_errorListener stopObservingLayer:m_displayLayer.get()];
m_displayLayer = nullptr;
}
@@ -728,6 +729,7 @@
m_mediaSource->player()->removeAudioRenderer(renderer);
[renderer flush];
[renderer stopRequestingMediaData];
+ [m_errorListener stopObservingLayer:renderer];
}
m_audioRenderers.clear();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
